All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: John Keeping <john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Sjoerd Simons
	<sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: rockchip: set system-power-controller on rk3288-rock2
Date: Thu, 19 Nov 2015 22:19:32 +0100	[thread overview]
Message-ID: <1807407.tUv2FxFrog@phil> (raw)
In-Reply-To: <1447940731-5672-1-git-send-email-john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>

Hi John,

Am Donnerstag, 19. November 2015, 13:45:31 schrieb John Keeping:
> Signed-off-by: John Keeping <john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>

please always provide at least a short patch description too.
I've applied the patch but reworded it to

	ARM: dts: rockchip: set system-power-controller property on rk3288-rock2
    
	The act8846 on rock2 boards controls the system power, so add the
	appropriate property to allow turning off the board.

Please holler if you disagree and want it described differently :-) .


Thanks
Heiko


> ---
>  arch/arm/boot/dts/rk3288-rock2-som.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> index 1813b7c3..1ece66f 100644
> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> @@ -109,6 +109,7 @@
>  	act8846: act8846@5a {
>  		compatible = "active-semi,act8846";
>  		reg = <0x5a>;
> +		system-power-controller;
>  		inl1-supply = <&vcc_io>;
>  		inl2-supply = <&vcc_sys>;
>  		inl3-supply = <&vcc_20>;
> 

  parent reply	other threads:[~2015-11-19 21:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19 13:45 [PATCH] ARM: dts: rockchip: set system-power-controller on rk3288-rock2 John Keeping
     [not found] ` <1447940731-5672-1-git-send-email-john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
2015-11-19 21:19   ` Heiko Stuebner [this message]
2015-11-19 22:05     ` John Keeping

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1807407.tUv2FxFrog@phil \
    --to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
    --cc=john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.