From: Neil Brown <neilb@suse.de>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFC] allow mapping from block-device-file to sysfs entry.
Date: Tue, 7 Aug 2007 17:13:20 +1000 [thread overview]
Message-ID: <18104.7056.369176.547630@notabene.brown> (raw)
In-Reply-To: message from Arjan van de Ven on Monday August 6
On Monday August 6, arjan@infradead.org wrote:
> On Tue, 2007-08-07 at 16:07 +1000, Neil Brown wrote:
> > Suppose that in a program I have an open file descriptor for a device,
> > and I want to find the /sys/block information for this device.
> > There is currently no direct way to do this. I need to read
> > /sys/block/*/dev, /sys/block/*/*/dev
> > and match major/minor numbers with the result from fstat.
> >
> > I would like a more direct mechanism.
> >
> > The following patch is a proposal for such a mechanism.
> >
> > It provides an 'ioctl' which returns then 'name' of the device, as
> > generated by bdevname. This is the same name that is used to create
> > entries in sysfs.
> > For a partition of a device, it returns 'device/partition'.
>
>
> how about returning the entire path relative to the start of sysfs? That
> way, if things move or something you're tolerant against that....
That makes a lot of sense.
So it would return "block/sda/sda1" now, but one day that might change
to "class/block/sda/sda1" or some-such.
>
> (I'd not be against making this a generic IOCTL for every device, a
> SYSFSLOCATION kind of ioctl... it's by no means block specific...)
>
That too seems very sensible. Only it's harder to choose a 'generic'
ioctl request number than to choose a block-specific one :-)
We would also need a somewhat longer buffer. The longest
/sys/**/dev
path on my test machine is
/sys/devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1:1.1/usb_endpoint/usbdev2.2_ep82/dev
So at least 80 chars. Probably 256 would do....
#define SYSFSLOCATION _IOR(0, 0xff, char[256])
??
Thanks,
NeilBrown
next prev parent reply other threads:[~2007-08-07 7:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-07 6:07 [PATCH/RFC] allow mapping from block-device-file to sysfs entry Neil Brown
2007-08-07 6:37 ` Arjan van de Ven
2007-08-07 7:13 ` Neil Brown [this message]
2007-08-07 7:41 ` Kay Sievers
2007-08-09 6:50 ` Neil Brown
2007-08-09 9:54 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18104.7056.369176.547630@notabene.brown \
--to=neilb@suse.de \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.