From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A57CC433EF for ; Sat, 26 Mar 2022 21:18:53 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8989A166A; Sat, 26 Mar 2022 22:18:01 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8989A166A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1648329531; bh=TA0cJsJsntvOhwDRimbS8gmkQGvUYMs2q/tFHwmLzFE=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=jCOZoQtVXUQudTK/Cvj0adrJb3gxAoHewGs8Gc39D4+dkt64JFBlLHyaEPCt/73cJ rrBG2qUCYWst7fsAYC7QXEE+JS8N3HaWVRkMbUKwD0+Usd3KI/dzV+IP2fMlT6sKPj EQnW7rtDLxJ/lBlr0NOmI3igj999GRxTEKaPzpio= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0E437F800B6; Sat, 26 Mar 2022 22:18:01 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 66BE1F8019D; Sat, 26 Mar 2022 22:17:58 +0100 (CET) Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 90FFDF800AA for ; Sat, 26 Mar 2022 22:17:55 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 90FFDF800AA Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YRqFWEWA" Received: by mail-lf1-x12b.google.com with SMTP id t25so18801646lfg.7 for ; Sat, 26 Mar 2022 14:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dorKyWKnXy7IlU5rrn/oj/4eomYs0ghYVJYTP+RQhwU=; b=YRqFWEWAZ28v076CK4im5SsXJvYcIfTGKam4+0bSK2o/aS6vIDYE9Y18URClNg/GqB RCIrT5/7wf+CDsHlQvI4o8cs9ZDgVgyG09UsPOCxV7FV/be8bWIFNAdFHLt232AT/u/R 9tApWuES+tn6MKrH+Rd0XeuBjp3pfNrH9xiShEbuRChEEcxs22tXOEpjgP9sHh12IhF7 pyRZ7G5XJCDBc28A619jRNMmcBnapRF4g8eyBhjm8NHdarSvsB1s9EOVtGA7U+e2x7Z+ SqPOCtfjyDxdl+qszxJZ2uetnejw9VLLWyenYM/+BHW6jmXH/0j8qsRyJ0oRFmob/5Oz E37g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dorKyWKnXy7IlU5rrn/oj/4eomYs0ghYVJYTP+RQhwU=; b=qRcP5pKX8sdCVNCl+/vQ75cADX8mtiFPDOyhjVH6FAnVpZDrbFRLYFlnSW48rVqcYj 4FuePS/DNkokIjjFr374VywsZoekGeVw1CEKwjmhXoL4ssebA3I/U4sn7VyreKdEOuc4 JmILc05oKPjqamMKONhWvzby0jvZKyTRywfcSblZ6fJ5W8g5AVeRDTs9jQtysDcfP/2p sOhzu8QNmLUjRB2Qhy0QkMAlMt8KhiCa+a/ML5V3LOF4F2hiwnAql+uMyVv3Mhw7YNIM wWNVOqmFNY7slcIB7aL04HRailUFoMah7xOlVzzLfQUsSXb4sFBQ67Y0kKbuUWYN2kMn LEUg== X-Gm-Message-State: AOAM530bCrGWRmo5nmrHjnQ55djQu9RUxLUYwohKVxi6DmRCoKQ/D46z 99uuuSAGeiUJTObYObSlce4= X-Google-Smtp-Source: ABdhPJwR/+ymjQZpTMAtiHGRcZti14dQruOjPpTxdcJTz7Y/Kj/+bGyN0Cae9N+tEUxHtv4Zv8OG9Q== X-Received: by 2002:ac2:434a:0:b0:443:e48d:50b7 with SMTP id o10-20020ac2434a000000b00443e48d50b7mr13484093lfl.45.1648329472824; Sat, 26 Mar 2022 14:17:52 -0700 (PDT) Received: from dell.intranet (178235254230.gdansk.vectranet.pl. [178.235.254.230]) by smtp.gmail.com with ESMTPSA id h8-20020ac25d68000000b00447b5cad2a7sm1174015lft.228.2022.03.26.14.17.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Mar 2022 14:17:52 -0700 (PDT) From: Janusz Krzysztofik To: Aaro Koskinen Subject: Re: [PATCH v2] ARM: OMAP1: Prepare for conversion of OMAP1 clocks to CCF Date: Sat, 26 Mar 2022 22:17:49 +0100 Message-ID: <1810824.tdWV9SEqCh@dell> In-Reply-To: <20220322190753.GF297526@darkstar.musicnaut.iki.fi> References: <20220310233307.99220-3-jmkrzyszt@gmail.com> <20220322163646.GD297526@darkstar.musicnaut.iki.fi> <20220322190753.GF297526@darkstar.musicnaut.iki.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: alsa-devel@alsa-project.org, Felipe Balbi , Paul Walmsley , Arnd Bergmann , Liam Girdwood , Tony Lindgren , Greg Kroah-Hartman , Helge Deller , linux-usb@vger.kernel.org, linux-mmc@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown , Alan Stern , Ulf Hansson , linux-omap@vger.kernel.org, Peter Ujfalusi , linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Aaro, Dnia wtorek, 22 marca 2022 20:07:53 CET Aaro Koskinen pisze: > Hi, > > On Tue, Mar 22, 2022 at 06:36:48PM +0200, Aaro Koskinen wrote: > > On Mon, Mar 21, 2022 at 10:54:16PM +0100, Janusz Krzysztofik wrote: > > > In preparation for conversion of OMAP1 clocks to common clock framework, > > > identify users of those clocks which don't call clk_prepare/unprepare() > > > and update them to call clk_prepare_enable/clk_disable_unprepare() instead > > > of just clk_enable/disable(), as required by CCF implementation of clock > > > API. > > > > > > v2: update still a few more OMAP specific drivers missed in v1, > > > - call clk_prepare/unprepare() just after/before clk_get/put() where it > > > can make more sense than merging prepare/unprepare with enable/disable. > > > > Something is still broken. When doing kexec (using CCF kernel), the > > kexec'ed kernel now hangs early (on 770): > [...] > > [ 0.928863] calling omap1_init_devices+0x0/0x2c @ 1 > > It hangs in omap_sram_reprogram_clock() (<- omap1_select_table_rate() > <- omap1_clk_late_init()). I've reviewed my changes but haven't found anything suspicious. Could you please provide: - dmesg from both cold start and kexec, both non-CCF and CCF version, - contents of /sys/kernel/debug/clock/summary (non-CCF) after boot/kexec, - contents of /sys/kernel/debug/clk/clk_summary (CCF) after boot? Thanks, Janusz > > A. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42683C433EF for ; Sat, 26 Mar 2022 21:17:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235363AbiCZVTd (ORCPT ); Sat, 26 Mar 2022 17:19:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229921AbiCZVTc (ORCPT ); Sat, 26 Mar 2022 17:19:32 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68AC662FF; Sat, 26 Mar 2022 14:17:55 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id m3so18776847lfj.11; Sat, 26 Mar 2022 14:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dorKyWKnXy7IlU5rrn/oj/4eomYs0ghYVJYTP+RQhwU=; b=YRqFWEWAZ28v076CK4im5SsXJvYcIfTGKam4+0bSK2o/aS6vIDYE9Y18URClNg/GqB RCIrT5/7wf+CDsHlQvI4o8cs9ZDgVgyG09UsPOCxV7FV/be8bWIFNAdFHLt232AT/u/R 9tApWuES+tn6MKrH+Rd0XeuBjp3pfNrH9xiShEbuRChEEcxs22tXOEpjgP9sHh12IhF7 pyRZ7G5XJCDBc28A619jRNMmcBnapRF4g8eyBhjm8NHdarSvsB1s9EOVtGA7U+e2x7Z+ SqPOCtfjyDxdl+qszxJZ2uetnejw9VLLWyenYM/+BHW6jmXH/0j8qsRyJ0oRFmob/5Oz E37g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dorKyWKnXy7IlU5rrn/oj/4eomYs0ghYVJYTP+RQhwU=; b=OWtiosIj/h7OB969mbqPDwL32NnFGh+IdR5T+kFRrgdcDsCPaYcBF2jaw1TVndYTI1 gI6Zz/2j8a9NWwLkqi/riLMGSqwqbWH1VPnM5/KDzf+J0GUTkpKImYqNDB+gS2Erz2uS Nc9ZP8ahIcEheGpLr8oIUivl2nw5pQEDU1b/S+WtwoKMy1krKIKr/GCDPhR2mcvUDa3N KV1+N0UpLYZG6SL8LeMgfGtTPHDAlbG5+0b4djxAvVigIm4JaU+rwkWJhYD+p/xXL6IH 3FzxUyMmlChbgLE+uYPNG2K+5SfTbgkVue/bDu/XBwGC/+hg7VWXs8uOr1tnBK50RDBw Dphg== X-Gm-Message-State: AOAM533wnbmlWFwTFFPbwpbCK8kPmcrR3BMNlkNZDboD+y/BlxtKDJoQ FwqVkJWRKPgiYxAqTzoOlPS2rTYWiyvaEg== X-Google-Smtp-Source: ABdhPJwR/+ymjQZpTMAtiHGRcZti14dQruOjPpTxdcJTz7Y/Kj/+bGyN0Cae9N+tEUxHtv4Zv8OG9Q== X-Received: by 2002:ac2:434a:0:b0:443:e48d:50b7 with SMTP id o10-20020ac2434a000000b00443e48d50b7mr13484093lfl.45.1648329472824; Sat, 26 Mar 2022 14:17:52 -0700 (PDT) Received: from dell.intranet (178235254230.gdansk.vectranet.pl. [178.235.254.230]) by smtp.gmail.com with ESMTPSA id h8-20020ac25d68000000b00447b5cad2a7sm1174015lft.228.2022.03.26.14.17.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Mar 2022 14:17:52 -0700 (PDT) From: Janusz Krzysztofik To: Aaro Koskinen Cc: Tony Lindgren , Paul Walmsley , Alan Stern , Greg Kroah-Hartman , Helge Deller , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ulf Hansson , Arnd Bergmann , Felipe Balbi , Peter Ujfalusi , Liam Girdwood , Mark Brown , linux-mmc@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v2] ARM: OMAP1: Prepare for conversion of OMAP1 clocks to CCF Date: Sat, 26 Mar 2022 22:17:49 +0100 Message-ID: <1810824.tdWV9SEqCh@dell> In-Reply-To: <20220322190753.GF297526@darkstar.musicnaut.iki.fi> References: <20220310233307.99220-3-jmkrzyszt@gmail.com> <20220322163646.GD297526@darkstar.musicnaut.iki.fi> <20220322190753.GF297526@darkstar.musicnaut.iki.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hi Aaro, Dnia wtorek, 22 marca 2022 20:07:53 CET Aaro Koskinen pisze: > Hi, > > On Tue, Mar 22, 2022 at 06:36:48PM +0200, Aaro Koskinen wrote: > > On Mon, Mar 21, 2022 at 10:54:16PM +0100, Janusz Krzysztofik wrote: > > > In preparation for conversion of OMAP1 clocks to common clock framework, > > > identify users of those clocks which don't call clk_prepare/unprepare() > > > and update them to call clk_prepare_enable/clk_disable_unprepare() instead > > > of just clk_enable/disable(), as required by CCF implementation of clock > > > API. > > > > > > v2: update still a few more OMAP specific drivers missed in v1, > > > - call clk_prepare/unprepare() just after/before clk_get/put() where it > > > can make more sense than merging prepare/unprepare with enable/disable. > > > > Something is still broken. When doing kexec (using CCF kernel), the > > kexec'ed kernel now hangs early (on 770): > [...] > > [ 0.928863] calling omap1_init_devices+0x0/0x2c @ 1 > > It hangs in omap_sram_reprogram_clock() (<- omap1_select_table_rate() > <- omap1_clk_late_init()). I've reviewed my changes but haven't found anything suspicious. Could you please provide: - dmesg from both cold start and kexec, both non-CCF and CCF version, - contents of /sys/kernel/debug/clock/summary (non-CCF) after boot/kexec, - contents of /sys/kernel/debug/clk/clk_summary (CCF) after boot? Thanks, Janusz > > A. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F5A8C433F5 for ; Sat, 26 Mar 2022 21:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z6yEvJx69ku7uh6HtGK1VrJV3Md4yqjleh7EmnM97+U=; b=tgBKssUYrWMW3R VBT5vQpm77kTZpIqDVq5xueQLsZwCGg8MYthNC6Q0Qtyt42ZjO8H8Yyw7+TmQaD3q2NSpP09wbJNm Ms1knpOsQs8YmiHsw93FoBbMuNHsx6XY38W0MFBS83bG9/aoxnEHMkpj7s860bPf+8wqVO8NC9zXE 1BaddXtgCZgwSDgJnOVWThYxWuPbHLjsXcdhS5pGyZG1i2K67W7w3LC/nIj/ekaLmrZrry1jii1rH 6OzmVr2j5J0gaAXzRamOAh0/40Ph9CJ2Xi3YzPFdbWlAzS1G3znoZKV3aLyCbelCxlYoPrJ2YRNEb RW5t9yk3RAn9fTM6awFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYDnK-004vR0-Nv; Sat, 26 Mar 2022 21:17:58 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYDnH-004vQZ-O1 for linux-arm-kernel@lists.infradead.org; Sat, 26 Mar 2022 21:17:57 +0000 Received: by mail-lf1-x134.google.com with SMTP id h7so18826924lfl.2 for ; Sat, 26 Mar 2022 14:17:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dorKyWKnXy7IlU5rrn/oj/4eomYs0ghYVJYTP+RQhwU=; b=YRqFWEWAZ28v076CK4im5SsXJvYcIfTGKam4+0bSK2o/aS6vIDYE9Y18URClNg/GqB RCIrT5/7wf+CDsHlQvI4o8cs9ZDgVgyG09UsPOCxV7FV/be8bWIFNAdFHLt232AT/u/R 9tApWuES+tn6MKrH+Rd0XeuBjp3pfNrH9xiShEbuRChEEcxs22tXOEpjgP9sHh12IhF7 pyRZ7G5XJCDBc28A619jRNMmcBnapRF4g8eyBhjm8NHdarSvsB1s9EOVtGA7U+e2x7Z+ SqPOCtfjyDxdl+qszxJZ2uetnejw9VLLWyenYM/+BHW6jmXH/0j8qsRyJ0oRFmob/5Oz E37g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dorKyWKnXy7IlU5rrn/oj/4eomYs0ghYVJYTP+RQhwU=; b=XP+Q2wgpQYjB3hAh23pdL4i8Eqk48Rv8N/sbF6RJNE0W4aQnAuBVrfuD6sFMjLDyOK MClSO5CvlKSyrMlC3yDh8Mbx78xZ+sLkm5I12BtMtbmtRfh/1VdkZVHdWdHQgLAqMfyU LlIy/r7OU71ZFjcMEHNi25rlQShVh7v70+tMKqJvcZ/jhVY2igYx90YGNPldXJDDIlQ2 qDJ9X7e+ns9EnWq7oj651p385kSuv2wyAWUf7InQAk/rxFOk2ZyR88tccPPOmhceMLw9 sE5TvusmSPFJLn6HGoYQjrpm8P+GJQp7GMwOZWj7aKjTl00zmNu1qN4rmAO+O75lPA5x rFJQ== X-Gm-Message-State: AOAM532VwY/TSG4uNbk+7BzKqMSN1/ACpDai/+e7398MSHIcbwdZTsQ1 9XLRyhVRO0zfery8x7JGZ5M= X-Google-Smtp-Source: ABdhPJwR/+ymjQZpTMAtiHGRcZti14dQruOjPpTxdcJTz7Y/Kj/+bGyN0Cae9N+tEUxHtv4Zv8OG9Q== X-Received: by 2002:ac2:434a:0:b0:443:e48d:50b7 with SMTP id o10-20020ac2434a000000b00443e48d50b7mr13484093lfl.45.1648329472824; Sat, 26 Mar 2022 14:17:52 -0700 (PDT) Received: from dell.intranet (178235254230.gdansk.vectranet.pl. [178.235.254.230]) by smtp.gmail.com with ESMTPSA id h8-20020ac25d68000000b00447b5cad2a7sm1174015lft.228.2022.03.26.14.17.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Mar 2022 14:17:52 -0700 (PDT) From: Janusz Krzysztofik To: Aaro Koskinen Cc: Tony Lindgren , Paul Walmsley , Alan Stern , Greg Kroah-Hartman , Helge Deller , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ulf Hansson , Arnd Bergmann , Felipe Balbi , Peter Ujfalusi , Liam Girdwood , Mark Brown , linux-mmc@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v2] ARM: OMAP1: Prepare for conversion of OMAP1 clocks to CCF Date: Sat, 26 Mar 2022 22:17:49 +0100 Message-ID: <1810824.tdWV9SEqCh@dell> In-Reply-To: <20220322190753.GF297526@darkstar.musicnaut.iki.fi> References: <20220310233307.99220-3-jmkrzyszt@gmail.com> <20220322163646.GD297526@darkstar.musicnaut.iki.fi> <20220322190753.GF297526@darkstar.musicnaut.iki.fi> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220326_141755_833834_E311EF7D X-CRM114-Status: GOOD ( 17.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Aaro, Dnia wtorek, 22 marca 2022 20:07:53 CET Aaro Koskinen pisze: > Hi, > > On Tue, Mar 22, 2022 at 06:36:48PM +0200, Aaro Koskinen wrote: > > On Mon, Mar 21, 2022 at 10:54:16PM +0100, Janusz Krzysztofik wrote: > > > In preparation for conversion of OMAP1 clocks to common clock framework, > > > identify users of those clocks which don't call clk_prepare/unprepare() > > > and update them to call clk_prepare_enable/clk_disable_unprepare() instead > > > of just clk_enable/disable(), as required by CCF implementation of clock > > > API. > > > > > > v2: update still a few more OMAP specific drivers missed in v1, > > > - call clk_prepare/unprepare() just after/before clk_get/put() where it > > > can make more sense than merging prepare/unprepare with enable/disable. > > > > Something is still broken. When doing kexec (using CCF kernel), the > > kexec'ed kernel now hangs early (on 770): > [...] > > [ 0.928863] calling omap1_init_devices+0x0/0x2c @ 1 > > It hangs in omap_sram_reprogram_clock() (<- omap1_select_table_rate() > <- omap1_clk_late_init()). I've reviewed my changes but haven't found anything suspicious. Could you please provide: - dmesg from both cold start and kexec, both non-CCF and CCF version, - contents of /sys/kernel/debug/clock/summary (non-CCF) after boot/kexec, - contents of /sys/kernel/debug/clk/clk_summary (CCF) after boot? Thanks, Janusz > > A. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel