From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-stable] [PATCH] bus/dpaa: fix compilation
	issue with meson build
Date: Thu, 21 Jun 2018 10:25:11 +0200
Message-ID: <1811028.V65RX0Btn7@xps>
References: <20180604025246.25548-1-jerin.jacob@caviumnetworks.com>
 <8af66cf6-6059-424d-c6d7-1c2439204b9e@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: stable@dpdk.org, Shreyansh Jain <shreyansh.jain@nxp.com>, dev@dpdk.org,
 hemant.agrawal@nxp.com, bruce.richardson@intel.com
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <8af66cf6-6059-424d-c6d7-1c2439204b9e@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

05/06/2018 08:20, Shreyansh Jain:
> On 6/4/2018 8:22 AM, Jerin Jacob wrote:
> > ccache gcc -Idrivers/drivers@@tmp_rte_pmd_dpaa_sec@sta -Idrivers
> > In file included from ../drivers/bus/dpaa/include/fsl_usd.h:11,
> >                   from ../drivers/crypto/dpaa_sec/dpaa_sec.c:27:
> > ../drivers/bus/dpaa/include/compat.h:53:
> >   error: "__packed" redefined [-Werror]
> >   #define __packed __rte_packed
> > 
> > In file included from /usr/include/bsd/string.h:39,
> > from ../lib/librte_eal/common/include/rte_string_fns.h:71,
> > from ../drivers/crypto/dpaa_sec/dpaa_sec.c:25:
> > /usr/include/bsd/sys/cdefs.h:120: note: this is the location
> > of the previous definition
> > #  define __packed __attribute__((__packed__))
> > 
> > Cc: stable@dpdk.org
> > Fixes: 39f373cf015a ("bus/dpaa: add compatibility and helper macros")
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> 
> Thanks Jerin.
> Somehow, this didn't appear on my build environment (maybe because LIB 
> BSD is not enabled?). But, the change looks harmless.
> 
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>

I missed this patch and sent a more complete one recently:

	https://patches.dpdk.org/patch/41314/