From: Thomas Monjalon <thomas@monjalon.net>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCHv2 1/2] bitratestats: add support for free
Date: Sat, 11 Jul 2020 00:30:12 +0200 [thread overview]
Message-ID: <1814150.q2JAx3WZxH@thomas> (raw)
In-Reply-To: <20200519081936.6d188c99@hermes.lan>
19/05/2020 17:19, Stephen Hemminger:
> On Thu, 14 May 2020 15:00:00 +0530
> Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
> >
> > +int
> > +rte_stats_bitrate_free(struct rte_stats_bitrates *bitrate_data)
> > +{
> > + if (bitrate_data)
> > + rte_free(bitrate_data);
> > + return 0;
> > +}
>
> rte_free of NULL is allowed, the test is not needed.
>
> Should be void not int function.
Ping, why no answer? Can we expect a v3?
next prev parent reply other threads:[~2020-07-10 22:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 11:38 [dpdk-dev] [PATCH 1/2] bitratestats: add support for free Hemant Agrawal
2020-05-13 11:38 ` [dpdk-dev] [PATCH 2/2] test: add support for testing bitrate stats free Hemant Agrawal
2020-05-13 11:47 ` [dpdk-dev] [PATCH 1/2] bitratestats: add support for free Jerin Jacob
2020-05-14 9:30 ` [dpdk-dev] [PATCHv2 " Hemant Agrawal
2020-05-14 9:30 ` [dpdk-dev] [PATCHv2 2/2] test: add support for testing bitrate stats free Hemant Agrawal
2020-05-19 15:19 ` [dpdk-dev] [PATCHv2 1/2] bitratestats: add support for free Stephen Hemminger
2020-07-10 22:30 ` Thomas Monjalon [this message]
2020-07-11 3:11 ` Hemant Agrawal
2020-07-11 8:28 ` [dpdk-dev] [PATCH v3 " Hemant Agrawal
2020-07-11 8:28 ` [dpdk-dev] [PATCH v3 2/2] test: add support for testing bitrate stats free Hemant Agrawal
2020-10-19 14:09 ` [dpdk-dev] [PATCH v3 1/2] bitratestats: add support for free Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1814150.q2JAx3WZxH@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.