All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] i2c issues with efikamx and mainline uboot
Date: Tue, 19 Nov 2013 18:02:19 +0100 (CET)	[thread overview]
Message-ID: <1815682388.492097.1384880539668.JavaMail.zimbra@advansee.com> (raw)
In-Reply-To: <201311191637.00452.marex@denx.de>

Dear Marek Vasut,

On Tuesday, November 19, 2013 4:37:00 PM, Marek Vasut wrote:
> Dear Konstantinos Margaritis,
> 
> > (Disclaimer: u-boot newbie)
> > 
> > Hi all,
> > 
> > With Marek's huge help (thanks Marek!) I've tried to merge his tree [1]
> > that provides lcd support for the efikamx/efikasb with recent mainline
> > uboot. It boots, but I've hit some wall now and couldn't get passed it,
> > so I thought I'd ask for some expert advice, Marek suggested I mail
> > here and CC himself and Stefano as well.
> > 
> > So, I've migrated the structures to the iomux v3 coding conventions,
> > added some missing defines for iomuxes used, etc. I've forked the code
> > in github [2] and am doing all the changes there, in the hope that I can
> > at some point submit it back to mainline. I also want to to enable
> > multi-host USB support for the platform so that tftp booting will be at
> > last possible, but that's going to happen later, I want to be done with
> > LCD first.
> > 
> > The result boots, but in short it fails to initialise the LCD (for the
> > efikamx, didn't test efikasb yet). I noticed that amongst many changes,
> > in drivers/i2c/mxc_i2c.c, i2c_imx_bus_busy() in Marek's tree () got
> > sort of replaced with wait_for_sr_state(), which does the same
> > thing but is more generic -or so I understand, please correct me if I'm
> > wrong in my interpretation.
> > 
> > So what's the problem? Well, I2CR_MSTA (master mode) is set, but
> > I2SR_IBB fails to get set. In every case I get this result in the
> > I2SR register:
> > 
> > I2SR = 81 -> I2SR_ICF | I2SR_RX_NO_AK, ie.
> > 
> > which according to the iMX515 Reference Manual corresponds to:
> > 
> > "Transfer is complete, and set by the falling edge of the ninth clock
> > of a byte transfer." + "A ?No acknowledge? signal was detected
> > at the ninth clock."
> > 
> > so a previous answer didn't send an acknowledge or rather the
> > opposite it sent a NACK.
> > 
> > I'm at a loss here, attaching a boot log where I added some printfs
> > around. I'd appreciate any pointer as to what I'm doing wrong.
> 
> Honestly, I have a feeling the MX51 I2C controller might be broken. Isn't
> there
> maybe something in the ERRATA for MX51 (I know it's HUGE) ?

I use the i.MX515, and the I?C worked fine at some point in mainline U-Boot. If
it does not work for you now, it's either because of a software regression, or
because of some board-specific issue, e.g. pads. SION may have to be set for
I?C.

Best regards,
Beno?t

  reply	other threads:[~2013-11-19 17:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-19 13:17 [U-Boot] i2c issues with efikamx and mainline uboot Konstantinos Margaritis
2013-11-19 15:37 ` Marek Vasut
2013-11-19 17:02   ` Benoît Thébaudeau [this message]
2013-11-20 23:15     ` Konstantinos Margaritis
2013-11-21  0:09       ` Benoît Thébaudeau
2013-11-19 17:02 ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1815682388.492097.1384880539668.JavaMail.zimbra@advansee.com \
    --to=benoit.thebaudeau@advansee.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.