From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v5 3/7] drm/rockchip: vop: move line_flag_num to interrupt registers Date: Tue, 25 Jul 2017 23:54:19 +0200 Message-ID: <1816316.NCRF09CkBJ@phil> References: <1500518564-30371-1-git-send-email-mark.yao@rock-chips.com> <1500518613-30590-1-git-send-email-mark.yao@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1500518613-30590-1-git-send-email-mark.yao@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark Yao Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org SGkgTWFyaywKCkFtIERvbm5lcnN0YWcsIDIwLiBKdWxpIDIwMTcsIDEwOjQzOjMyIENFU1Qgc2No cmllYiBNYXJrIFlhbzoKPiBJbiB0aGUgaGFyZHdhcmUgZGVzaWduIHByb2Nlc3MsIHRoZSBkZXNp Z24gb2YgbGluZSBmbGFncwo+IHJlZ2lzdGVyIGlzIGFzc29jaWF0ZWQgd2l0aCB0aGUgaW50ZXJy dXB0IHJlZ2lzdGVyLAo+IHBsYWNpbmcgdGhlIGxpbmUgZmxhZ3MgaW4gdGhlIGludGVycnVwdCBk ZWZpbml0aW9uIGlzCj4gbW9yZSByZWFzb25hYmxlLCBhbmQgaXQgd291bGQgbWFrZSBtdWx0aS12 b3AgZGVmaW5lIGVhc2lsaWVyLgo+IAo+IENoYW5nZXMgaW4gdjM6Cj4gLSBFeHBsYWluIG1vcmUg aW4gZGV0YWlscywgaW50cm9kdWNlIHdoeSB3ZSBuZWVkIHRoaXMgcGF0Y2gKPiAKPiBTaWduZWQt b2ZmLWJ5OiBNYXJrIFlhbyA8bWFyay55YW9Acm9jay1jaGlwcy5jb20+Cj4gUmV2aWV3ZWQtYnk6 IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5jIHwgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0v cm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5oIHwgNCArKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9y b2NrY2hpcC9yb2NrY2hpcF92b3BfcmVnLmMgfCA4ICsrKystLS0tCj4gIDMgZmlsZXMgY2hhbmdl ZCwgNyBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5jIGIvZHJpdmVycy9ncHUvZHJt L3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuYwo+IGluZGV4IDc4NGEyYjcuLjRmNmM3YmMgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmMKPiBAQCAt OTgyLDcgKzk4Miw3IEBAIHN0YXRpYyB2b2lkIHZvcF9jcnRjX2VuYWJsZShzdHJ1Y3QgZHJtX2Ny dGMgKmNydGMpCj4gIAlWT1BfQ1RSTF9TRVQodm9wLCB2YWN0X3N0X2VuZCwgdmFsKTsKPiAgCVZP UF9DVFJMX1NFVCh2b3AsIHZwb3N0X3N0X2VuZCwgdmFsKTsKPiAgCj4gLQlWT1BfQ1RSTF9TRVQo dm9wLCBsaW5lX2ZsYWdfbnVtWzBdLCB2YWN0X2VuZCk7Cj4gKwlWT1BfSU5UUl9TRVQodm9wLCBs aW5lX2ZsYWdfbnVtWzBdLCB2YWN0X2VuZCk7CgpXaXRoIHBhdGNoZXMgYXBwbGllZCB1cCB0byB0 aGlzIG9uZSBJIGVuZCB1cCB3aXRoCgogIENDIFtNXSAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlw L3JvY2tjaGlwX2RybV92b3AubwouLi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBf ZHJtX3ZvcC5jOiBJbiBmdW5jdGlvbiDigJh2b3BfY3J0Y19lbmFibGXigJk6Ci4uL2RyaXZlcnMv Z3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmM6OTg1OjQ2OiBlcnJvcjogbWFjcm8g IlZPUF9JTlRSX1NFVCIgcmVxdWlyZXMgNCBhcmd1bWVudHMsIGJ1dCBvbmx5IDMgZ2l2ZW4KICBW T1BfSU5UUl9TRVQodm9wLCBsaW5lX2ZsYWdfbnVtWzBdLCB2YWN0X2VuZCk7CiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeCi4uL2RyaXZlcnMvZ3B1L2RybS9y b2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmM6OTg1OjI6IGVycm9yOiDigJhWT1BfSU5UUl9TRVTi gJkgdW5kZWNsYXJlZCAoZmlyc3QgdXNlIGluIHRoaXMgZnVuY3Rpb24pCiAgVk9QX0lOVFJfU0VU KHZvcCwgbGluZV9mbGFnX251bVswXSwgdmFjdF9lbmQpOwogIF5+fn5+fn5+fn5+fgouLi9kcml2 ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5jOjk4NToyOiBub3RlOiBlYWNo IHVuZGVjbGFyZWQgaWRlbnRpZmllciBpcyByZXBvcnRlZCBvbmx5IG9uY2UgZm9yIGVhY2ggZnVu Y3Rpb24gaXQgYXBwZWFycyBpbgoKSW4gcGF0Y2g0IHlvdSByZXBsYWNlIHRoaXMgYWdhaW4sIHdp dGggCi0JVk9QX0lOVFJfU0VUKHZvcCwgbGluZV9mbGFnX251bVswXSwgdmFjdF9lbmQpOworCVZP UF9SRUdfU0VUKHZvcCwgaW50ciwgbGluZV9mbGFnX251bVswXSwgdmFjdF9lbmQpOwoKYnV0IHRo aXMgaW50ZXJtZWRpYXRlIGJyZWFrYWdlIHNob3VsZCBub3QgaGFwcGVuLCB0byBrZWVwIGJpc2Vj dGFiaWxpdHkuCgoKSGVpa28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Tue, 25 Jul 2017 23:54:19 +0200 Subject: [PATCH v5 3/7] drm/rockchip: vop: move line_flag_num to interrupt registers In-Reply-To: <1500518613-30590-1-git-send-email-mark.yao@rock-chips.com> References: <1500518564-30371-1-git-send-email-mark.yao@rock-chips.com> <1500518613-30590-1-git-send-email-mark.yao@rock-chips.com> Message-ID: <1816316.NCRF09CkBJ@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mark, Am Donnerstag, 20. Juli 2017, 10:43:32 CEST schrieb Mark Yao: > In the hardware design process, the design of line flags > register is associated with the interrupt register, > placing the line flags in the interrupt definition is > more reasonable, and it would make multi-vop define easilier. > > Changes in v3: > - Explain more in details, introduce why we need this patch > > Signed-off-by: Mark Yao > Reviewed-by: Sean Paul > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- > drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 4 ++-- > drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 8 ++++---- > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 784a2b7..4f6c7bc 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -982,7 +982,7 @@ static void vop_crtc_enable(struct drm_crtc *crtc) > VOP_CTRL_SET(vop, vact_st_end, val); > VOP_CTRL_SET(vop, vpost_st_end, val); > > - VOP_CTRL_SET(vop, line_flag_num[0], vact_end); > + VOP_INTR_SET(vop, line_flag_num[0], vact_end); With patches applied up to this one I end up with CC [M] drivers/gpu/drm/rockchip/rockchip_drm_vop.o ../drivers/gpu/drm/rockchip/rockchip_drm_vop.c: In function ?vop_crtc_enable?: ../drivers/gpu/drm/rockchip/rockchip_drm_vop.c:985:46: error: macro "VOP_INTR_SET" requires 4 arguments, but only 3 given VOP_INTR_SET(vop, line_flag_num[0], vact_end); ^ ../drivers/gpu/drm/rockchip/rockchip_drm_vop.c:985:2: error: ?VOP_INTR_SET? undeclared (first use in this function) VOP_INTR_SET(vop, line_flag_num[0], vact_end); ^~~~~~~~~~~~ ../drivers/gpu/drm/rockchip/rockchip_drm_vop.c:985:2: note: each undeclared identifier is reported only once for each function it appears in In patch4 you replace this again, with - VOP_INTR_SET(vop, line_flag_num[0], vact_end); + VOP_REG_SET(vop, intr, line_flag_num[0], vact_end); but this intermediate breakage should not happen, to keep bisectability. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751544AbdGYVy1 convert rfc822-to-8bit (ORCPT ); Tue, 25 Jul 2017 17:54:27 -0400 Received: from gloria.sntech.de ([95.129.55.99]:48678 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750908AbdGYVy0 (ORCPT ); Tue, 25 Jul 2017 17:54:26 -0400 From: Heiko Stuebner To: Mark Yao Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/7] drm/rockchip: vop: move line_flag_num to interrupt registers Date: Tue, 25 Jul 2017 23:54:19 +0200 Message-ID: <1816316.NCRF09CkBJ@phil> User-Agent: KMail/5.2.3 (Linux/4.9.0-2-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: <1500518613-30590-1-git-send-email-mark.yao@rock-chips.com> References: <1500518564-30371-1-git-send-email-mark.yao@rock-chips.com> <1500518613-30590-1-git-send-email-mark.yao@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, Am Donnerstag, 20. Juli 2017, 10:43:32 CEST schrieb Mark Yao: > In the hardware design process, the design of line flags > register is associated with the interrupt register, > placing the line flags in the interrupt definition is > more reasonable, and it would make multi-vop define easilier. > > Changes in v3: > - Explain more in details, introduce why we need this patch > > Signed-off-by: Mark Yao > Reviewed-by: Sean Paul > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- > drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 4 ++-- > drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 8 ++++---- > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 784a2b7..4f6c7bc 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -982,7 +982,7 @@ static void vop_crtc_enable(struct drm_crtc *crtc) > VOP_CTRL_SET(vop, vact_st_end, val); > VOP_CTRL_SET(vop, vpost_st_end, val); > > - VOP_CTRL_SET(vop, line_flag_num[0], vact_end); > + VOP_INTR_SET(vop, line_flag_num[0], vact_end); With patches applied up to this one I end up with CC [M] drivers/gpu/drm/rockchip/rockchip_drm_vop.o ../drivers/gpu/drm/rockchip/rockchip_drm_vop.c: In function ‘vop_crtc_enable’: ../drivers/gpu/drm/rockchip/rockchip_drm_vop.c:985:46: error: macro "VOP_INTR_SET" requires 4 arguments, but only 3 given VOP_INTR_SET(vop, line_flag_num[0], vact_end); ^ ../drivers/gpu/drm/rockchip/rockchip_drm_vop.c:985:2: error: ‘VOP_INTR_SET’ undeclared (first use in this function) VOP_INTR_SET(vop, line_flag_num[0], vact_end); ^~~~~~~~~~~~ ../drivers/gpu/drm/rockchip/rockchip_drm_vop.c:985:2: note: each undeclared identifier is reported only once for each function it appears in In patch4 you replace this again, with - VOP_INTR_SET(vop, line_flag_num[0], vact_end); + VOP_REG_SET(vop, intr, line_flag_num[0], vact_end); but this intermediate breakage should not happen, to keep bisectability. Heiko