From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Date: Wed, 20 Jan 2016 23:14:25 +0000 Subject: Re: [patch] drm: rockchip: signedness bug in dw_mipi_dsi_get_lane_bps() Message-Id: <181674264.ynnWZU1Yz8@phil> List-Id: References: <20160120095352.GA19898@mwanda> In-Reply-To: <20160120095352.GA19898@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Chris Zhong , linux-arm-kernel@lists.infradead.org Hi Dan, Am Mittwoch, 20. Januar 2016, 12:53:52 schrieb Dan Carpenter: > "bpp" needs to be signed for the error handling to work. > > Fixes: 84e05408fcfe ('drm: rockchip: Support Synopsys DW MIPI DSI') > Signed-off-by: Dan Carpenter There's also "drm/rockchip/dsi: fix handling mipi_dsi_pixel_format_to_bpp result" from Andrzej Hajda from january the 14th doing the same change. Heiko > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c index 7bfe243..c35e5af 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -461,7 +461,8 @@ static int dw_mipi_dsi_phy_init(struct dw_mipi_dsi > *dsi) > > static int dw_mipi_dsi_get_lane_bps(struct dw_mipi_dsi *dsi) > { > - unsigned int bpp, i, pre; > + int bpp; > + unsigned int i, pre; > unsigned long mpclk, pllref, tmp; > unsigned int m = 1, n = 1, target_mbps = 1000; > unsigned int max_mbps = dptdin_map[ARRAY_SIZE(dptdin_map) - 1].max_mbps; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [patch] drm: rockchip: signedness bug in dw_mipi_dsi_get_lane_bps() Date: Thu, 21 Jan 2016 00:14:25 +0100 Message-ID: <181674264.ynnWZU1Yz8@phil> References: <20160120095352.GA19898@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160120095352.GA19898@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Chris Zhong , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGkgRGFuLAoKQW0gTWl0dHdvY2gsIDIwLiBKYW51YXIgMjAxNiwgMTI6NTM6NTIgc2NocmllYiBE YW4gQ2FycGVudGVyOgo+ICJicHAiIG5lZWRzIHRvIGJlIHNpZ25lZCBmb3IgdGhlIGVycm9yIGhh bmRsaW5nIHRvIHdvcmsuCj4gCj4gRml4ZXM6IDg0ZTA1NDA4ZmNmZSAoJ2RybTogcm9ja2NoaXA6 IFN1cHBvcnQgU3lub3BzeXMgRFcgTUlQSSBEU0knKQo+IFNpZ25lZC1vZmYtYnk6IERhbiBDYXJw ZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4KClRoZXJlJ3MgYWxzbyAiZHJtL3JvY2tj aGlwL2RzaTogZml4IGhhbmRsaW5nIG1pcGlfZHNpX3BpeGVsX2Zvcm1hdF90b19icHAgCnJlc3Vs dCIgZnJvbSBBbmRyemVqIEhhamRhIGZyb20gamFudWFyeSB0aGUgMTR0aCBkb2luZyB0aGUgc2Ft ZSBjaGFuZ2UuCgoKSGVpa28KCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yb2Nr Y2hpcC9kdy1taXBpLWRzaS5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvZHctbWlwaS1k c2kuYyBpbmRleCA3YmZlMjQzLi5jMzVlNWFmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9yb2NrY2hpcC9kdy1taXBpLWRzaS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlw L2R3LW1pcGktZHNpLmMKPiBAQCAtNDYxLDcgKzQ2MSw4IEBAIHN0YXRpYyBpbnQgZHdfbWlwaV9k c2lfcGh5X2luaXQoc3RydWN0IGR3X21pcGlfZHNpCj4gKmRzaSkKPiAKPiAgc3RhdGljIGludCBk d19taXBpX2RzaV9nZXRfbGFuZV9icHMoc3RydWN0IGR3X21pcGlfZHNpICpkc2kpCj4gIHsKPiAt CXVuc2lnbmVkIGludCBicHAsIGksIHByZTsKPiArCWludCBicHA7Cj4gKwl1bnNpZ25lZCBpbnQg aSwgcHJlOwo+ICAJdW5zaWduZWQgbG9uZyBtcGNsaywgcGxscmVmLCB0bXA7Cj4gIAl1bnNpZ25l ZCBpbnQgbSA9IDEsIG4gPSAxLCB0YXJnZXRfbWJwcyA9IDEwMDA7Cj4gIAl1bnNpZ25lZCBpbnQg bWF4X21icHMgPSBkcHRkaW5fbWFwW0FSUkFZX1NJWkUoZHB0ZGluX21hcCkgLSAKMV0ubWF4X21i cHM7CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Thu, 21 Jan 2016 00:14:25 +0100 Subject: [patch] drm: rockchip: signedness bug in dw_mipi_dsi_get_lane_bps() In-Reply-To: <20160120095352.GA19898@mwanda> References: <20160120095352.GA19898@mwanda> Message-ID: <181674264.ynnWZU1Yz8@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Dan, Am Mittwoch, 20. Januar 2016, 12:53:52 schrieb Dan Carpenter: > "bpp" needs to be signed for the error handling to work. > > Fixes: 84e05408fcfe ('drm: rockchip: Support Synopsys DW MIPI DSI') > Signed-off-by: Dan Carpenter There's also "drm/rockchip/dsi: fix handling mipi_dsi_pixel_format_to_bpp result" from Andrzej Hajda from january the 14th doing the same change. Heiko > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c index 7bfe243..c35e5af 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -461,7 +461,8 @@ static int dw_mipi_dsi_phy_init(struct dw_mipi_dsi > *dsi) > > static int dw_mipi_dsi_get_lane_bps(struct dw_mipi_dsi *dsi) > { > - unsigned int bpp, i, pre; > + int bpp; > + unsigned int i, pre; > unsigned long mpclk, pllref, tmp; > unsigned int m = 1, n = 1, target_mbps = 1000; > unsigned int max_mbps = dptdin_map[ARRAY_SIZE(dptdin_map) - 1].max_mbps; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758672AbcATXOq (ORCPT ); Wed, 20 Jan 2016 18:14:46 -0500 Received: from gloria.sntech.de ([95.129.55.99]:51343 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750786AbcATXOm (ORCPT ); Wed, 20 Jan 2016 18:14:42 -0500 From: Heiko Stuebner To: Dan Carpenter Cc: Mark Yao , Chris Zhong , David Airlie , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] drm: rockchip: signedness bug in dw_mipi_dsi_get_lane_bps() Date: Thu, 21 Jan 2016 00:14:25 +0100 Message-ID: <181674264.ynnWZU1Yz8@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <20160120095352.GA19898@mwanda> References: <20160120095352.GA19898@mwanda> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan, Am Mittwoch, 20. Januar 2016, 12:53:52 schrieb Dan Carpenter: > "bpp" needs to be signed for the error handling to work. > > Fixes: 84e05408fcfe ('drm: rockchip: Support Synopsys DW MIPI DSI') > Signed-off-by: Dan Carpenter There's also "drm/rockchip/dsi: fix handling mipi_dsi_pixel_format_to_bpp result" from Andrzej Hajda from january the 14th doing the same change. Heiko > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c index 7bfe243..c35e5af 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -461,7 +461,8 @@ static int dw_mipi_dsi_phy_init(struct dw_mipi_dsi > *dsi) > > static int dw_mipi_dsi_get_lane_bps(struct dw_mipi_dsi *dsi) > { > - unsigned int bpp, i, pre; > + int bpp; > + unsigned int i, pre; > unsigned long mpclk, pllref, tmp; > unsigned int m = 1, n = 1, target_mbps = 1000; > unsigned int max_mbps = dptdin_map[ARRAY_SIZE(dptdin_map) - 1].max_mbps;