From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v3 0/8] drm/rockchip: covert to support atomic API Date: Thu, 17 Dec 2015 13:03:53 +0100 Message-ID: <1817698.JgNG3flpWP@diego> References: <1450321275-31154-1-git-send-email-mark.yao@rock-chips.com> <4029109.1DucZWNrFm@diego> <56728F3F.6060309@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <56728F3F.6060309@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark yao Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org SGkgTWFyaywKCkFtIERvbm5lcnN0YWcsIDE3LiBEZXplbWJlciAyMDE1LCAxODozMjozMSBzY2hy aWViIE1hcmsgeWFvOgo+IE9uIDIwMTXlubQxMuaciDE35pelIDE4OjAwLCBIZWlrbyBTdMO8Ym5l ciB3cm90ZToKPiA+IEFtIERvbm5lcnN0YWcsIDE3LiBEZXplbWJlciAyMDE1LCAxMTowMTowNyBz Y2hyaWViIE1hcmsgWWFvOgo+ID4+IFRoZSBzZXJpZXMgb2YgcGF0Y2hlcyBjb3ZlcnRpbmcgZHJt IHJvY2tjaGlwIHRvIGF0b21pYyBBUEksIGRvIHNvbWUKPiA+PiBjbGVhbnVwIGFuZCBzb21lIGZp eGVzIG9uIGF0b21pYyBzaWRlLgoKWy4uLl0KCj4gPiBQbHVnZ2luZyBpbiBIRE1JIGFmdGVyIGJv b3Q6Cj4gPiAKPiA+IFsgICAyMC41NTk1MzRdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0t LS0tLS0tLQo+ID4gWyAgIDIwLjU2NDQxMl0gV0FSTklORzogQ1BVOiAzIFBJRDogNzQgYXQKPiA+ IGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jOjY4Mgo+ID4gZHJtX2F0b21pY19o ZWxwZXJfdXBkYXRlX2xlZ2FjeV9tb2Rlc2V0X3N0YXRlKzB4NmMvMHgyMDAoKSBbICAgMjAuNTc2 OTkxXQo+ID4gTW9kdWxlcyBsaW5rZWQgaW46Cj4gPiBbICAgMjAuNTgwMTc1XSBDUFU6IDMgUElE OiA3NCBDb21tOiBpcnEvNTEtZmY5ODAwMDAgTm90IHRhaW50ZWQgNC40LjAtcmM1Kwo+ID4gIzI3 ODcgWyAgIDIwLjU4NzUwMl0gSGFyZHdhcmUgbmFtZTogUm9ja2NoaXAgKERldmljZSBUcmVlKQo+ ID4gWyAgIDIwLjU5MjM0N10gWzxjMDAxOTkxND5dICh1bndpbmRfYmFja3RyYWNlKSBmcm9tIFs8 YzAwMTRiY2M+XQo+ID4gKHNob3dfc3RhY2srMHgyMC8weDI0KSBbICAgMjAuNjAwMzE5XSBbPGMw MDE0YmNjPl0gKHNob3dfc3RhY2spIGZyb20KPiA+IFs8YzAyYzQzNDQ+XSAoZHVtcF9zdGFjaysw eDg0LzB4YjgpIFsgICAyMC42MDc3NzZdIFs8YzAyYzQzNDQ+XQo+ID4gKGR1bXBfc3RhY2spIGZy b20gWzxjMDAyOWEyMD5dICh3YXJuX3Nsb3dwYXRoX2NvbW1vbisweDk4LzB4YzQpIFsgIAo+ID4g MjAuNjE2MDg3XSBbPGMwMDI5YTIwPl0gKHdhcm5fc2xvd3BhdGhfY29tbW9uKSBmcm9tIFs8YzAw MjliMDg+XQo+ID4gKHdhcm5fc2xvd3BhdGhfbnVsbCsweDJjLzB4MzQpIFsgICAyMC42MjUxMDZd IFs8YzAwMjliMDg+XQo+ID4gKHdhcm5fc2xvd3BhdGhfbnVsbCkgZnJvbSBbPGMwMzYxMTQ0Pl0K PiA+IChkcm1fYXRvbWljX2hlbHBlcl91cGRhdGVfbGVnYWN5X21vZGVzZXRfc3RhdGUrMHg2Yy8w eDIwMCkgWyAgIDIwLjYzNjM4Ml0KPiA+IFs8YzAzNjExNDQ+XSAoZHJtX2F0b21pY19oZWxwZXJf dXBkYXRlX2xlZ2FjeV9tb2Rlc2V0X3N0YXRlKSBmcm9tCj4gPiBbPGMwMzYxNjg0Pl0gKGRybV9h dG9taWNfaGVscGVyX2NvbW1pdF9tb2Rlc2V0X2Rpc2FibGVzKzB4MWU0LzB4MzVjKSBbICAKPiA+ IDIwLjY0OTczMl0gWzxjMDM2MTY4ND5dIChkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfbW9kZXNl dF9kaXNhYmxlcykgZnJvbQo+ID4gWzxjMDM4NzgyYz5dIChyb2NrY2hpcF9hdG9taWNfY29tbWl0 X2NvbXBsZXRlKzB4MzQvMHgxMDgpIFsgICAyMC42NjE3ODldCj4gPiBbPGMwMzg3ODJjPl0gKHJv Y2tjaGlwX2F0b21pY19jb21taXRfY29tcGxldGUpIGZyb20gWzxjMDM4Nzk4ND5dCj4gPiAocm9j a2NoaXBfZHJtX2F0b21pY19jb21taXQrMHg4NC8weGEwKSBbICAgMjAuNjcyNDQyXSBbPGMwMzg3 OTg0Pl0KPiA+IChyb2NrY2hpcF9kcm1fYXRvbWljX2NvbW1pdCkgZnJvbSBbPGMwMzg0YzU4Pl0K PiA+IChkcm1fYXRvbWljX2NvbW1pdCsweDYwLzB4NzApIFsgICAyMC42ODE3MTFdIFs8YzAzODRj NTg+XQo+ID4gKGRybV9hdG9taWNfY29tbWl0KSBmcm9tIFs8YzAzNjNhYjA+XSAocmVzdG9yZV9m YmRldl9tb2RlKzB4MTI4LzB4MjU4KSBbIAo+ID4gIDIwLjY5MDQxOF0gWzxjMDM2M2FiMD5dIChy ZXN0b3JlX2ZiZGV2X21vZGUpIGZyb20gWzxjMDM2NTIwOD5dCj4gPiAoZHJtX2ZiX2hlbHBlcl9y ZXN0b3JlX2ZiZGV2X21vZGVfdW5sb2NrZWQrMHgzYy8weDgwKSBbICAgMjAuNzAxMDMzXQo+ID4g WzxjMDM2NTIwOD5dIChkcm1fZmJfaGVscGVyX3Jlc3RvcmVfZmJkZXZfbW9kZV91bmxvY2tlZCkg ZnJvbQo+ID4gWzxjMDM2NTI5Yz5dIChkcm1fZmJfaGVscGVyX3NldF9wYXIrMHg1MC8weDYwKSBb ICAgMjAuNzExOTA3XQo+ID4gWzxjMDM2NTI5Yz5dIChkcm1fZmJfaGVscGVyX3NldF9wYXIpIGZy b20gWzxjMDM2NTFiND5dCj4gPiAoZHJtX2ZiX2hlbHBlcl9ob3RwbHVnX2V2ZW50KzB4YzgvMHhl MCkgWyAgIDIwLjcyMTU2OV0gWzxjMDM2NTFiND5dCj4gPiAoZHJtX2ZiX2hlbHBlcl9ob3RwbHVn X2V2ZW50KSBmcm9tIFs8YzAzODdiZDA+XQo+ID4gKHJvY2tjaGlwX2RybV9vdXRwdXRfcG9sbF9j aGFuZ2VkKzB4MjQvMHgyOCkgWyAgIDIwLjczMjE4NV0gWzxjMDM4N2JkMD5dCj4gPiAocm9ja2No aXBfZHJtX291dHB1dF9wb2xsX2NoYW5nZWQpIGZyb20gWzxjMDM1YWFmOD5dCj4gPiAoZHJtX2tt c19oZWxwZXJfaG90cGx1Z19ldmVudCsweDM0LzB4MzgpIFsgICAyMC43NDI4OTFdIFs8YzAzNWFh Zjg+XQo+ID4gKGRybV9rbXNfaGVscGVyX2hvdHBsdWdfZXZlbnQpIGZyb20gWzxjMDM1YjQzND5d Cj4gPiAoZHJtX2hlbHBlcl9ocGRfaXJxX2V2ZW50KzB4MTIwLzB4MTUwKSBbICAgMjAuNzUzMDc4 XSBbPGMwMzViNDM0Pl0KPiA+IChkcm1faGVscGVyX2hwZF9pcnFfZXZlbnQpIGZyb20gWzxjMDM4 ZGQxYz5dIChkd19oZG1pX2lycSsweDE0Yy8weDE4YykgWyAKPiA+ICAyMC43NjE3NzJdIFs8YzAz OGRkMWM+XSAoZHdfaGRtaV9pcnEpIGZyb20gWzxjMDA4ZDAzMD5dCj4gPiAoaXJxX3RocmVhZF9m bisweDJjLzB4NDQpIFsgICAyMC43NjkzNTBdIFs8YzAwOGQwMzA+XSAoaXJxX3RocmVhZF9mbikK PiA+IGZyb20gWzxjMDA4ZDMzYz5dIChpcnFfdGhyZWFkKzB4MTE4LzB4MjFjKSBbICAgMjAuNzc3 MDE5XSBbPGMwMDhkMzNjPl0KPiA+IChpcnFfdGhyZWFkKSBmcm9tIFs8YzAwNGJiYjg+XSAoa3Ro cmVhZCsweGY0LzB4MTBjKSBbICAgMjAuNzg0MDgzXQo+ID4gWzxjMDA0YmJiOD5dIChrdGhyZWFk KSBmcm9tIFs8YzAwMTAwMTA+XSAocmV0X2Zyb21fZm9yaysweDE0LzB4MjQpIFsgIAo+ID4gMjAu NzkxMzAwXSAtLS1bIGVuZCB0cmFjZSAzZGVhYTUxZDI4ODA2N2EwIF0tLS0KPiAKPiBIaSBIZWlr bwo+ICAgICAgVGhpcyBpc3N1ZSBjYW4gYmUgZXhwbGFpbmVkIGZyb20gZm9sbG93aW5nIHRocmVh ZDoKPiAgICAgICAgIGh0dHBzOi8vbGttbC5vcmcvbGttbC8yMDE1LzExLzE2LzQ5OAo+IAo+ICAg ICAgWW91IGNhbiBmaXggaXQgYnkgZm9sbG93aW5nIGNoYW5nZXM6Cj4gCj4gQEAgLTE2NjcsOCAr MTY2Nyw2IEBAIHN0YXRpYyBpbnQgZHdfaGRtaV9yZWdpc3RlcihzdHJ1Y3QgZHJtX2RldmljZQo+ ICpkcm0sIHN0cnVjdCBkd19oZG1pICpoZG1pKQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICZkd19oZG1pX2Nvbm5lY3Rvcl9mdW5jcywKPiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBEUk1fTU9ERV9DT05ORUNUT1JfSERNSUEpOwo+IAo+ICAgICAgLSAg ICAgICBoZG1pLT5jb25uZWN0b3IuZW5jb2RlciA9IGVuY29kZXI7Cgp5ZXAgdGhhdCBmaXhlcyB0 aGUgd2FybmluZy4gRnJvbSB0aGUgdGhyZWFkIHlvdSBtZW50aW9uLCBpdCBsb29rcyBsaWtlIHRo YXQgCmFzc2lnbm1lbnQgc2hvdWxkIGFsc28gYmUgcmVtb3ZlZCBpbiB0aGUgbm9uLWF0b21pYyBj YXNlIChpLk1YKT8KCk9yIGlmIGl0IGlzIHJlYWxseSBuZWNlc3NhcnkgdGhlcmUgY291bGQgYWxz byB3cmFwIGl0IGluIGEgY29uZGl0aW9uYWwgdG8gb25seSAKYmUgc2V0IGZvciB0aGUgbm9uLWF0 b21pYyBjYXNlLgoKCkhlaWtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?ISO-8859-1?Q?St=FCbner?=) Date: Thu, 17 Dec 2015 13:03:53 +0100 Subject: [PATCH v3 0/8] drm/rockchip: covert to support atomic API In-Reply-To: <56728F3F.6060309@rock-chips.com> References: <1450321275-31154-1-git-send-email-mark.yao@rock-chips.com> <4029109.1DucZWNrFm@diego> <56728F3F.6060309@rock-chips.com> Message-ID: <1817698.JgNG3flpWP@diego> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mark, Am Donnerstag, 17. Dezember 2015, 18:32:31 schrieb Mark yao: > On 2015?12?17? 18:00, Heiko St?bner wrote: > > Am Donnerstag, 17. Dezember 2015, 11:01:07 schrieb Mark Yao: > >> The series of patches coverting drm rockchip to atomic API, do some > >> cleanup and some fixes on atomic side. [...] > > Plugging in HDMI after boot: > > > > [ 20.559534] ------------[ cut here ]------------ > > [ 20.564412] WARNING: CPU: 3 PID: 74 at > > drivers/gpu/drm/drm_atomic_helper.c:682 > > drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200() [ 20.576991] > > Modules linked in: > > [ 20.580175] CPU: 3 PID: 74 Comm: irq/51-ff980000 Not tainted 4.4.0-rc5+ > > #2787 [ 20.587502] Hardware name: Rockchip (Device Tree) > > [ 20.592347] [] (unwind_backtrace) from [] > > (show_stack+0x20/0x24) [ 20.600319] [] (show_stack) from > > [] (dump_stack+0x84/0xb8) [ 20.607776] [] > > (dump_stack) from [] (warn_slowpath_common+0x98/0xc4) [ > > 20.616087] [] (warn_slowpath_common) from [] > > (warn_slowpath_null+0x2c/0x34) [ 20.625106] [] > > (warn_slowpath_null) from [] > > (drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200) [ 20.636382] > > [] (drm_atomic_helper_update_legacy_modeset_state) from > > [] (drm_atomic_helper_commit_modeset_disables+0x1e4/0x35c) [ > > 20.649732] [] (drm_atomic_helper_commit_modeset_disables) from > > [] (rockchip_atomic_commit_complete+0x34/0x108) [ 20.661789] > > [] (rockchip_atomic_commit_complete) from [] > > (rockchip_drm_atomic_commit+0x84/0xa0) [ 20.672442] [] > > (rockchip_drm_atomic_commit) from [] > > (drm_atomic_commit+0x60/0x70) [ 20.681711] [] > > (drm_atomic_commit) from [] (restore_fbdev_mode+0x128/0x258) [ > > 20.690418] [] (restore_fbdev_mode) from [] > > (drm_fb_helper_restore_fbdev_mode_unlocked+0x3c/0x80) [ 20.701033] > > [] (drm_fb_helper_restore_fbdev_mode_unlocked) from > > [] (drm_fb_helper_set_par+0x50/0x60) [ 20.711907] > > [] (drm_fb_helper_set_par) from [] > > (drm_fb_helper_hotplug_event+0xc8/0xe0) [ 20.721569] [] > > (drm_fb_helper_hotplug_event) from [] > > (rockchip_drm_output_poll_changed+0x24/0x28) [ 20.732185] [] > > (rockchip_drm_output_poll_changed) from [] > > (drm_kms_helper_hotplug_event+0x34/0x38) [ 20.742891] [] > > (drm_kms_helper_hotplug_event) from [] > > (drm_helper_hpd_irq_event+0x120/0x150) [ 20.753078] [] > > (drm_helper_hpd_irq_event) from [] (dw_hdmi_irq+0x14c/0x18c) [ > > 20.761772] [] (dw_hdmi_irq) from [] > > (irq_thread_fn+0x2c/0x44) [ 20.769350] [] (irq_thread_fn) > > from [] (irq_thread+0x118/0x21c) [ 20.777019] [] > > (irq_thread) from [] (kthread+0xf4/0x10c) [ 20.784083] > > [] (kthread) from [] (ret_from_fork+0x14/0x24) [ > > 20.791300] ---[ end trace 3deaa51d288067a0 ]--- > > Hi Heiko > This issue can be explained from following thread: > https://lkml.org/lkml/2015/11/16/498 > > You can fix it by following changes: > > @@ -1667,8 +1667,6 @@ static int dw_hdmi_register(struct drm_device > *drm, struct dw_hdmi *hdmi) > &dw_hdmi_connector_funcs, > DRM_MODE_CONNECTOR_HDMIA); > > - hdmi->connector.encoder = encoder; yep that fixes the warning. From the thread you mention, it looks like that assignment should also be removed in the non-atomic case (i.MX)? Or if it is really necessary there could also wrap it in a conditional to only be set for the non-atomic case. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755777AbbLQMEF (ORCPT ); Thu, 17 Dec 2015 07:04:05 -0500 Received: from gloria.sntech.de ([95.129.55.99]:47996 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751794AbbLQMED convert rfc822-to-8bit (ORCPT ); Thu, 17 Dec 2015 07:04:03 -0500 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Mark yao Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/8] drm/rockchip: covert to support atomic API Date: Thu, 17 Dec 2015 13:03:53 +0100 Message-ID: <1817698.JgNG3flpWP@diego> User-Agent: KMail/4.14.10 (Linux/4.2.0-1-amd64; KDE/4.14.13; x86_64; ; ) In-Reply-To: <56728F3F.6060309@rock-chips.com> References: <1450321275-31154-1-git-send-email-mark.yao@rock-chips.com> <4029109.1DucZWNrFm@diego> <56728F3F.6060309@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, Am Donnerstag, 17. Dezember 2015, 18:32:31 schrieb Mark yao: > On 2015年12月17日 18:00, Heiko Stübner wrote: > > Am Donnerstag, 17. Dezember 2015, 11:01:07 schrieb Mark Yao: > >> The series of patches coverting drm rockchip to atomic API, do some > >> cleanup and some fixes on atomic side. [...] > > Plugging in HDMI after boot: > > > > [ 20.559534] ------------[ cut here ]------------ > > [ 20.564412] WARNING: CPU: 3 PID: 74 at > > drivers/gpu/drm/drm_atomic_helper.c:682 > > drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200() [ 20.576991] > > Modules linked in: > > [ 20.580175] CPU: 3 PID: 74 Comm: irq/51-ff980000 Not tainted 4.4.0-rc5+ > > #2787 [ 20.587502] Hardware name: Rockchip (Device Tree) > > [ 20.592347] [] (unwind_backtrace) from [] > > (show_stack+0x20/0x24) [ 20.600319] [] (show_stack) from > > [] (dump_stack+0x84/0xb8) [ 20.607776] [] > > (dump_stack) from [] (warn_slowpath_common+0x98/0xc4) [ > > 20.616087] [] (warn_slowpath_common) from [] > > (warn_slowpath_null+0x2c/0x34) [ 20.625106] [] > > (warn_slowpath_null) from [] > > (drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200) [ 20.636382] > > [] (drm_atomic_helper_update_legacy_modeset_state) from > > [] (drm_atomic_helper_commit_modeset_disables+0x1e4/0x35c) [ > > 20.649732] [] (drm_atomic_helper_commit_modeset_disables) from > > [] (rockchip_atomic_commit_complete+0x34/0x108) [ 20.661789] > > [] (rockchip_atomic_commit_complete) from [] > > (rockchip_drm_atomic_commit+0x84/0xa0) [ 20.672442] [] > > (rockchip_drm_atomic_commit) from [] > > (drm_atomic_commit+0x60/0x70) [ 20.681711] [] > > (drm_atomic_commit) from [] (restore_fbdev_mode+0x128/0x258) [ > > 20.690418] [] (restore_fbdev_mode) from [] > > (drm_fb_helper_restore_fbdev_mode_unlocked+0x3c/0x80) [ 20.701033] > > [] (drm_fb_helper_restore_fbdev_mode_unlocked) from > > [] (drm_fb_helper_set_par+0x50/0x60) [ 20.711907] > > [] (drm_fb_helper_set_par) from [] > > (drm_fb_helper_hotplug_event+0xc8/0xe0) [ 20.721569] [] > > (drm_fb_helper_hotplug_event) from [] > > (rockchip_drm_output_poll_changed+0x24/0x28) [ 20.732185] [] > > (rockchip_drm_output_poll_changed) from [] > > (drm_kms_helper_hotplug_event+0x34/0x38) [ 20.742891] [] > > (drm_kms_helper_hotplug_event) from [] > > (drm_helper_hpd_irq_event+0x120/0x150) [ 20.753078] [] > > (drm_helper_hpd_irq_event) from [] (dw_hdmi_irq+0x14c/0x18c) [ > > 20.761772] [] (dw_hdmi_irq) from [] > > (irq_thread_fn+0x2c/0x44) [ 20.769350] [] (irq_thread_fn) > > from [] (irq_thread+0x118/0x21c) [ 20.777019] [] > > (irq_thread) from [] (kthread+0xf4/0x10c) [ 20.784083] > > [] (kthread) from [] (ret_from_fork+0x14/0x24) [ > > 20.791300] ---[ end trace 3deaa51d288067a0 ]--- > > Hi Heiko > This issue can be explained from following thread: > https://lkml.org/lkml/2015/11/16/498 > > You can fix it by following changes: > > @@ -1667,8 +1667,6 @@ static int dw_hdmi_register(struct drm_device > *drm, struct dw_hdmi *hdmi) > &dw_hdmi_connector_funcs, > DRM_MODE_CONNECTOR_HDMIA); > > - hdmi->connector.encoder = encoder; yep that fixes the warning. From the thread you mention, it looks like that assignment should also be removed in the non-atomic case (i.MX)? Or if it is really necessary there could also wrap it in a conditional to only be set for the non-atomic case. Heiko