From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Wed, 25 Apr 2018 09:03:22 +0000 Subject: Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP Message-Id: <1818588.4EAHIaV2gL@avalon> List-Id: References: <20180423170955.13421017@vento.lan> <70b5e60f-346e-4b34-8235-ce62de720a99@ti.com> In-Reply-To: <70b5e60f-346e-4b34-8235-ce62de720a99@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tomi Valkeinen Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , Mauro Carvalho Chehab , Linux Media Mailing List Hi Tomi, On Wednesday, 25 April 2018 09:24:14 EEST Tomi Valkeinen wrote: > On 23/04/18 23:09, Mauro Carvalho Chehab wrote: > >> I don't think it's worth it renaming the common symbols. They will change > >> over time as omapdrm is under heavy rework, and it's painful enough > >> without having to handle cross-tree changes. > > > > It could just rename the namespace-conflicting FB_OMAP2 functions, > > keeping the DRM ones as-is. > > Yes, I'm fine with renaming omapfb functions if that helps. But still, > if omapdrm is enabled in the kernel as module or built-in, omapfb will > not work. So even if we get them to compile and link, it'll break at > runtime one way or another. > > >> Let's just live with the fact that both drivers > >> can't be compiled at the same time, given that omapfb is deprecated. > > > > IMO, a driver that it is deprecated, being in a state where it > > conflicts with a non-deprecated driver that is under heavy rework > > is a very good candidate to go to drivers/staging or even to /dev/null. > > The problem is that it supports old devices which are not supported by > omapdrm. But both omapfb and omapdrm support many of the same devices. Could we trim down omapfb to remove support for the devices supported by omapdrm ? -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP Date: Wed, 25 Apr 2018 12:03:22 +0300 Message-ID: <1818588.4EAHIaV2gL@avalon> References: <20180423170955.13421017@vento.lan> <70b5e60f-346e-4b34-8235-ce62de720a99@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 380E56E15C for ; Wed, 25 Apr 2018 09:03:08 +0000 (UTC) In-Reply-To: <70b5e60f-346e-4b34-8235-ce62de720a99@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , Mauro Carvalho Chehab , Linux Media Mailing List List-Id: dri-devel@lists.freedesktop.org SGkgVG9taSwKCk9uIFdlZG5lc2RheSwgMjUgQXByaWwgMjAxOCAwOToyNDoxNCBFRVNUIFRvbWkg VmFsa2VpbmVuIHdyb3RlOgo+IE9uIDIzLzA0LzE4IDIzOjA5LCBNYXVybyBDYXJ2YWxobyBDaGVo YWIgd3JvdGU6Cj4gPj4gSSBkb24ndCB0aGluayBpdCdzIHdvcnRoIGl0IHJlbmFtaW5nIHRoZSBj b21tb24gc3ltYm9scy4gVGhleSB3aWxsIGNoYW5nZQo+ID4+IG92ZXIgdGltZSBhcyBvbWFwZHJt IGlzIHVuZGVyIGhlYXZ5IHJld29yaywgYW5kIGl0J3MgcGFpbmZ1bCBlbm91Z2gKPiA+PiB3aXRo b3V0IGhhdmluZyB0byBoYW5kbGUgY3Jvc3MtdHJlZSBjaGFuZ2VzLgo+ID4gCj4gPiBJdCBjb3Vs ZCBqdXN0IHJlbmFtZSB0aGUgbmFtZXNwYWNlLWNvbmZsaWN0aW5nIEZCX09NQVAyIGZ1bmN0aW9u cywKPiA+IGtlZXBpbmcgdGhlIERSTSBvbmVzIGFzLWlzLgo+IAo+IFllcywgSSdtIGZpbmUgd2l0 aCByZW5hbWluZyBvbWFwZmIgZnVuY3Rpb25zIGlmIHRoYXQgaGVscHMuIEJ1dCBzdGlsbCwKPiBp ZiBvbWFwZHJtIGlzIGVuYWJsZWQgaW4gdGhlIGtlcm5lbCBhcyBtb2R1bGUgb3IgYnVpbHQtaW4s IG9tYXBmYiB3aWxsCj4gbm90IHdvcmsuIFNvIGV2ZW4gaWYgd2UgZ2V0IHRoZW0gdG8gY29tcGls ZSBhbmQgbGluaywgaXQnbGwgYnJlYWsgYXQKPiBydW50aW1lIG9uZSB3YXkgb3IgYW5vdGhlci4K PiAKPiA+PiBMZXQncyBqdXN0IGxpdmUgd2l0aCB0aGUgZmFjdCB0aGF0IGJvdGggZHJpdmVycwo+ ID4+IGNhbid0IGJlIGNvbXBpbGVkIGF0IHRoZSBzYW1lIHRpbWUsIGdpdmVuIHRoYXQgb21hcGZi IGlzIGRlcHJlY2F0ZWQuCj4gPiAKPiA+IElNTywgYSBkcml2ZXIgdGhhdCBpdCBpcyBkZXByZWNh dGVkLCBiZWluZyBpbiBhIHN0YXRlIHdoZXJlIGl0Cj4gPiBjb25mbGljdHMgd2l0aCBhIG5vbi1k ZXByZWNhdGVkIGRyaXZlciB0aGF0IGlzIHVuZGVyIGhlYXZ5IHJld29yawo+ID4gaXMgYSB2ZXJ5 IGdvb2QgY2FuZGlkYXRlIHRvIGdvIHRvIGRyaXZlcnMvc3RhZ2luZyBvciBldmVuIHRvIC9kZXYv bnVsbC4KPiAKPiBUaGUgcHJvYmxlbSBpcyB0aGF0IGl0IHN1cHBvcnRzIG9sZCBkZXZpY2VzIHdo aWNoIGFyZSBub3Qgc3VwcG9ydGVkIGJ5Cj4gb21hcGRybS4gQnV0IGJvdGggb21hcGZiIGFuZCBv bWFwZHJtIHN1cHBvcnQgbWFueSBvZiB0aGUgc2FtZSBkZXZpY2VzLgoKQ291bGQgd2UgdHJpbSBk b3duIG9tYXBmYiB0byByZW1vdmUgc3VwcG9ydCBmb3IgdGhlIGRldmljZXMgc3VwcG9ydGVkIGJ5 IApvbWFwZHJtID8KCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([213.167.242.64]:37866 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751575AbeDYJDI (ORCPT ); Wed, 25 Apr 2018 05:03:08 -0400 From: Laurent Pinchart To: Tomi Valkeinen Cc: Mauro Carvalho Chehab , Bartlomiej Zolnierkiewicz , Linux Media Mailing List , Mauro Carvalho Chehab , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP Date: Wed, 25 Apr 2018 12:03:22 +0300 Message-ID: <1818588.4EAHIaV2gL@avalon> In-Reply-To: <70b5e60f-346e-4b34-8235-ce62de720a99@ti.com> References: <20180423170955.13421017@vento.lan> <70b5e60f-346e-4b34-8235-ce62de720a99@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Tomi, On Wednesday, 25 April 2018 09:24:14 EEST Tomi Valkeinen wrote: > On 23/04/18 23:09, Mauro Carvalho Chehab wrote: > >> I don't think it's worth it renaming the common symbols. They will change > >> over time as omapdrm is under heavy rework, and it's painful enough > >> without having to handle cross-tree changes. > > > > It could just rename the namespace-conflicting FB_OMAP2 functions, > > keeping the DRM ones as-is. > > Yes, I'm fine with renaming omapfb functions if that helps. But still, > if omapdrm is enabled in the kernel as module or built-in, omapfb will > not work. So even if we get them to compile and link, it'll break at > runtime one way or another. > > >> Let's just live with the fact that both drivers > >> can't be compiled at the same time, given that omapfb is deprecated. > > > > IMO, a driver that it is deprecated, being in a state where it > > conflicts with a non-deprecated driver that is under heavy rework > > is a very good candidate to go to drivers/staging or even to /dev/null. > > The problem is that it supports old devices which are not supported by > omapdrm. But both omapfb and omapdrm support many of the same devices. Could we trim down omapfb to remove support for the devices supported by omapdrm ? -- Regards, Laurent Pinchart