From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Figa <tomasz.figa@gmail.com>
Subject: Re: [PATCH v3 04/32] drm/exynos: Use manager_op initialize in fimd
Date: Fri, 01 Nov 2013 00:49:43 +0100
Message-ID: <1821959.flD2ZDaB3W@flatron>
References: <1383063198-10526-1-git-send-email-seanpaul@chromium.org>
	<1383063198-10526-5-git-send-email-seanpaul@chromium.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-ee0-f50.google.com (mail-ee0-f50.google.com [74.125.83.50])
	by gabe.freedesktop.org (Postfix) with ESMTP id 0DD9FF00E8
	for <dri-devel@lists.freedesktop.org>;
	Thu, 31 Oct 2013 16:49:42 -0700 (PDT)
Received: by mail-ee0-f50.google.com with SMTP id l10so1702810eei.9
	for <dri-devel@lists.freedesktop.org>;
	Thu, 31 Oct 2013 16:49:42 -0700 (PDT)
In-Reply-To: <1383063198-10526-5-git-send-email-seanpaul@chromium.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces@lists.freedesktop.org
Errors-To: dri-devel-bounces@lists.freedesktop.org
To: Sean Paul <seanpaul@chromium.org>
Cc: dri-devel@lists.freedesktop.org, marcheu@chromium.org
List-Id: dri-devel@lists.freedesktop.org

Hi Sean,

On Tuesday 29 of October 2013 12:12:50 Sean Paul wrote:
> This patch implements the intitialize manager op in fimd.
> 
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
> 
> Changes in v2: None
> Changes in v3: None
> 
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 19 +++++++++++++++----
>  1 file changed, 15 insertions(+), 4 deletions(-)
[snip]
>  static void fimd_dpms(struct device *subdrv_dev, int mode)
>  {
>  	struct fimd_context *ctx = get_fimd_context(subdrv_dev);
> @@ -660,6 +671,7 @@ static void fimd_wait_for_vblank(struct device *dev)
> }
> 
>  static struct exynos_drm_manager_ops fimd_manager_ops = {
> +	.initialize = fimd_mgr_initialize,
>  	.dpms = fimd_dpms,
>  	.apply = fimd_apply,
>  	.commit = fimd_commit,
> @@ -681,7 +693,6 @@ static irqreturn_t fimd_irq_handler(int irq, void
> *dev_id) {
>  	struct fimd_context *ctx = (struct fimd_context *)dev_id;
>  	struct exynos_drm_subdrv *subdrv = &ctx->subdrv;
> -	struct drm_device *drm_dev = subdrv->drm_dev;

Apparently the driver already can have a reference to drm_device, without 
the .initialize() method being called.

I guess your change makes it somehow better, but patch description fails 
to explain this.

Best regards,
Tomasz