From: Thomas Monjalon <thomas@monjalon.net>
To: Ophir Munk <ophirmu@mellanox.com>, Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Pascal Mazon <pascal.mazon@6wind.com>,
Olga Shern <olgas@mellanox.com>,
stable@dpdk.org
Subject: Re: [PATCH v1] net/tap: return empty port offload capabilities
Date: Wed, 25 Apr 2018 18:47:51 +0200 [thread overview]
Message-ID: <1822119.1fBLbGrzlv@xps> (raw)
In-Reply-To: <1524672957-4018-1-git-send-email-ophirmu@mellanox.com>
25/04/2018 18:15, Ophir Munk:
> Fix report on port offload capabilities to be 0 (no capabilities).
> Before this commit port capabilities were a clone of queue
> capabilities, however the current TAP offload capabilities (e.g.
> checksum calculation) are per queue and are not specific per port.
I did not follow what is the problem exactly.
But this change looks wrong to me.
Please look at the thread
"Survey for final decision about per-port offload API"
http://dpdk.org/ml/archives/dev/2018-March/094459.html
It says:
"every queue capabilities must be reported as port capabilities"
next prev parent reply other threads:[~2018-04-25 16:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 16:15 [PATCH v1] net/tap: return empty port offload capabilities Ophir Munk
2018-04-25 16:31 ` Ferruh Yigit
2018-04-26 11:09 ` Ophir Munk
2018-04-25 16:47 ` Thomas Monjalon [this message]
2018-04-25 17:13 ` Ferruh Yigit
2018-04-26 11:13 ` [PATCH v2] " Ophir Munk
2018-04-26 16:56 ` Ferruh Yigit
2018-04-26 16:57 ` [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1822119.1fBLbGrzlv@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=pascal.mazon@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.