From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Ananyev,
Konstantin"
<konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v2 0/7] add mtu and flow control handlers
Date: Tue, 17 Jun 2014 11:25:31 +0200 [thread overview]
Message-ID: <18221367.CmmvaOYvmf@xps13> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB9772580EFB75F6-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-17 08:57, Ananyev, Konstantin:
> >> 3) if ((mtu < 68) || (frame_size > dev_info.max_rx_pktlen))
> >> Can we add a new define for min allowable MTU (68) as it used in few places.
>
> >RTE_IPV4_MIN_MTU then ?
>
> Sounds good to me.
>
> >I am not sure where this belongs, it could go in rte_ethdev.h.
>
> Probably rte_ether.h?
As you konw, rte_ether.h is for ethernet definition
(and should be located in librte_net).
For RTE_IPV4_MIN_MTU, I think librte_net/rte_ip.h is more appropriate.
--
Thomas
next prev parent reply other threads:[~2014-06-17 9:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 13:37 [PATCH v2 0/7] add mtu and flow control handlers David Marchand
[not found] ` <1402666663-10260-1-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-06-13 13:37 ` [PATCH v2 1/7] ethdev: retrieve flow control configuration David Marchand
2014-06-13 13:37 ` [PATCH v2 2/7] ethdev: add autoneg parameter in flow ctrl accessors David Marchand
2014-06-13 13:37 ` [PATCH v2 3/7] ethdev: store min rx buffer size David Marchand
2014-06-13 13:37 ` [PATCH v2 4/7] ethdev: introduce enable_scatter rx mode David Marchand
2014-06-13 13:37 ` [PATCH v2 5/7] ethdev: add mtu accessors David Marchand
2014-06-13 13:37 ` [PATCH v2 6/7] ixgbe: add set_mtu to ixgbevf David Marchand
2014-06-13 13:37 ` [PATCH v2 7/7] app/testpmd: allow to configure mtu David Marchand
2014-06-16 17:07 ` [PATCH v2 0/7] add mtu and flow control handlers Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB9772580EFB73D4-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-17 8:42 ` David Marchand
[not found] ` <539FFF5A.80307-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-06-17 8:57 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB9772580EFB75F6-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-17 9:25 ` Thomas Monjalon [this message]
2014-06-17 11:42 ` Ananyev, Konstantin
2014-06-17 13:39 ` David Marchand
[not found] ` <53A0451B.6090104-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-06-17 15:26 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18221367.CmmvaOYvmf@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.