From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"jia.guo@intel.com" <jia.guo@intel.com>,
"Jacob, Jerin" <Jerin.JacobKollanukkaran@cavium.com>,
"Bhagavatula, Pavan" <Pavan.Bhagavatula@cavium.com>
Subject: Re: [PATCH] vfio: fix missing header inclusion
Date: Wed, 17 Oct 2018 10:18:09 +0200 [thread overview]
Message-ID: <1822592.kQGmlEvfPa@xps> (raw)
In-Reply-To: <20181017052950.29078-1-jerin.jacob@caviumnetworks.com>
17/10/2018 07:30, Jerin Jacob:
> The following change set introduces HAVE_VFIO_DEV_REQ_INTERFACE
> and used in the below files.
>
> drivers/bus/pci/linux/pci_vfio.c
> drivers/bus/pci/pci_common.c
> lib/librte_eal/linuxapp/eal/eal_interrupts.c
>
> However, Except the first file, the change missed to include
> <rte_vfio.h> where HAVE_VFIO_DEV_REQ_INTERFACE defined.
> This creates runtime following error on vfio-pci mode and
> kernel >= 4.0.0 combination.
>
> EAL: [rte_intr_enable] Unknown handle type of fd 95
> EAL: [pci_vfio_enable_notifier]Fail to enable req notifier.
> EAL: Fail to unregister req notifier handler.
> EAL: Error setting up notifier!
> EAL: Requested device 0000:07:00.1 cannot be used
>
> Fixes: cda94419964f ("vfio: fix build with Linux < 4.0")
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Applied, thanks
prev parent reply other threads:[~2018-10-17 8:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 5:30 [PATCH] vfio: fix missing header inclusion Jerin Jacob
2018-10-17 8:18 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1822592.kQGmlEvfPa@xps \
--to=thomas@monjalon.net \
--cc=Jerin.JacobKollanukkaran@cavium.com \
--cc=Pavan.Bhagavatula@cavium.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jia.guo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.