From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:44936 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753188AbcLNUy1 (ORCPT ); Wed, 14 Dec 2016 15:54:27 -0500 From: Laurent Pinchart To: Sergei Shtylyov Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] drm: rcar-du: enable VSPDs on R8A7791 Date: Wed, 14 Dec 2016 22:55:01 +0200 Message-ID: <1823239.KB8yzOkpmW@avalon> In-Reply-To: <4947043.txDs5ZU4mH@wasted.cogentembedded.com> References: <4947043.txDs5ZU4mH@wasted.cogentembedded.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Sergei, Thank you for the patch. On Wednesday 14 Dec 2016 23:37:08 Sergei Shtylyov wrote: > We're going to use R8A7791 VSPDs to control DU, so set the corresponding > flag. > > Signed-off-by: Sergei Shtylyov For the same reason I nacked the corresponding patch to the VSP1 driver, I have to nack this one as well. The Gen2 DU has native planes, this patch would prevent using them. I don't see a good reason to do so. > --- > The patch is against David Airlie's 'linux.git' repo's 'drm-next' branch. > > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > Index: linux/drivers/gpu/drm/rcar-du/rcar_du_drv.c > =================================================================== > --- linux.orig/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ linux/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -90,7 +90,8 @@ static const struct rcar_du_device_info > static const struct rcar_du_device_info rcar_du_r8a7791_info = { > .gen = 2, > .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK > - | RCAR_DU_FEATURE_EXT_CTRL_REGS, > + | RCAR_DU_FEATURE_EXT_CTRL_REGS > + | RCAR_DU_FEATURE_VSP1_SOURCE, > .num_crtcs = 2, > .routes = { > /* R8A779[13] has one RGB output, one LVDS output and one -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm: rcar-du: enable VSPDs on R8A7791 Date: Wed, 14 Dec 2016 22:55:01 +0200 Message-ID: <1823239.KB8yzOkpmW@avalon> References: <4947043.txDs5ZU4mH@wasted.cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 234C06E8AD for ; Wed, 14 Dec 2016 20:54:27 +0000 (UTC) In-Reply-To: <4947043.txDs5ZU4mH@wasted.cogentembedded.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sergei Shtylyov Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgU2VyZ2VpLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBXZWRuZXNkYXkgMTQgRGVj IDIwMTYgMjM6Mzc6MDggU2VyZ2VpIFNodHlseW92IHdyb3RlOgo+IFdlJ3JlIGdvaW5nIHRvIHVz ZSBSOEE3NzkxIFZTUERzIHRvIGNvbnRyb2wgRFUsIHNvIHNldCB0aGUgY29ycmVzcG9uZGluZwo+ IGZsYWcuCj4gCj4gU2lnbmVkLW9mZi1ieTogU2VyZ2VpIFNodHlseW92IDxzZXJnZWkuc2h0eWx5 b3ZAY29nZW50ZW1iZWRkZWQuY29tPgoKRm9yIHRoZSBzYW1lIHJlYXNvbiBJIG5hY2tlZCB0aGUg Y29ycmVzcG9uZGluZyBwYXRjaCB0byB0aGUgVlNQMSBkcml2ZXIsIEkgCmhhdmUgdG8gbmFjayB0 aGlzIG9uZSBhcyB3ZWxsLiBUaGUgR2VuMiBEVSBoYXMgbmF0aXZlIHBsYW5lcywgdGhpcyBwYXRj aCB3b3VsZCAKcHJldmVudCB1c2luZyB0aGVtLiBJIGRvbid0IHNlZSBhIGdvb2QgcmVhc29uIHRv IGRvIHNvLgoKPiAtLS0KPiBUaGUgcGF0Y2ggaXMgYWdhaW5zdCBEYXZpZCBBaXJsaWUncyAnbGlu dXguZ2l0JyByZXBvJ3MgJ2RybS1uZXh0JyBicmFuY2guCj4gCj4gIGRyaXZlcnMvZ3B1L2RybS9y Y2FyLWR1L3JjYXJfZHVfZHJ2LmMgfCAgICAzICsrLQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gSW5kZXg6IGxpbnV4L2RyaXZlcnMvZ3B1L2Ry bS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMKPiA9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Cj4gLS0tIGxpbnV4Lm9yaWcvZHJp dmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYwo+ICsrKyBsaW51eC9kcml2ZXJzL2dw dS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5jCj4gQEAgLTkwLDcgKzkwLDggQEAgc3RhdGljIGNv bnN0IHN0cnVjdCByY2FyX2R1X2RldmljZV9pbmZvCj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgcmNh cl9kdV9kZXZpY2VfaW5mbyByY2FyX2R1X3I4YTc3OTFfaW5mbyA9IHsKPiAgCS5nZW4gPSAyLAo+ ICAJLmZlYXR1cmVzID0gUkNBUl9EVV9GRUFUVVJFX0NSVENfSVJRX0NMT0NLCj4gLQkJICB8IFJD QVJfRFVfRkVBVFVSRV9FWFRfQ1RSTF9SRUdTLAo+ICsJCSAgfCBSQ0FSX0RVX0ZFQVRVUkVfRVhU X0NUUkxfUkVHUwo+ICsJCSAgfCBSQ0FSX0RVX0ZFQVRVUkVfVlNQMV9TT1VSQ0UsCj4gIAkubnVt X2NydGNzID0gMiwKPiAgCS5yb3V0ZXMgPSB7Cj4gIAkJLyogUjhBNzc5WzEzXSBoYXMgb25lIFJH QiBvdXRwdXQsIG9uZSBMVkRTIG91dHB1dCBhbmQgb25lCgotLSAKUmVnYXJkcywKCkxhdXJlbnQg UGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=