From: Thomas Monjalon <thomas@monjalon.net>
To: Gregory Etelson <getelson@nvidia.com>
Cc: dev@dpdk.org, yux.jiang@intel.com, Matan Azrad <matan@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Xiaoyun Li <xiaoyun.li@intel.com>, Ori Kam <orika@nvidia.com>,
Olivier Matz <olivier.matz@6wind.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix IPv4 checksum
Date: Wed, 04 Aug 2021 11:38:37 +0200 [thread overview]
Message-ID: <1823383.vttildH05X@thomas> (raw)
In-Reply-To: <CACZ4nhti+Ug7qMS4SwT6HbdzUJpZ-Xbgm4R0oK3sRNxTLxB4Lw@mail.gmail.com>
> > UDP protocol reserves 0 checksum value for special purposes.
> > Other protocols, like IPv4, TCP and SCTP must calculate checksum value
> > in software or offload checksum calculation to hardware.
> >
> > If IPv4 TX checksum offload was off and header checksum was set to 0,
> > testpmd csum engine did not calculate checksum value for IPv4, TCP and
> > SCTP.
> >
> > The patch always calculates IPv4, TCP and SCTP TX checksums if it is
> > not offloaded.
> >
> > Fixes: b2a9e4a855d0 ("app/testpmd: fix Tx checksum calculation for tunnel")
> > Bugzilla ID: 768
> >
> > Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Applied, thanks.
prev parent reply other threads:[~2021-08-04 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 18:00 [dpdk-dev] [PATCH] app/testpmd: fix IPv4 checksum Gregory Etelson
2021-08-02 18:04 ` Ajit Khaparde
2021-08-02 18:13 ` [dpdk-dev] [PATCH v2] " Gregory Etelson
2021-08-03 1:33 ` Ajit Khaparde
2021-08-04 9:38 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1823383.vttildH05X@thomas \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=olivier.matz@6wind.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=viacheslavo@nvidia.com \
--cc=xiaoyun.li@intel.com \
--cc=yux.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.