From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94FF0C3ABBC for ; Fri, 9 May 2025 08:15:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k66pmCI1pT3vfBJYih/fR8R6maFESHCnrlUq6lhyU7E=; b=F/hkmvY9QSxhqt6ZmZaURETXjh jsMY6yJHzNT7lKZF8mZXemSgc7EOgpPnjjsRQXIJWsDNCnqAjQEIw0hReOxfsVPwnemwRKM5yD9Zx vt8hMFAwL5dcbyWPocoUHz9LtwG9PWxSZMDRCdDlI0ucvW6nijWV6l3HZFV02jQn7RJBkQtSCfubu PhzRLlJGKoe10m8kje8HOetYSvp05dVVXX7cHuMyTf/lmJ/2zjd1zGTdL+tjKNt5kfDTsyIXu0laq RrxXzOnkIQX4Y88GETGgOluDOcwJAN7+r37TQJf/8iKQnLodnq00kk4laFAUfEnPpdK+3gl6+oiuI AkJfQIkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uDItO-00000002tL1-1A28; Fri, 09 May 2025 08:15:38 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uDIS7-00000002npg-3TWg; Fri, 09 May 2025 07:47:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID; bh=k66pmCI1pT3vfBJYih/fR8R6maFESHCnrlUq6lhyU7E=; b=uf1RgzYa1jurRkM4LRmh7M2nKi X/tNKnrMcl9U3XpmbQXaWzo+GtVk2elzKzG+FacPEffuVMPfQzBsi4GYPHTJfh4wa3q8SS4uYbr5w 38D7UiS497Wv+KxKTttiN6YWS9Gi2SXLmG5gfxG0GyTADF+EUp7qGoiC0pBINFIsW6SjWr0vTVAPz bH98GaqZTd6jGfDtZtFA8kexrzNPabyXJx9uekAdnvYdAWWixnZbkPqpObBteA5dPPAwxstxYIHMg yTrJZ6pR+o/+4FED01z3iFhYKVPZ/UXHDyQg9McHn3Bb9ptOo9OWt68bZ8HyFq8IR3vsDgSKTWFIH OItVOlXg==; Received: from i53875a1d.versanet.de ([83.135.90.29] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uDIRf-0007kz-JF; Fri, 09 May 2025 09:46:59 +0200 From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Krzysztof Kozlowski , Chaoyi Chen , Sandy Huang , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chaoyi Chen Cc: Dragan Simic , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml Date: Fri, 09 May 2025 09:46:57 +0200 Message-ID: <1824349.VLH7GnMWUR@diego> In-Reply-To: <5a4f6229-1450-4c96-bfac-5257f66b2ddf@rock-chips.com> References: <20250509070247.868-1-kernel@airkyi.com> <5a4f6229-1450-4c96-bfac-5257f66b2ddf@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250509_004727_891923_CC633BCA X-CRM114-Status: GOOD ( 18.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Freitag, 9. Mai 2025, 09:34:47 Mitteleurop=C3=A4ische Sommerzeit schrieb= Chaoyi Chen: > Hi Krzysztof, >=20 > On 2025/5/9 15:11, Krzysztof Kozlowski wrote: > > On 09/05/2025 09:02, Chaoyi Chen wrote: > >> + > >> + clock-names: > >> + items: > >> + - const: core-clk > >> + - const: pclk > >> + - const: spdif > >> + - const: grf > >> + > >> + extcon: > >> + $ref: /schemas/types.yaml#/definitions/phandle-array > >> + description: > >> + Phandle to the extcon device providing the cable state for the = DP PHY. > >> + > >> + interrupts: > >> + maxItems: 1 > >> + > >> + phys: > >> + $ref: /schemas/types.yaml#/definitions/phandle-array > > Just phandle. If this is an array (but why?), you need maxItems for > > outer and inner dimensions. >=20 > I think it could be phandle or phandle-array. Since the RK3399 DP has=20 > two PHYs, if we put in two PHYs here, the driver will pick one PHY port=20 > that is already plugged into the DP for output. If we fill in only one=20 > PHY here, then output is only allowed on the corresponding PHY. >=20 > Will add restrictions and add more descriptions in v3. Just looked that up in the documentation. Only the rk3399 has used this controller at all so far. There is one cdn-dp controller on it, but two phys for the two type-c blocks on the soc. The controller can then select which one to drive. So yep, there are two phys. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 460AAC3ABC9 for ; Fri, 9 May 2025 08:15:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QBgflXIyrVWJZ3MKrGO0+7p2IASN9AbpDwZh0Wn78j0=; b=q9gZkag4cEvZQO WS8WtxS0/NAYp++xF83xuR3Nfr/xafNZ9X2i6ZCXJLbPWnRfsz0iMRshEZT3OaKKSSMhyHB0YUJ7D KUGt3CUay5Pj2euSMv2H6KdZTUHYzxl3wsxdlhf+EcpcFzuY8dOHCeyvBfK0gp0JB10Jxm5geUurK GAzgDtk079mHSirDM59vl8jb8EiHoPt9bN4hHNurP+7Hs1EYcyA4W7AjnKAakD7I+gJkwbRZ1FwMP aHt37SgA1iqR8Bs0l/cypUoE6aFWAO4DZbBbhuV2CwdheUJVmG1n9hyoX3C8yRzWdgI0DMX4RyZHy y0e7Fxxi76iu/NAy1TWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uDItO-00000002tLV-3U6c; Fri, 09 May 2025 08:15:38 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uDIS7-00000002npg-3TWg; Fri, 09 May 2025 07:47:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID; bh=k66pmCI1pT3vfBJYih/fR8R6maFESHCnrlUq6lhyU7E=; b=uf1RgzYa1jurRkM4LRmh7M2nKi X/tNKnrMcl9U3XpmbQXaWzo+GtVk2elzKzG+FacPEffuVMPfQzBsi4GYPHTJfh4wa3q8SS4uYbr5w 38D7UiS497Wv+KxKTttiN6YWS9Gi2SXLmG5gfxG0GyTADF+EUp7qGoiC0pBINFIsW6SjWr0vTVAPz bH98GaqZTd6jGfDtZtFA8kexrzNPabyXJx9uekAdnvYdAWWixnZbkPqpObBteA5dPPAwxstxYIHMg yTrJZ6pR+o/+4FED01z3iFhYKVPZ/UXHDyQg9McHn3Bb9ptOo9OWt68bZ8HyFq8IR3vsDgSKTWFIH OItVOlXg==; Received: from i53875a1d.versanet.de ([83.135.90.29] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uDIRf-0007kz-JF; Fri, 09 May 2025 09:46:59 +0200 From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Krzysztof Kozlowski , Chaoyi Chen , Sandy Huang , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chaoyi Chen Cc: Dragan Simic , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml Date: Fri, 09 May 2025 09:46:57 +0200 Message-ID: <1824349.VLH7GnMWUR@diego> In-Reply-To: <5a4f6229-1450-4c96-bfac-5257f66b2ddf@rock-chips.com> References: <20250509070247.868-1-kernel@airkyi.com> <5a4f6229-1450-4c96-bfac-5257f66b2ddf@rock-chips.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250509_004727_891923_CC633BCA X-CRM114-Status: GOOD ( 18.25 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org QW0gRnJlaXRhZywgOS4gTWFpIDIwMjUsIDA5OjM0OjQ3IE1pdHRlbGV1cm9ww6Rpc2NoZSBTb21t ZXJ6ZWl0IHNjaHJpZWIgQ2hhb3lpIENoZW46Cj4gSGkgS3J6eXN6dG9mLAo+IAo+IE9uIDIwMjUv NS85IDE1OjExLCBLcnp5c3p0b2YgS296bG93c2tpIHdyb3RlOgo+ID4gT24gMDkvMDUvMjAyNSAw OTowMiwgQ2hhb3lpIENoZW4gd3JvdGU6Cj4gPj4gKwo+ID4+ICsgIGNsb2NrLW5hbWVzOgo+ID4+ ICsgICAgaXRlbXM6Cj4gPj4gKyAgICAgIC0gY29uc3Q6IGNvcmUtY2xrCj4gPj4gKyAgICAgIC0g Y29uc3Q6IHBjbGsKPiA+PiArICAgICAgLSBjb25zdDogc3BkaWYKPiA+PiArICAgICAgLSBjb25z dDogZ3JmCj4gPj4gKwo+ID4+ICsgIGV4dGNvbjoKPiA+PiArICAgICRyZWY6IC9zY2hlbWFzL3R5 cGVzLnlhbWwjL2RlZmluaXRpb25zL3BoYW5kbGUtYXJyYXkKPiA+PiArICAgIGRlc2NyaXB0aW9u Ogo+ID4+ICsgICAgICBQaGFuZGxlIHRvIHRoZSBleHRjb24gZGV2aWNlIHByb3ZpZGluZyB0aGUg Y2FibGUgc3RhdGUgZm9yIHRoZSBEUCBQSFkuCj4gPj4gKwo+ID4+ICsgIGludGVycnVwdHM6Cj4g Pj4gKyAgICBtYXhJdGVtczogMQo+ID4+ICsKPiA+PiArICBwaHlzOgo+ID4+ICsgICAgJHJlZjog L3NjaGVtYXMvdHlwZXMueWFtbCMvZGVmaW5pdGlvbnMvcGhhbmRsZS1hcnJheQo+ID4gSnVzdCBw aGFuZGxlLiBJZiB0aGlzIGlzIGFuIGFycmF5IChidXQgd2h5PyksIHlvdSBuZWVkIG1heEl0ZW1z IGZvcgo+ID4gb3V0ZXIgYW5kIGlubmVyIGRpbWVuc2lvbnMuCj4gCj4gSSB0aGluayBpdCBjb3Vs ZCBiZSBwaGFuZGxlIG9yIHBoYW5kbGUtYXJyYXkuIFNpbmNlIHRoZSBSSzMzOTkgRFAgaGFzIAo+ IHR3byBQSFlzLCBpZiB3ZSBwdXQgaW4gdHdvIFBIWXMgaGVyZSwgdGhlIGRyaXZlciB3aWxsIHBp Y2sgb25lIFBIWSBwb3J0IAo+IHRoYXQgaXMgYWxyZWFkeSBwbHVnZ2VkIGludG8gdGhlIERQIGZv ciBvdXRwdXQuIElmIHdlIGZpbGwgaW4gb25seSBvbmUgCj4gUEhZIGhlcmUsIHRoZW4gb3V0cHV0 IGlzIG9ubHkgYWxsb3dlZCBvbiB0aGUgY29ycmVzcG9uZGluZyBQSFkuCj4gCj4gV2lsbCBhZGQg cmVzdHJpY3Rpb25zIGFuZCBhZGQgbW9yZSBkZXNjcmlwdGlvbnMgaW4gdjMuCgpKdXN0IGxvb2tl ZCB0aGF0IHVwIGluIHRoZSBkb2N1bWVudGF0aW9uLgoKT25seSB0aGUgcmszMzk5IGhhcyB1c2Vk IHRoaXMgY29udHJvbGxlciBhdCBhbGwgc28gZmFyLiBUaGVyZSBpcyBvbmUKY2RuLWRwIGNvbnRy b2xsZXIgb24gaXQsIGJ1dCB0d28gcGh5cyBmb3IgdGhlIHR3byB0eXBlLWMgYmxvY2tzIG9uCnRo ZSBzb2MuCgpUaGUgY29udHJvbGxlciBjYW4gdGhlbiBzZWxlY3Qgd2hpY2ggb25lIHRvIGRyaXZl LiBTbyB5ZXAsIHRoZXJlCmFyZSB0d28gcGh5cy4KCgpIZWlrbwoKCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxp c3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg==