From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 10/10] udmabuf: use ENOTTY for invalid ioctls Date: Tue, 11 Sep 2018 12:43:05 +0300 Message-ID: <1825209.4vUuoC1oRu@avalon> References: <20180911065921.23818-1-kraxel@redhat.com> <20180911065921.23818-11-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6E0F289D79 for ; Tue, 11 Sep 2018 09:42:54 +0000 (UTC) In-Reply-To: <20180911065921.23818-11-kraxel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann Cc: "moderated list:DMA BUFFER SHARING FRAMEWORK" , open list , dri-devel@lists.freedesktop.org, "open list:DMA BUFFER SHARING FRAMEWORK" List-Id: dri-devel@lists.freedesktop.org SGkgR2VyZCwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gVHVlc2RheSwgMTEgU2VwdGVt YmVyIDIwMTggMDk6NTk6MjEgRUVTVCBHZXJkIEhvZmZtYW5uIHdyb3RlOgo+IFJlcG9ydGVkLWJ5 OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4g U2lnbmVkLW9mZi1ieTogR2VyZCBIb2ZmbWFubiA8a3JheGVsQHJlZGhhdC5jb20+CgpSZXZpZXdl ZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29t PgoKPiAtLS0KPiAgZHJpdmVycy9kbWEtYnVmL3VkbWFidWYuYyB8IDIgKy0KPiAgMSBmaWxlIGNo YW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZG1hLWJ1Zi91ZG1hYnVmLmMgYi9kcml2ZXJzL2RtYS1idWYvdWRtYWJ1Zi5jCj4gaW5k ZXggMTg2MmJiNmJlZC4uYTU0M2ZkNmVhMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2RtYS1idWYv dWRtYWJ1Zi5jCj4gKysrIGIvZHJpdmVycy9kbWEtYnVmL3VkbWFidWYuYwo+IEBAIC0yNjAsNyAr MjYwLDcgQEAgc3RhdGljIGxvbmcgdWRtYWJ1Zl9pb2N0bChzdHJ1Y3QgZmlsZSAqZmlscCwgdW5z aWduZWQKPiBpbnQgaW9jdGwsIHJldCA9IHVkbWFidWZfaW9jdGxfY3JlYXRlX2xpc3QoZmlscCwg YXJnKTsKPiAgCQlicmVhazsKPiAgCWRlZmF1bHQ6Cj4gLQkJcmV0ID0gLUVJTlZBTDsKPiArCQly ZXQgPSAtRU5PVFRZOwo+ICAJCWJyZWFrOwo+ICAJfQo+ICAJcmV0dXJuIHJldDsKCi0tIApSZWdh cmRzLAoKTGF1cmVudCBQaW5jaGFydAoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([213.167.242.64]:34324 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726678AbeIKOlZ (ORCPT ); Tue, 11 Sep 2018 10:41:25 -0400 From: Laurent Pinchart To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, Sumit Semwal , "open list:DMA BUFFER SHARING FRAMEWORK" , "moderated list:DMA BUFFER SHARING FRAMEWORK" , open list Subject: Re: [PATCH 10/10] udmabuf: use ENOTTY for invalid ioctls Date: Tue, 11 Sep 2018 12:43:05 +0300 Message-ID: <1825209.4vUuoC1oRu@avalon> In-Reply-To: <20180911065921.23818-11-kraxel@redhat.com> References: <20180911065921.23818-1-kraxel@redhat.com> <20180911065921.23818-11-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Gerd, Thank you for the patch. On Tuesday, 11 September 2018 09:59:21 EEST Gerd Hoffmann wrote: > Reported-by: Laurent Pinchart > Signed-off-by: Gerd Hoffmann Reviewed-by: Laurent Pinchart > --- > drivers/dma-buf/udmabuf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c > index 1862bb6bed..a543fd6ea1 100644 > --- a/drivers/dma-buf/udmabuf.c > +++ b/drivers/dma-buf/udmabuf.c > @@ -260,7 +260,7 @@ static long udmabuf_ioctl(struct file *filp, unsigned > int ioctl, ret = udmabuf_ioctl_create_list(filp, arg); > break; > default: > - ret = -EINVAL; > + ret = -ENOTTY; > break; > } > return ret; -- Regards, Laurent Pinchart