From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 1/2] drm/cma-helper: Add multi buffer support for cma fbdev Date: Tue, 14 Feb 2017 23:25:08 +0200 Message-ID: <1826666.9g7KAGLBpO@avalon> References: <20170214200951.GC22762@dvetter-linux.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id E35556E1C5 for ; Tue, 14 Feb 2017 21:24:40 +0000 (UTC) In-Reply-To: <20170214200951.GC22762@dvetter-linux.ger.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Linux Kernel Mailing List , dri-devel , Daniel Vetter , Maxime Ripard , Stefan Christ List-Id: dri-devel@lists.freedesktop.org SGkgRGFuaWVsLAoKT24gVHVlc2RheSAxNCBGZWIgMjAxNyAyMTowOTo1MSBEYW5pZWwgVmV0dGVy IHdyb3RlOgo+IE9uIE1vbiwgRmViIDEzLCAyMDE3IGF0IDExOjIwOjUxQU0gKzAwMDAsIERhbmll bCBTdG9uZSB3cm90ZToKPiA+IE9uIDEzIEZlYnJ1YXJ5IDIwMTcgYXQgMTA6NTQsIE1heGltZSBS aXBhcmQgd3JvdGU6Cj4gPj4gT24gU3VuLCBGZWIgMTIsIDIwMTcgYXQgMDI6Mjg6MTFQTSArMDIw MCwgTGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiA+Pj4gT24gVGh1cnNkYXkgMDIgRmViIDIwMTcg MTE6MzE6NTYgTWF4aW1lIFJpcGFyZCB3cm90ZToKPiA+Pj4+IFRoaXMgcGF0Y2ggYWRkIGEgY29u ZmlnIHRvIHN1cHBvcnQgdG8gY3JlYXRlIG11bHRpIGJ1ZmZlciBmb3IgY21hCj4gPj4+PiBmYmRl di4gU3VjaCBhcyBkb3VibGUgYnVmZmVyIGFuZCB0cmlwbGUgYnVmZmVyLgo+ID4+Pj4gCj4gPj4+ PiBDbWEgZmJkZXYgaXMgY29udmllbnQgdG8gYWRkIGEgbGVnZW5jeSBmYmRldi4gQW5kIHN0aWxs IG1hbnkgQW5kcm9pZAo+ID4+Pj4gZGV2aWNlcyB1c2UgZmJkZXYgbm93IGFuZCBhdCBsZWFzdCBk b3VibGUgYnVmZmVyIGlzIG5lZWRlZCBmb3IgdGhlc2UKPiA+Pj4+IEFuZHJvaWQgZGV2aWNlcywg c28gdGhhdCBhIGJ1ZmZlciBmbGlwIGNhbiBiZSBvcGVyYXRlZC4gSXQgd2lsbCBuZWVkCj4gPj4+ PiBzb21lIHRpbWUgZm9yIEFuZHJvaWQgZGV2aWNlIHZlbmRvcnMgdG8gYWJvbmRvbiBsZWdlbmN5 IGZiZGV2LiBTbwo+ID4+Pj4gbXVsdGkgYnVmZmVyIGZvciBmYmRldiBpcyBuZWVkZWQuCj4gPj4+ IAo+ID4+PiBIb3cgZXhhY3RseSBkbyB3ZSBleHBlY3QgQW5kcm9pZCB0byBtb3ZlIGF3YXkgZnJv bSBmYmRldiBpZiB3ZSBhZGQKPiA+Pj4gZmVhdHVyZXMgdG8gdGhlIGZiZGV2IGNvbXBhdCBsYXll ciA/IEknZCBtdWNoIHJhdGhlciBtYWtlIGl0IGNsZWFyIHRvCj4gPj4+IHRoZW0gdGhhdCBmYmRl diBpcyBhIHRoaW5nIGZyb20gdGhlIHBhc3QgYW5kIHRoYXQgdGhleSdkIGJldHRlcgo+ID4+PiBt aWdyYXRlIG5vdy4KPiA+PiAKPiA+PiBJZiB5b3VyIHBvaW50IGlzIHRoYXQgbWVyZ2luZyB0aGlz IHBhdGNoIHdpbGwgc2xvdyBkb3duIHRoZSBBbmRyb2lkCj4gPj4gbW92ZSBhd2F5IGZyb20gZmJk ZXYsIEkgZGlzYWdyZWUgd2l0aCB0aGF0IChvYnZpb3VzbHkpLgo+ID4+IAo+ID4+IEkgZG9uJ3Qg Y2FyZSBhdCBhbGwgYWJvdXQgQW5kcm9pZCBvbiBteSBwbGF0Zm9ybSBvZiBjaG9pY2UsIGJ1dCBk b24ndAo+ID4+IHNlZSBob3cgdGhhdCBtZXJnaW5nIHRoaXMgcGF0Y2ggd2lsbCBjaGFuZ2UgYW55 dGhpbmcuCj4gPj4gCj4gPj4gTGV0J3MgYmUgaG9uZXN0LCBBbmRyb2lkIHRyZWVzIHR5cGljYWxs eSBoYXZlIHRob3VzYW5kcyBvZiBwYXRjaGVzIG9uCj4gPj4gdG9wIG9mIG1haW5saW5lLiBEbyB5 b3UgdGhpbmsgYSBzaW1wbGUsIDE1IExvQywgcGF0Y2ggd2lsbCBtYWtlIGFueQo+ID4+IGRpZmZl cmVuY2UgdG8gdmVuZG9ycz8gSWYgdGhleSB3YW50IHRvIHN0YXkgb24gZmJkZXYgYW5kIGhhdmUg dGhhdAo+ID4+IGZlYXR1cmUsIHRoZXknbGwganVzdCBtZXJnZSB0aGlzIHBhdGNoLCBkb25lLgo+ ID4gCj4gPiBTbywgaW4gdGhhdCBjYXNlLCB3aHkgbm90IGp1c3QgbGV0IHRoZW0gZG8gdGhhdD8g VGhleSdkIGFscmVhZHkgaGF2ZQo+ID4gdG8gYWRkIHBhdGNoZXMgdG8gdXNlIHRoaXMsIHN1cmVs eTsgd2UgZG9uJ3QgaGF2ZSBhbnl0aGluZyBpbiBtYWlubGluZQo+ID4ga2VybmVscyB3aGljaCBh bGxvd3MgcGVvcGxlIHRvIGFjdHVhbGx5IHVzZSB0aGlzIGxhcmdlciBhbGxvY2F0aW9uLgo+ID4g QXBhcnQgZnJvbSBzb2Z0d2FyZSBtbWFwKCkgYW5kIHVzaW5nIHBhbm5pbmcgdG8gZG8gZmxpcHMs IGJ1dCBJJ20KPiA+IHRha2luZyBpdCBhcyBhIGdpdmVuIHRoYXQgcGVvcGxlIHNoaXBwaW5nIEFu ZHJvaWQgb24gdGhlaXIgZGV2aWNlcwo+ID4gYXJlbid0IHVzaW5nIHNvZnR3YXJlIHJlbmRlcmlu Zy4KPiAKPiBJIHRoaW5rIHdlIG5lZWQgdG8gbWFrZSBhIGRpc3RpbmN0aW9uIGJldHdlZW4gZmJk ZXYgdGhlIHN1YnN5c3RlbSBpbiB0aGUKPiBrZXJuZWwsIGFuZCBmYmRldiB0aGUgdWFiaToKPiAK PiAtIGZiZGV2IHRoZSBzdWJzeXN0ZW0gaXMgY29tcGxldGVseSBkZWFkIGluIHVwc3RyZWFtLiBJ IHRoaW5rIHdlIGhhdmUgZnVsbAo+ICAgYWdyZWVtZW50IG9uIHRoYXQuCj4gLSBmYmRldiB0aGUg dWFiaSBpc24ndCwgYW5kIGlmIHdlIGNhbiBnZXQgbW9yZSB1c2VycyBmcm9tIGZiZGV2IGJhc2Vk Cj4gICBkcml2ZXJzIHRvIGttcy9hdG9taWMgZHJpdmVycyBieSBhZGRpbmcgZmFpcmx5IHNpbXBs ZSBzdHVmZiBsaWtlIHRoaXMsCj4gICBJJ20gYWxsIGZvciBpdC4KClRoZSByZWFsIHF1ZXN0aW9u LCBpbiBteSBvcGluaW9uLCBpcyBob3cgdG8gZ2V0IG1vcmUgdXNlcnMgZm9yIHRoZSBEUk0vS01T IAp1c2Vyc3BhY2UgQVBJLCB0byBoZWxwIGtpbGxpbmcgdGhlIGZiZGV2IEFQSS4gV2hhdCdzIHRo ZSBpbmNlbnRpdmUgZm9yIAp1c2Vyc3BhY2UgdG8gbWlncmF0ZSBpZiB3ZSB0ZWxsIHRoZW0gdGhh dCB3ZSdyZSBnb2luZyB0byBzdXBwb3J0IHRoZSBmYmRldiBBUEkgCmZvcmV2ZXIsIGFuZCB3aWxs IGV2ZW4gZ28gdGhyb3VnaCB0aGUgdHJvdWJsZSBvZiBleHRlbmRpbmcgdGhlIHN1cHBvcnRlZCAK ZmVhdHVyZSBzZXQgPyBJIGhhdmUgYSBjdXN0b21lciB3aG8gd291bGRuJ3QgaGF2ZSBtaWdyYXRl ZCB0aGVpciB1c2Vyc3BhY2UgdG8gCkRSTS9LTVMgaWYgdGhlc2UgdHdvIHBhdGNoZXMgaGFkIGJl ZW4gbWVyZ2VkIGEgZmV3IHllYXJzIGFnby4gSSdkIHJhdGhlciAKKnJlZHVjZSogdGhlIHN1cHBv cnRlZCBmZWF0dXJlIHNldCBvdmVyIHRpbWUgdW50aWwgd2UgY2FuIGZpbmFsbHkgc3dpdGNoIGZi ZGV2IApvZmYuCgo+IFdoaWNoIG1lYW5zOiBZZXMsIEkgZnVsbHkgcGxhbiB0byBtZXJnZSB0aGlz LCBpdCBtYWtlcyBzZW5zZS4gSXQgZXZlbgo+IF9oZWxwc18gYnkgbWFraW5nIGZiZGV2LXRoZS1z dWJzeXN0ZW0gZXZlbiBkZWFkZXIuIE1ha2luZyBsaXZlIGhhcmQgZm9yCj4gb3V0LW9mLXRyZWUg Zm9sa3Mgb3IgZm9sa3Mgd2l0aCBzaGl0IHVzZXJzcGFjZSBkb2Vzbid0IG1ha2Ugc2Vuc2UsIGF0 Cj4gbGVhc3QgaWYgdGhlIG9ubHkgYmVuZWZpdCBmb3IgdXMgaXMgdGhhdCB3ZSdsbCBmZWVsIHB1 cmUgYWJvdXQgb3VyCj4gaW50ZW50aW9ucyA6LSkKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5j aGFydAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755517AbdBNVYt (ORCPT ); Tue, 14 Feb 2017 16:24:49 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:58574 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbdBNVYl (ORCPT ); Tue, 14 Feb 2017 16:24:41 -0500 From: Laurent Pinchart To: Daniel Vetter Cc: Daniel Stone , Maxime Ripard , Daniel Vetter , Stefan Christ , dri-devel , Linux Kernel Mailing List Subject: Re: [PATCH v2 1/2] drm/cma-helper: Add multi buffer support for cma fbdev Date: Tue, 14 Feb 2017 23:25:08 +0200 Message-ID: <1826666.9g7KAGLBpO@avalon> User-Agent: KMail/4.14.10 (Linux/4.9.6-gentoo-r1; KDE/4.14.28; x86_64; ; ) In-Reply-To: <20170214200951.GC22762@dvetter-linux.ger.corp.intel.com> References: <20170214200951.GC22762@dvetter-linux.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, On Tuesday 14 Feb 2017 21:09:51 Daniel Vetter wrote: > On Mon, Feb 13, 2017 at 11:20:51AM +0000, Daniel Stone wrote: > > On 13 February 2017 at 10:54, Maxime Ripard wrote: > >> On Sun, Feb 12, 2017 at 02:28:11PM +0200, Laurent Pinchart wrote: > >>> On Thursday 02 Feb 2017 11:31:56 Maxime Ripard wrote: > >>>> This patch add a config to support to create multi buffer for cma > >>>> fbdev. Such as double buffer and triple buffer. > >>>> > >>>> Cma fbdev is convient to add a legency fbdev. And still many Android > >>>> devices use fbdev now and at least double buffer is needed for these > >>>> Android devices, so that a buffer flip can be operated. It will need > >>>> some time for Android device vendors to abondon legency fbdev. So > >>>> multi buffer for fbdev is needed. > >>> > >>> How exactly do we expect Android to move away from fbdev if we add > >>> features to the fbdev compat layer ? I'd much rather make it clear to > >>> them that fbdev is a thing from the past and that they'd better > >>> migrate now. > >> > >> If your point is that merging this patch will slow down the Android > >> move away from fbdev, I disagree with that (obviously). > >> > >> I don't care at all about Android on my platform of choice, but don't > >> see how that merging this patch will change anything. > >> > >> Let's be honest, Android trees typically have thousands of patches on > >> top of mainline. Do you think a simple, 15 LoC, patch will make any > >> difference to vendors? If they want to stay on fbdev and have that > >> feature, they'll just merge this patch, done. > > > > So, in that case, why not just let them do that? They'd already have > > to add patches to use this, surely; we don't have anything in mainline > > kernels which allows people to actually use this larger allocation. > > Apart from software mmap() and using panning to do flips, but I'm > > taking it as a given that people shipping Android on their devices > > aren't using software rendering. > > I think we need to make a distinction between fbdev the subsystem in the > kernel, and fbdev the uabi: > > - fbdev the subsystem is completely dead in upstream. I think we have full > agreement on that. > - fbdev the uabi isn't, and if we can get more users from fbdev based > drivers to kms/atomic drivers by adding fairly simple stuff like this, > I'm all for it. The real question, in my opinion, is how to get more users for the DRM/KMS userspace API, to help killing the fbdev API. What's the incentive for userspace to migrate if we tell them that we're going to support the fbdev API forever, and will even go through the trouble of extending the supported feature set ? I have a customer who wouldn't have migrated their userspace to DRM/KMS if these two patches had been merged a few years ago. I'd rather *reduce* the supported feature set over time until we can finally switch fbdev off. > Which means: Yes, I fully plan to merge this, it makes sense. It even > _helps_ by making fbdev-the-subsystem even deader. Making live hard for > out-of-tree folks or folks with shit userspace doesn't make sense, at > least if the only benefit for us is that we'll feel pure about our > intentions :-) -- Regards, Laurent Pinchart