From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Richard Weinberger <richard@nod.at>
Cc: rui.zhang@intel.com, eduardo.valentin@ti.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
horms@verge.net.au, laurent.pinchart+renesas@ideasonboard.com
Subject: Re: [PATCH 2/2] thermal,rcar_thermal: Add dependency on HAS_IOMEM
Date: Mon, 27 Jan 2014 00:30:37 +0100 [thread overview]
Message-ID: <1827069.1uKx343yy0@avalon> (raw)
In-Reply-To: <1390688954-4940-1-git-send-email-richard@nod.at>
Hi Richard,
Thank you for the patch.
On Saturday 25 January 2014 23:29:14 Richard Weinberger wrote:
> Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with
> COMPILE_TEST) broke build on archs wihout io memory.
>
> On archs like S390 or um this driver cannot build nor work.
> Make it depend on HAS_IOMEM to bypass build failures.
>
> drivers/thermal/rcar_thermal.c:404: undefined reference to
> `devm_ioremap_resource' drivers/thermal/rcar_thermal.c:426: undefined
> reference to `devm_ioremap_resource'
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> drivers/thermal/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 35c0664..88efa8f 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -136,6 +136,7 @@ config SPEAR_THERMAL
> config RCAR_THERMAL
> tristate "Renesas R-Car thermal driver"
> depends on ARCH_SHMOBILE || COMPILE_TEST
> + depends on HAS_IO_MEM
Shouldn't that be HAS_IOMEM ?
> help
> Enable this to plug the R-Car thermal sensor driver into the Linux
> thermal framework.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-01-26 23:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-25 22:29 [PATCH 2/2] thermal,rcar_thermal: Add dependency on HAS_IOMEM Richard Weinberger
2014-01-26 23:30 ` Laurent Pinchart [this message]
2014-01-26 23:34 ` Richard Weinberger
2014-02-27 6:58 ` Zhang Rui
2014-02-28 0:44 ` Kuninori Morimoto
2014-02-28 8:21 ` Richard Weinberger
2014-02-28 9:30 ` Kuninori Morimoto
2014-03-03 14:46 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1827069.1uKx343yy0@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=eduardo.valentin@ti.com \
--cc=horms@verge.net.au \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=richard@nod.at \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.