From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B53D1C282D7 for ; Wed, 30 Jan 2019 18:13:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 973E020870 for ; Wed, 30 Jan 2019 18:13:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732875AbfA3SNM (ORCPT ); Wed, 30 Jan 2019 13:13:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57876 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727473AbfA3SNM (ORCPT ); Wed, 30 Jan 2019 13:13:12 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6177DC719C; Wed, 30 Jan 2019 18:13:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4A3E8176C2; Wed, 30 Jan 2019 18:13:12 +0000 (UTC) Received: from zmail21.collab.prod.int.phx2.redhat.com (zmail21.collab.prod.int.phx2.redhat.com [10.5.83.24]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 32B6F18033A2; Wed, 30 Jan 2019 18:13:12 +0000 (UTC) Date: Wed, 30 Jan 2019 13:13:12 -0500 (EST) From: Vladis Dronov To: Sasha Levin Cc: Jiri Kosina , stable@vger.kernel.org Message-ID: <1827956174.68503350.1548871992137.JavaMail.zimbra@redhat.com> In-Reply-To: <20190130175202.GS3973@sasha-vm> References: <20190129105835.4723-1-vdronov@redhat.com> <20190130144646.2C96A218A4@mail.kernel.org> <20190130175202.GS3973@sasha-vm> Subject: Re: [PATCH v3] HID: debug: fix the ring buffer implementation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.5.180, 10.4.195.14] Thread-Topic: debug: fix the ring buffer implementation Thread-Index: Qp2m670rWxV4BlWixON5KL+hToQjFQ== X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 30 Jan 2019 18:13:12 +0000 (UTC) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hello, Sasha, all, > The reason for that mess is that on <=4.14 kernels, there is a > dependency on 6396bb22151 ("treewide: kzalloc() -> kcalloc()"), but > since that patch is a treewide change, to bring that in we need a big > pile of seemingly random patches from all over the tree, which is the > output you see. Indeed, this patch depends on 2 tree-wide patches, one being 6396bb22151 ("treewide: kzalloc() -> kcalloc()") as you've mentioned and another one is a9a08845e9ac ("vfs: do bulk POLL* -> EPOLL* replacement"). In the part of HID driver they basically do: #6396bb22151 - buf = kzalloc(sizeof(char) * HID_DEBUG_BUFSIZE, GFP_ATOMIC); + buf = kzalloc(HID_DEBUG_BUFSIZE, GFP_ATOMIC); - if (!(list->hid_debug_buf = kzalloc(sizeof(char) * HID_DEBUG_BUFSIZE, GFP_KERNEL))) { + if (!(list->hid_debug_buf = kzalloc(HID_DEBUG_BUFSIZE, GFP_KERNEL))) { #a9a08845e9ac - return POLLIN | POLLRDNORM; + return EPOLLIN | EPOLLRDNORM; - return POLLERR | POLLHUP; + return EPOLLERR | EPOLLHUP; Adding this 2 changes to the 4.14.y make HID patch to apply cleanly (except offsets). I suppose, I need to backport HID patch (adding these 2 changes above) and post to stable@. I will follow this process: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html In case I do smth wrong, please, tell. Best regards, Vladis Dronov | Red Hat, Inc. | Product Security | Senior Software Engineer