All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH 5/5] rte_sched: allow reading without clearing
Date: Fri, 10 Jul 2015 00:51:42 +0200	[thread overview]
Message-ID: <1830896.dtZQMEj4sb@xps13> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126323714E9@IRSMSX108.ger.corp.intel.com>

2015-06-04 17:48, Dumitrescu, Cristian:
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > The rte_sched statistics API should allow reading statistics without
> > clearing. Make auto-clear optional. In this version, this is handled
> > by deprecating the old API and adding a new one.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
[...]
> > --- a/lib/librte_sched/rte_sched_version.map
> > +++ b/lib/librte_sched/rte_sched_version.map
> > @@ -14,8 +14,10 @@ DPDK_2.0 {
> >  	rte_sched_port_enqueue;
> >  	rte_sched_port_free;
> >  	rte_sched_port_get_memory_footprint;
> > +	rte_sched_queue_stats;
> >  	rte_sched_queue_read_stats;
> >  	rte_sched_subport_config;
> > +	rte_sched_subport_stats;
> >  	rte_sched_subport_read_stats;
> >  	rte_sched_port_pkt_write;
> >  	rte_sched_port_pkt_read_tree_path;
> 
> If we plan to obsolete API function rte_sched_queue_read_stats() and have people use the new API function rte_sched_queue_stats(), we should replace every usage of the obsolete function with call to new function. We need to do this in examples/qos_sched and app/test.

Patchwork status is now "Changes requested".

      reply	other threads:[~2015-07-09 22:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27 18:10 [PATCH v4 0/5] rte_sched: cleanup and API enhancements Stephen Hemminger
2015-05-27 18:10 ` [PATCH 1/5] rte_sched: make RED optional at runtime Stephen Hemminger
2015-05-27 18:10 ` [PATCH 2/5] rte_sched: don't put tabs in log messages Stephen Hemminger
2015-05-27 18:10 ` [PATCH 3/5] rte_sched: use correct log level Stephen Hemminger
2015-05-27 18:10 ` [PATCH 4/5] rte_sched: hide structure of port hierarchy Stephen Hemminger
2015-05-27 18:10 ` [PATCH 5/5] rte_sched: allow reading without clearing Stephen Hemminger
2015-06-04 17:48   ` Dumitrescu, Cristian
2015-07-09 22:51     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1830896.dtZQMEj4sb@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.