From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42497)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bmjWB-0000vJ-DH
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 11:33:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bmjW7-0000sx-RW
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 11:33:03 -0400
Received: from mx3-phx2.redhat.com ([209.132.183.24]:56434)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bmjW7-0000sX-HU
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 11:32:59 -0400
Date: Wed, 21 Sep 2016 11:32:19 -0400 (EDT)
From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <mlureau@redhat.com>
Message-ID: <1831768399.481241.1474471939036.JavaMail.zimbra@redhat.com>
In-Reply-To: <878tulxp1r.fsf@dusky.pond.sub.org>
References: <20160921103629.6410-1-marcandre.lureau@redhat.com>
	<20160921103629.6410-4-marcandre.lureau@redhat.com>
	<878tulxp1r.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 3/3] iotests: fix expected error message
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org, berto@igalia.com

Hi

----- Original Message -----
> Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com> writes:
>=20
> > Missing argument returns a corresponding error message for all types
> > now.
> >
> > Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
> > ---
> >  tests/qemu-iotests/087.out | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/qemu-iotests/087.out b/tests/qemu-iotests/087.out
> > index a95c4b0..b213db2 100644
> > --- a/tests/qemu-iotests/087.out
> > +++ b/tests/qemu-iotests/087.out
> > @@ -60,7 +60,7 @@ Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D1=
34217728
> > encryption=3Don
> >  Testing: -S
> >  QMP_VERSION
> >  {"return": {}}
> > -{"error": {"class": "GenericError", "desc": "Invalid parameter type fo=
r
> > 'driver', expected: string"}}
> > +{"error": {"class": "GenericError", "desc": "Parameter 'driver' is
> > missing"}}
> >  {"return": {}}
> >  {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP},
> >  "event": "SHUTDOWN"}
>=20
> Did this regress in PATCH 1?

If you look at old monitor dispatch code, it does not return QERR_MISSING_P=
ARAMETER for structure members, but only top level arguments. I don't think=
 it's worth to keep that old error behaviour. I will update the commit mess=
age.=20