Re: 2.5.8-dj1 : arch/i386/kernel/smpboot.c error

["Martin J. Bligh" <Martin.Bligh@us.ibm.com>]

>>>> Even though clustered_apic_mode is 0, the compiler still complains
>>>> about the second one and the first one doesn't depend on
>>>> clustered_apic_mode at all.
>>>> 
>>> Hmmm ... not sure why the compiler complains about the second one,
>>> that's very strange ;-)
>>> 
>> 
>> I agree. The cpp ouput clealy shows
>> 
>>         if ((0) && (numnodes > 1)) {
>> 
>> so I'm not sure why there's a problem.
> 
> Is the thing generating the "(0)" a macro?  If so, then the rules

  #define clustered_apic_mode (0)

> of C and the "&&" operator say that "if the first is false, the
> second needn't even be evaluated".  

That's what I would have thought.
But I don't think it's the second part that causes the warning,
it's the thing *inside* the if clause.

> Could that be what's causing the warning?

To my mind, that's why we should *not* be getting a warning ?

M.