From: Thomas Monjalon <thomas@monjalon.net>
To: Tal Shnaiderman <talshn@nvidia.com>
Cc: dev@dpdk.org, matan@nvidia.com, rasland@nvidia.com,
asafp@nvidia.com, wisamm@nvidia.com, stable@dpdk.org,
ferruh.yigit@intel.com, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions
Date: Mon, 12 Apr 2021 17:28:55 +0200 [thread overview]
Message-ID: <1831781.UOzqvqydHp@thomas> (raw)
In-Reply-To: <20210411122136.2560-1-talshn@nvidia.com>
11/04/2021 14:21, Tal Shnaiderman:
> Several functions introduced in the addition of the Windows support to
> mlx5 were missing the __rte_internal tag although being exported.
>
> Fixes: 1552fb287166 ("common/mlx5: add alloc/dealloc PD on Windows")
> Fixes: 1969ee424405 ("common/mlx5: add UMEM reg/dereg functions on Windows")
> Fixes: ba420719823c ("common/mlx5: add reg/dereg MR on Windows")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
It is fixing Linux debug build (note: should be added to CI).
Applied in main tree with this message, thanks:
common/mlx5: add missing internal tags
Several functions introduced in the addition of the Windows support
to mlx5 were missing the __rte_internal tag.
This miss is better revealed when symbols became exported on Linux too,
and it is caught by the symbol checker with --buildtype=debug.
Fixes: 1552fb287166 ("common/mlx5: add alloc/dealloc PD on Windows")
Fixes: 1969ee424405 ("common/mlx5: add UMEM reg/dereg functions on Windows")
Fixes: ba420719823c ("common/mlx5: add reg/dereg MR on Windows")
Fixes: 56ea803e878e ("build: remove Windows export symbol list")
Cc: stable@dpdk.org
Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
prev parent reply other threads:[~2021-04-12 15:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-11 12:21 [dpdk-dev] [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions Tal Shnaiderman
2021-04-11 13:00 ` Matan Azrad
2021-04-11 13:09 ` Wisam Monther
2021-04-12 11:25 ` Raslan Darawsheh
2021-04-12 12:26 ` Thomas Monjalon
2021-04-12 12:30 ` Raslan Darawsheh
2021-04-12 12:59 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-04-12 13:06 ` Thomas Monjalon
2021-04-12 13:35 ` Ferruh Yigit
2021-04-12 13:54 ` David Marchand
2021-04-12 15:00 ` Tal Shnaiderman
2021-04-12 15:12 ` Ferruh Yigit
2021-04-12 15:28 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1831781.UOzqvqydHp@thomas \
--to=thomas@monjalon.net \
--cc=asafp@nvidia.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=talshn@nvidia.com \
--cc=wisamm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.