From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752267AbcGYGvR (ORCPT ); Mon, 25 Jul 2016 02:51:17 -0400 Received: from mx2.suse.de ([195.135.220.15]:50921 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993AbcGYGvH convert rfc822-to-8bit (ORCPT ); Mon, 25 Jul 2016 02:51:07 -0400 From: Michal Kubecek To: Florian Westphal Cc: Jiri Slaby , Greg KH , Jiri Slaby , stable@vger.kernel.org, linux-kernel@vger.kernel.org, Pablo Neira Ayuso Subject: Re: [PATCH 3.12 28/88] netfilter: x_tables: validate targets of jumps Date: Mon, 25 Jul 2016 08:51:03 +0200 Message-ID: <1832770.sPqPiaF7Fe@alaris> Organization: SuSE User-Agent: KMail/5.2.2 (Linux/4.7.0-rc7-2.g152f160-default; KDE/5.24.0; x86_64; ; ) In-Reply-To: <20160725064122.GB15307@breakpoint.cc> References: <3d4036cb9b963cdd270c02856a888183da0623db.1468483951.git.jslaby@suse.cz> <20160725054525.GA8749@unicorn.suse.cz> <20160725064122.GB15307@breakpoint.cc> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-2" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On pondìlí 25. èervence 2016 8:41 Florian Westphal wrote: > Michal Kubecek wrote: > > On Thu, Jul 21, 2016 at 09:00:33PM +0200, Jiri Slaby wrote: > > > On 07/21/2016, 08:56 PM, Greg KH wrote: > > > > On Thu, Jul 21, 2016 at 08:36:18AM +0200, Jiri Slaby wrote: > > > >> On 07/14/2016, 10:15 AM, Jiri Slaby wrote: > > > >>> From: Florian Westphal > > > >>> > > > >>> 3.12-stable review patch. If anyone has any objections, > > > >>> please let me know. > > > >>> > > > >>> =============== > > > >>> > > > >>> commit 36472341017529e2b12573093cc0f68719300997 upstream. > > > >> > > > >> I am now dropping this one. 3.12.62 will be released without > > > >> that patch. After the performance issue is resolved, it will > > > >> be requeued.> > > > > > > Personally, I think the bug fixes were more important than the > > > > performance issues at this point in time, but it's your call to > > > > make :)> > > > > Ok, but to quote [1]: > > > iptables-restore will take forever (gave up after 10 minutes) > > > > > > I would say it proved itself not to be a performance issue, but > > > rather a functional issue :). Both Pablo and Florian suggested to > > > postpone the patch.> > > Even worse: because of a shared lock which is held for all this > > time, > > this allows (on kernel >= 3.8) an unprivileged user to block similar > > operation in all network namespaces including init_net. > > What lock are you talking about? > > The table lock is aquired after the sanity/translation pass. I meant xt_compat_lock(AF_INET) (or AF_INET6 or NFPROTO_ARP) which is held for almost all of translate_compat_table(). Michal Kubecek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:50921 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993AbcGYGvH convert rfc822-to-8bit (ORCPT ); Mon, 25 Jul 2016 02:51:07 -0400 From: Michal Kubecek To: Florian Westphal Cc: Jiri Slaby , Greg KH , Jiri Slaby , stable@vger.kernel.org, linux-kernel@vger.kernel.org, Pablo Neira Ayuso Subject: Re: [PATCH 3.12 28/88] netfilter: x_tables: validate targets of jumps Date: Mon, 25 Jul 2016 08:51:03 +0200 Message-ID: <1832770.sPqPiaF7Fe@alaris> In-Reply-To: <20160725064122.GB15307@breakpoint.cc> References: <3d4036cb9b963cdd270c02856a888183da0623db.1468483951.git.jslaby@suse.cz> <20160725054525.GA8749@unicorn.suse.cz> <20160725064122.GB15307@breakpoint.cc> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-2" Sender: stable-owner@vger.kernel.org List-ID: On pond�l� 25. �ervence 2016 8:41 Florian Westphal wrote: > Michal Kubecek wrote: > > On Thu, Jul 21, 2016 at 09:00:33PM +0200, Jiri Slaby wrote: > > > On 07/21/2016, 08:56 PM, Greg KH wrote: > > > > On Thu, Jul 21, 2016 at 08:36:18AM +0200, Jiri Slaby wrote: > > > >> On 07/14/2016, 10:15 AM, Jiri Slaby wrote: > > > >>> From: Florian Westphal > > > >>> > > > >>> 3.12-stable review patch. If anyone has any objections, > > > >>> please let me know. > > > >>> > > > >>> =============== > > > >>> > > > >>> commit 36472341017529e2b12573093cc0f68719300997 upstream. > > > >> > > > >> I am now dropping this one. 3.12.62 will be released without > > > >> that patch. After the performance issue is resolved, it will > > > >> be requeued.> > > > > > > Personally, I think the bug fixes were more important than the > > > > performance issues at this point in time, but it's your call to > > > > make :)> > > > > Ok, but to quote [1]: > > > iptables-restore will take forever (gave up after 10 minutes) > > > > > > I would say it proved itself not to be a performance issue, but > > > rather a functional issue :). Both Pablo and Florian suggested to > > > postpone the patch.> > > Even worse: because of a shared lock which is held for all this > > time, > > this allows (on kernel >= 3.8) an unprivileged user to block similar > > operation in all network namespaces including init_net. > > What lock are you talking about? > > The table lock is aquired after the sanity/translation pass. I meant xt_compat_lock(AF_INET) (or AF_INET6 or NFPROTO_ARP) which is held for almost all of translate_compat_table(). Michal Kubecek