From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] net/sfc: enable TSO by default
Date: Fri, 20 Jan 2017 15:29:25 +0100
Message-ID: <18339814.hMek8iyv21@xps13>
References: <1484841140-24117-1-git-send-email-arybchenko@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, ferruh.yigit@intel.com
To: Andrew Rybchenko <arybchenko@solarflare.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id DFE2F37B1
 for <dev@dpdk.org>; Fri, 20 Jan 2017 15:29:26 +0100 (CET)
Received: by mail-wm0-f49.google.com with SMTP id c85so39307076wmi.1
 for <dev@dpdk.org>; Fri, 20 Jan 2017 06:29:26 -0800 (PST)
In-Reply-To: <1484841140-24117-1-git-send-email-arybchenko@solarflare.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-01-19 15:52, Andrew Rybchenko:
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> It is a mistake that TSO support is compiled out by default.
> We would be happy to enable it by deafult, but strictly speaking
> it is not a bug fix.
> 
> Arguments to enable are:
>  - be more feature-rich (and user-friendly) in default config
>  - the most of internal testing is done with TSO enabled
> 
>  config/common_base | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/common_base b/config/common_base
> index b9fb8e2..134e9b9 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -261,7 +261,7 @@ CONFIG_RTE_LIBRTE_BNXT_PMD=y
>  #
>  CONFIG_RTE_LIBRTE_SFC_EFX_PMD=y
>  CONFIG_RTE_LIBRTE_SFC_EFX_DEBUG=n
> -CONFIG_RTE_LIBRTE_SFC_EFX_TSO=n
> +CONFIG_RTE_LIBRTE_SFC_EFX_TSO=y

There should not be such option in the build-time configuration.
Why keeping it (even enabled by default)?