From: Thomas Monjalon <thomas@monjalon.net>
To: Yunjian Wang <wangyunjian@huawei.com>
Cc: dev@dpdk.org, matan@nvidia.com, shahafs@nvidia.com,
viacheslavo@nvidia.com, dingxiaoxiong@huawei.com,
stable@dpdk.org, xuemingl@nvidia.com, asafp@nvidia.com
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix use after free in mlx5_dma_unmap
Date: Thu, 22 Jul 2021 16:10:28 +0200 [thread overview]
Message-ID: <1834160.FsaEv4fRmD@thomas> (raw)
In-Reply-To: <cdb08954493d44155cf04fd813cfd3a41255bd4c.1625909056.git.wangyunjian@huawei.com>
10/07/2021 12:35, wangyunjian:
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> This patch fixes the use-after-free bug which was reported by Coverity
> Scan in the mlx5_dma_unmap function.
>
> Coverity issue: 371679
> Fixes: 992e6df3dafe ("common/mlx5: free MR resource on device DMA unmap")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> LIST_REMOVE(mr, mr);
> - mlx5_mr_free(mr, sh->share_cache.dereg_mr_cb);
> DRV_LOG(DEBUG, "port %u remove MR(%p) from list", dev->data->port_id,
> (void *)mr);
> + mlx5_mr_free(mr, sh->share_cache.dereg_mr_cb);
> mlx5_mr_rebuild_cache(&sh->share_cache);
Sorry, it seems this fix has been integrated as part of this patch
(for no good reason):
https://git.dpdk.org/dpdk/commit/?id=a7f34989e9
prev parent reply other threads:[~2021-07-22 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-10 10:35 [dpdk-dev] [PATCH] net/mlx5: fix use after free in mlx5_dma_unmap wangyunjian
2021-07-22 14:10 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1834160.FsaEv4fRmD@thomas \
--to=thomas@monjalon.net \
--cc=asafp@nvidia.com \
--cc=dev@dpdk.org \
--cc=dingxiaoxiong@huawei.com \
--cc=matan@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
--cc=wangyunjian@huawei.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.