From: Thomas Monjalon <thomas@monjalon.net>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, "Eads, Gage" <gage.eads@intel.com>,
"santosh.shukla@caviumnetworks.com"
<santosh.shukla@caviumnetworks.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH 0/3] mk: fix LDLIBS
Date: Tue, 24 Oct 2017 02:15:49 +0200 [thread overview]
Message-ID: <1835343.c7Vqvf7JSF@xps> (raw)
In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E1400B993@FMSMSX108.amr.corp.intel.com>
23/10/2017 16:39, Eads, Gage:
> From: Olivier Matz [mailto:olivier.matz@6wind.com]
> >
> > Some libraries in LDLIBS are currently generated from the
> > DEPDIRS-$(dirname) variables in the Makefiles. This is valid when the
> > subdirectory name match the library name, but it's not always the case,
> > especially for PMDs.
> >
> > This series fixes some invalid dependency declarations first, and then removes
> > the automatic generation of libraries from the directory names. Instead, the
> > libraries are explicitly added in each Makefile.
>
> These three patches look good. I tested it on the contrived example from my original email, and this appears to fix the issue.
>
> Once the third patch's apply issues are resolved (http://dpdk.org/ml/archives/test-report/2017-October/032631.html):
> Reviewed-by: Gage Eads <gage.eads@intel.com>
Fixed some conflicts due to new PMDs and octeontx dependencies changes.
Fixed some misses in patch 3 as explained in prior message.
Applied with some fixes, thanks
prev parent reply other threads:[~2017-10-24 0:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 20:48 Inter-PMD dependencies when building shared libraries Eads, Gage
2017-10-05 12:12 ` Olivier MATZ
2017-10-05 12:32 ` Thomas Monjalon
2017-10-05 12:50 ` Bruce Richardson
2017-10-12 16:04 ` [PATCH 0/3] mk: fix LDLIBS Olivier Matz
2017-10-12 16:04 ` [PATCH 1/3] crypto/dpaa2_sec: remove uneffective dependency Olivier Matz
2017-10-12 16:04 ` [PATCH 2/3] mempool/octeontx: fix dependency Olivier Matz
2017-10-12 16:04 ` [PATCH 3/3] mk: do not generate LDLIBS from directory dependencies Olivier Matz
2017-10-24 0:11 ` Thomas Monjalon
2017-10-23 14:39 ` [PATCH 0/3] mk: fix LDLIBS Eads, Gage
2017-10-24 0:15 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1835343.c7Vqvf7JSF@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=olivier.matz@6wind.com \
--cc=santosh.shukla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.