All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3 1/2] rte_mbuf: fix strncpy warnings
Date: Wed, 04 Apr 2018 17:35:42 +0200	[thread overview]
Message-ID: <1836809.Bf90Dp1qdv@xps> (raw)
In-Reply-To: <20180329170531.2478-2-stephen@networkplumber.org>

29/03/2018 19:05, Stephen Hemminger:
> Gcc-8 discovers issue with platform_mempool_ops.
> rte_mbuf_pool_ops.c:26:3: error: ‘strncpy’ output truncated before
>   terminating nul copying as many bytes from a string as its length
>   [-Werror=stringop-truncation]
>   strncpy(mz->addr, ops_name,  strlen(ops_name));
> 
> Since the ops_name is already checked for size, using strncpy
> here is unnecessary; just use strcpy.
> 
> Fixes: a3acc3144a76 ("mbuf: add pool ops selection functions")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Applied, thanks

  reply	other threads:[~2018-04-04 15:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29 17:05 [PATCH v3 0/2] gcc-8 build fixes Stephen Hemminger
2018-03-29 17:05 ` [PATCH v3 1/2] rte_mbuf: fix strncpy warnings Stephen Hemminger
2018-04-04 15:35   ` Thomas Monjalon [this message]
2018-03-29 17:05 ` [PATCH v3 2/2] rte_metrics: fix strncpy truncation warning Stephen Hemminger
2018-04-04 14:33   ` Thomas Monjalon
2018-04-03  9:23 ` [PATCH v3 0/2] gcc-8 build fixes Ferruh Yigit
2018-04-03 15:10   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1836809.Bf90Dp1qdv@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.