From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Matt W. Benjamin" Subject: wip-claim-3: Re: wip-claim-2 Date: Tue, 9 Dec 2014 11:49:13 -0500 (EST) Message-ID: <1838912097.137.1418143753679.JavaMail.root@thunderbeast.private.linuxbox.com> References: Reply-To: "Matt W. Benjamin" Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from aa.linuxbox.com ([69.128.83.226]:2604 "EHLO aa.linuxbox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757651AbaLIQtV (ORCPT ); Tue, 9 Dec 2014 11:49:21 -0500 In-Reply-To: Sender: ceph-devel-owner@vger.kernel.org List-ID: To: Sage Weil Cc: ceph-devel Pushed wip-claim-3, which makes the changes you requested in IRC, plus adds a unittest block. Matt ----- "Sage Weil" wrote: > On Mon, 8 Dec 2014, Matt W. Benjamin wrote: > > Hi devs, > > > > We've created a new branch wip-claim-2, and new pull request > https://github.com/linuxbox2/linuxbox-ceph/pull/3 > > based on review feedback. > > > > The big change is to replace "volatile" with "sharable", and replace > "strong_claim()" with "clone_nonsharable()." > > This may not be perfect, feedback appreciated. It does remove the > overloading of "claim()", which people found > > confusing. > > I made a few comments, but overall it looks okay to me. Can you make > the > next pull request against the github.com/ceph/ceph repo instead of > your > clone? > > https://github.com/ceph/ceph/compare > > Thanks! > sage -- Matt Benjamin CohortFS, LLC. 315 West Huron Street, Suite 140A Ann Arbor, Michigan 48103 http://cohortfs.com tel. 734-761-4689 fax. 734-769-8938 cel. 734-216-5309