From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98154C2D0CD for ; Sat, 17 May 2025 09:54:12 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [45.14.194.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2B6B2601B5; Sat, 17 May 2025 11:53:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2B6B2601B5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1747475646; bh=l07Rdut/5Q1ajNjTbDDJqZU0MtC0gl+fTRyC7i4vU9M=; h=From:To:In-Reply-To:References:Subject:Date:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From; b=U5rFwysW9z1QMQZXL560md9qs4YhftnW0xftu8+nYBYqOx5EihksdaAl+GWcTCdb9 /BW0IXYg19j3SeXT8ykWwFhM5Irrhr84csx6yQHqBuqlSODbByXzsZsVC5UqaobA1Y kyQET7JxXb6M6Oi+4Qo2awJJFjQdV28fo7B1cd4Y= Received: by alsa1.perex.cz (Postfix, from userid 50401) id EF94CF80551; Sat, 17 May 2025 11:53:31 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id B345EF80518; Sat, 17 May 2025 11:53:31 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0CA70F8027B; Sat, 17 May 2025 11:53:28 +0200 (CEST) Received: from webhooks-bot.alsa-project.org (vmi2259423.contaboserver.net [45.14.194.44]) by alsa1.perex.cz (Postfix) with ESMTP id 52BF9F80016 for ; Sat, 17 May 2025 11:53:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 52BF9F80016 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit From: GitHub issues - opened To: alsa-devel@alsa-project.org Message-Id: <184047ce0ad2f400-webhooks-bot@alsa-project.org> In-Reply-To: <184047ce0acdbd00-webhooks-bot@alsa-project.org> References: <184047ce0acdbd00-webhooks-bot@alsa-project.org> Subject: New include guard in seq_event.h breaks DSSI header Date: Sat, 17 May 2025 11:53:28 +0200 (CEST) Message-ID-Hash: UXWZF3BHTIVQXZ2UZBJ3XJUZZX3UZXHC X-Message-ID-Hash: UXWZF3BHTIVQXZ2UZBJ3XJUZZX3UZXHC X-MailFrom: github@alsa-project.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: alsa-project/alsa-lib issue #455 was opened from cannam: Hello! I am one of the original authors of [DSSI](https://dssi.sourceforge.net/), a soft-synth API that was created about 20 years ago. It's not an active project, it was basically "done" by about 2011 but is still used in a number of applications. The DSSI header `dssi.h` includes `` in order to pick up a structure for MIDI-like events. I see that following a report of breakage in #431, a guard was added to seq_event.h in ea8972c to warn against including that header directly. The official fix seems to be to include the whole of ``, and that is what packagers appear to be patching the DSSI header with currently (and I see it is also what the guard does itself after emitting the warning). Unfortunately from the perspective of DSSI as an API, that isn't really a fix at all because all we need is an event structure - there is no other dependency on ALSA as a library and there was never any intention to require linking with ALSA. Probably the historical error was to use an ALSA header at all, and the best option for us might be to duplicate enough of the contents of `seq_event.h` locally to sever the dependency that way. But I thought I should first check whether you can suggest a better approach, for example whether you might be open to making it possible (again) to make use of `seq_event.h` specifically without pulling in a dependency on everything else in ALSA. Thank you! Issue URL : https://github.com/alsa-project/alsa-lib/issues/455 Repository URL: https://github.com/alsa-project/alsa-lib