From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54F89C2D0CD for ; Sat, 17 May 2025 13:30:12 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [45.14.194.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 61A52601B3; Sat, 17 May 2025 15:29:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 61A52601B3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1747488609; bh=NvTjTHElCOYLryzgHtXlBheJ3iNYqFbKKYnNlSzHEZA=; h=From:To:In-Reply-To:References:Subject:Date:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From; b=fpJm58mw/2cw2HoukPr86r2jT0VvSeFDssWg8w4FZe5RX4Wcu/vnX2qPKXt8HgHNS hVH1EqgXxPIX8oyjqEwEo8E1fXW33ARwERwxWoNdZUrD76ok+RbkDHTcgGNictP97e uZQB5HJaRVVNr9DgbyZ1J1t53GX4CP5odQAgfu4I= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 93E87F80528; Sat, 17 May 2025 15:29:36 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 712E9F80272; Sat, 17 May 2025 15:29:36 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A1DB4F8027B; Sat, 17 May 2025 15:29:33 +0200 (CEST) Received: from webhooks-bot.alsa-project.org (vmi2259423.contaboserver.net [45.14.194.44]) by alsa1.perex.cz (Postfix) with ESMTP id C9A65F80134 for ; Sat, 17 May 2025 15:29:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C9A65F80134 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit From: GitHub issues - edited To: alsa-devel@alsa-project.org Message-Id: <18405398c358ce00-webhooks-bot@alsa-project.org> In-Reply-To: <18405398c351bd00-webhooks-bot@alsa-project.org> References: <18405398c351bd00-webhooks-bot@alsa-project.org> Subject: New include guard in seq_event.h breaks DSSI header Date: Sat, 17 May 2025 15:29:33 +0200 (CEST) Message-ID-Hash: Y62XUULPBM7ZW4ZHMLPKXNXMSSZ2EWOI X-Message-ID-Hash: Y62XUULPBM7ZW4ZHMLPKXNXMSSZ2EWOI X-MailFrom: github@alsa-project.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: alsa-project/alsa-lib issue #455 was edited from cannam: Hello! I am one of the original authors of [DSSI](https://dssi.sourceforge.net/), a soft-synth API that was created about 20 years ago. It's not an active project, it was basically "done" by about 2011 but is still used in a number of applications. The DSSI header `dssi.h` includes `` in order to pick up a structure for MIDI-like events. I see that following a report of breakage in #431, a guard was added to seq_event.h in ea8972c to warn against including that header directly. This of course breaks for packagers using `-Werror` builds and the like. The official fix seems to be to include the whole of ``, and that is what packagers appear to be patching the DSSI header with currently (and I see it is also what the guard does itself after emitting the warning). Unfortunately from the perspective of DSSI as an API, that isn't really a fix at all because all we need is an event structure - there is no other dependency on ALSA as a library and there was never any intention to require linking with ALSA. Probably the historical error was to use an ALSA header at all, and the best option for us might be to duplicate enough of the contents of `seq_event.h` locally to sever the dependency that way. But that would be a significant intervention at this point - I think it would be the first substantive change to `dssi.h` since 2004 so I am wary of the risks in terms of breaking other things. I thought I should first check whether you can suggest a better approach, for example whether you might be open to making it possible (again) to make use of `seq_event.h` specifically without pulling in a dependency on everything else in ALSA. Thank you! Issue URL : https://github.com/alsa-project/alsa-lib/issues/455 Repository URL: https://github.com/alsa-project/alsa-lib