From: Thomas Monjalon <thomas@monjalon.net>
To: Akhil Goyal <akhil.goyal@nxp.com>,
Liron Himi <lironh@marvell.com>,
Fan Zhang <roy.fan.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] crypto/mvsam: fix missed code change for mvsam
Date: Mon, 08 Jul 2019 17:22:36 +0200 [thread overview]
Message-ID: <18406135.oEg8MpVtrz@xps> (raw)
In-Reply-To: <4113530.0QG5j2eBUe@xps>
08/07/2019 12:26, Thomas Monjalon:
> 07/07/2019 07:41, Liron Himi:
> > From: Akhil Goyal <akhil.goyal@nxp.com>
> > > This patch fixes the missed "uint8_t *" to "const uint8_t *" xform key
> > > data type change for mvsam driver.
> > >
> > > Fixes: f3390532cf6a ("cryptodev: make xform key pointer constant")
> > >
> > > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> > > ---
> > Based on Fan's comments
> >
> > acked-by: Liron Himi <lironh@marvell.com>
>
> So we are OK to merge this patch with
> "cryptodev: make xform key pointer constant"
> in next-crypto tree?
There is still a compilation error:
drivers/crypto/mvsam/rte_mrvl_pmd.c:267:41: error:
incompatible type for argument 2 of 'memcpy'
memcpy(cipher_key, cipher_xform->cipher.key,
~~~~~~~~~~~~~~~~~~~~^~~~
Seen when compiling arm64-thunderx-linux-gcc
next prev parent reply other threads:[~2019-07-08 15:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 13:23 [dpdk-dev] [PATCH] crypto/mvsam: fix missed code change for mvsam Fan Zhang
2019-07-05 13:28 ` Akhil Goyal
2019-07-05 13:57 ` Zhang, Roy Fan
2019-07-05 13:31 ` Akhil Goyal
2019-07-07 5:41 ` Liron Himi
2019-07-08 10:26 ` Thomas Monjalon
2019-07-08 10:31 ` Akhil Goyal
2019-07-08 15:22 ` Thomas Monjalon [this message]
2019-07-12 6:31 ` Akhil Goyal
2019-07-15 12:45 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18406135.oEg8MpVtrz@xps \
--to=thomas@monjalon.net \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=lironh@marvell.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.