From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] ethernet api: Document rte_eth_vmdq_rx_conf Date: Sun, 09 Jul 2017 22:22:50 +0200 Message-ID: <1841065.2mqPad39Ri@xps> References: <20170705135944.20655-1-tom.barbette@ulg.ac.be> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Mcnamara, John" To: Tom Barbette Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 17AA62BBE for ; Sun, 9 Jul 2017 22:22:51 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/07/2017 10:29, Mcnamara, John: > From: Tom Barbette [mailto:tom.barbette@ulg.ac.be] > > > > From documentation it is very unclear how VMDq configuration can be > > tweaked, and online search offer very poor results. > > > > This patch will ultimately spawn an online documentation page for the > > rte_eth_vmdq_rx_conf struct which will eventually add a bit of > > documentation about the rx_mode tag and how to allow e.g. VMDq pools to > > receive packets without VLAN tags. > > > > Signed-off-by: Tom Barbette > > Hi Tom, > > Thanks for that. One minor, non-blocking, thing for future reference. The > subject line should be lowercase apart from acronyms. The maintainer > should be able to make that change when then apply the patch. This is just > for future reference. New title: ethdev: document VMDq Rx configuration > If there is any other missing documentation that you would care to add > then please do. :-) > > Acked-by: John McNamara Applied, thanks