From: Steve Grubb <sgrubb@redhat.com>
To: linux-audit@redhat.com
Subject: Re: Where can I find coding style guidelines for the Linux Audit framework source code?
Date: Wed, 17 Aug 2016 09:23:33 -0400 [thread overview]
Message-ID: <1844559.dnvzoz3xS3@x2> (raw)
In-Reply-To: <F5C3EECE-4B0F-472E-B1F5-BDCAA10B06C2@FreeBSD.org>
On Wednesday, August 17, 2016 3:02:36 PM EDT Mateusz Piotrowski wrote:
> I wonder if there is a document describing the preferred coding style
> of the Linux Audit framework source code.
No.
> Is it basically the style of the Linux Kernel[1]?
I have never used the kernel style. But if you look at the code, its fairly
consistent - except that there are a whole lot of contributors over time. Not
everyone followed the style exactly. I try to correct it over time. The main
thing I hate is lines that are over 80 characters long or when a patch uses
spaces and not tabs.
> Secondly, does it make sense to submit patches which fix style only?
I don't like to have a lot of code churn just for style. I tend to fix style
either on patch submission. Or if its big or I don't have time, I fix it when
I'm in that area.
-Steve
> [1]: https://www.kernel.org/doc/Documentation/CodingStyle
>
> --
> Linux-audit mailing list
> Linux-audit@redhat.com
> https://www.redhat.com/mailman/listinfo/linux-audit
prev parent reply other threads:[~2016-08-17 13:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 13:02 Where can I find coding style guidelines for the Linux Audit framework source code? Mateusz Piotrowski
2016-08-17 13:23 ` Steve Grubb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1844559.dnvzoz3xS3@x2 \
--to=sgrubb@redhat.com \
--cc=linux-audit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.