From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADD6F606A324 for ; Fri, 30 Oct 2026 17:44:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=QONaqL+R; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=U9kWFnfC DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=kKwPyqtbBFcySqlOBVa45kjjBvWczA7WIz05LlPbbuQ=; b=QONaqL+REkeVkSEV1FM4UO610E Obho15NLYM38dWklalG7p6zp/WfJMvMLmQzX8y4qavrmVJEdxUU9NF51o7ThlWUboLb806e4WfSPw NAXZH9tW/kjGCwGGNQboEv/UdFzbpywUrPIjb8f6RPgfPp1JKdvHDNQGsGVwVRx+hHRtolFLuk90T jQ1ew8T9BelGvdLycjkMvUAKGI/oTNWgFkXfcMmmOiGtNV3H0kSHQqToH03Zdyl1Y24hdJLNRs2zE 6cTvDNkQXF0nLpwmF2gXf22j/VPaOD16PfPT+ywd9xmjLrOUeONKZik6x/zUbogfRG6Gyr/9M/X3c I6VmlBBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMqeL-0000000CGdy-0WPV; Fri, 30 Oct 2026 17:44:21 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMqeI-0000000CGdI-1mOX; Fri, 30 Oct 2026 17:44:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=usSQk3gmkVPvTdjKUU6vUCEb73RASrZuENLTQo/CskA=; b=U9kWFnfC3oQMbgDNWHcOQJ/NJT HfgLlU43wb+0bVziHK6qseWoW1WMNY9f8Yajz9bGzugJq2zGqk+5Zl/V7gMxjMMyR2ibJg2DM/cKq mFzfarqU1oKC/MKLL6HJdfJrlr9ls7aCcDDFy74PBnwrJJomtlNsDXUz13oWND07rvw4PsnCH04QP aYc/Td6PEoaEgs9zzYMyNlzWqaiAeywaleFvaOvv0NUvxO68TRI9g5PexamYMQFGhtIA9nmouBK2A hlhLO7I37xAuZou/gPdDekGMLTi100S6UetXWliTUUnG1AXLWeo3vVV6iXXbak+pKHorNBooaP+i1 QmeOqqOg==; From: Heiko Stuebner To: Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Philipp Zabel , Emil Renner Berthing , Hal Feng , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Dominique Belhachemi , Andy Yan , David Airlie , Simona Vetter , Yakir Yang , Dmitry Baryshkov , Michal Wilczynski , Conor Dooley , William Qiu , Xingyu Wu , Sandy Huang , Manivannan Sadhasivam , Michal Wilczynski Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, Marek Szyprowski , Maud Spierings , Graham Markall , Icenowy Zheng , Chaoyi Chen , Joshua Peisach , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Subject: Re: [PATCH v6 02/18] drm/bridge: inno-hdmi: Don't dereference a NULL drm_device on hotplug Date: Fri, 30 Oct 2026 18:43:47 +0100 Message-ID: <1844578.vCJZsxu672@phil> In-Reply-To: <20261029-jh7110-clean-send-v6-2-759594e43acf@samsung.com> References: <20261029-jh7110-clean-send-v6-0-759594e43acf@samsung.com> <20261029-jh7110-clean-send-v6-2-759594e43acf@samsung.com> X-Archived-By: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261030_104418_464062_EB3C8964 X-CRM114-Status: GOOD ( 20.47 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 QW0gRG9ubmVyc3RhZywgMjkuIE9rdG9iZXIgMjAyNiwgMDg6NTM6MzYgTWl0dGVsZXVyb3DDpGlz Y2hlIE5vcm1hbHplaXQgc2NocmllYiBNaWNoYWwgV2lsY3p5bnNraToKPiBpbm5vX2hkbWlfaXJx KCkgcGFzc2VzIGhkbWktPmJyaWRnZS5kZXYgdG8gZHJtX2hlbHBlcl9ocGRfaXJxX2V2ZW50KCks Cj4gd2hpY2ggZGVyZWZlcmVuY2VzIGl0IGluIGl0cyBmaXJzdCBzdGF0ZW1lbnQ6Cj4gCj4gCWlm ICghZGV2LT5tb2RlX2NvbmZpZy5wb2xsX2VuYWJsZWQpCj4gCj4gYnJpZGdlLmRldiBpcyBhc3Np Z25lZCBvbmx5IGJ5IGRybV9icmlkZ2VfYXR0YWNoKCksIGJ1dCBpbm5vX2hkbWlfYmluZCgpCj4g dW5tdXRlcyB0aGUgaG90cGx1ZyBpbnRlcnJ1cHQgaW4gaW5ub19oZG1pX2luaXRfaHcoKSBhbmQg aW5zdGFsbHMgdGhlCj4gaGFuZGxlciB3ZWxsIGJlZm9yZSBpdCBhdHRhY2hlcyB0aGUgYnJpZGdl Ogo+IAo+IAlpbm5vX2hkbWlfaW5pdF9odyhoZG1pKTsJCS8qIHVubXV0ZXMgaG90cGx1ZyAqLwo+ IAlkZXZtX3JlcXVlc3RfdGhyZWFkZWRfaXJxKC4uLik7CQkvKiBoYW5kbGVyIGdvZXMgbGl2ZSAq Lwo+IAkuLi4KPiAJaGRtaS0+YnJpZGdlLmRkYyA9IGlubm9faGRtaV9pMmNfYWRhcHRlcihoZG1p KTsKPiAJZGV2bV9kcm1fYnJpZGdlX2FkZChkZXYsICZoZG1pLT5icmlkZ2UpOwo+IAlkcm1fYnJp ZGdlX2F0dGFjaCguLi4pOwkJCS8qIGJyaWRnZS5kZXYgc2V0IGhlcmUgKi8KPiAKPiBUaGUgYnJp ZGdlIGlzIGFsbG9jYXRlZCBieSBkZXZtX2RybV9icmlkZ2VfYWxsb2MoKSwgd2hpY2gga3phbGxv YygpcyBpdCwKPiBzbyBicmlkZ2UuZGV2IGlzIE5VTEwgZm9yIGFsbCBvZiB0aGF0IHdpbmRvdywg YW5kIGEgaG90cGx1ZyBldmVudAo+IGFycml2aW5nIGluIGl0IGVudGVycyBkcm1faGVscGVyX2hw ZF9pcnFfZXZlbnQoTlVMTCkuCj4gCj4gQmVmb3JlIHRoZSBjb252ZXJzaW9uIHRvIGEgYnJpZGdl IHRoZSBvcmRlcmluZyB3YXMgc2FmZToKPiBpbm5vX2hkbWlfcmVnaXN0ZXIoKSBjYWxsZWQgZHJt bV9jb25uZWN0b3JfaGRtaV9pbml0KCksIHdoaWNoIHNldAo+IGNvbm5lY3Rvci5kZXYsIGJlZm9y ZSB0aGUgaW50ZXJydXB0IHdhcyByZXF1ZXN0ZWQuCj4gCj4gRHJvcCBob3RwbHVnIGV2ZW50cyB0 aGF0IGFycml2ZSBiZWZvcmUgdGhlIGJyaWRnZSBpcyBhdHRhY2hlZC4KPiAKPiBGaXhlczogOTY5 MzI1YTI1OTdlICgiZHJtL3JvY2tjaGlwOiBpbm5vLWhkbWk6IENvbnZlcnQgdG8gZHJtIGJyaWRn ZSIpCj4gU2lnbmVkLW9mZi1ieTogTWljaGFsIFdpbGN6eW5za2kgPG0ud2lsY3p5bnNraUBzYW1z dW5nLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9pbm5vLWhkbWkuYyB8IDgg KysrKysrKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigt KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2lubm8taGRtaS5jIGIv ZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9pbm5vLWhkbWkuYwo+IGluZGV4IGQ3YzMzYjkyZTJkZGY0 Y2VkODRkMTczMDQ0NjNmNDRiZTUyMjcwYjguLmQyOTgzMjI0OWI5NDJkZWM4NGZiOWQwN2EwYjIx ZWU3NTFmYzA0ODYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9pbm5vLWhk bWkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvaW5uby1oZG1pLmMKPiBAQCAtOTI5 LDcgKzkyOSwxMyBAQCBzdGF0aWMgaXJxcmV0dXJuX3QgaW5ub19oZG1pX2lycShpbnQgaXJxLCB2 b2lkICpkZXZfaWQpCj4gIHsKPiAgCXN0cnVjdCBpbm5vX2hkbWkgKmhkbWkgPSBkZXZfaWQ7Cj4g IAo+IC0JZHJtX2hlbHBlcl9ocGRfaXJxX2V2ZW50KGhkbWktPmJyaWRnZS5kZXYpOwo+ICsJLyoK PiArCSAqIFRoZSBpbnRlcnJ1cHQgaXMgcmVxdWVzdGVkIGJlZm9yZSB0aGUgYnJpZGdlIGlzIGF0 dGFjaGVkLCBhbmQKPiArCSAqIGJyaWRnZS5kZXYgaXMgb25seSBzZXQgYnkgZHJtX2JyaWRnZV9h dHRhY2goKS4gRHJvcCBob3RwbHVnIGV2ZW50cwo+ICsJICogdGhhdCBhcnJpdmUgYmVmb3JlIHRo ZW4gcmF0aGVyIHRoYW4gZGVyZWZlcmVuY2UgYSBOVUxMIGRybV9kZXZpY2UuCj4gKwkgKi8KPiAr CWlmIChoZG1pLT5icmlkZ2UuZGV2KQo+ICsJCWRybV9oZWxwZXJfaHBkX2lycV9ldmVudChoZG1p LT5icmlkZ2UuZGV2KTsKClJldmlld2VkLWJ5OiBIZWlrbyBTdHVlYm5lciA8aGVpa29Ac250ZWNo LmRlPgoKTW9zdCBvdGhlciBjYWxsZXJzIG9mIGRybV9oZWxwZXJfaHBkX2lycV9ldmVudCgpIGFs c28gZG8gZXhhY3RseSB0aGlzLgoKCkhlaWtvCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1y b2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.11.138.130 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793382256; b=ZmK9muYaO7M7FseN62sVBjBO2ODDlUujUHxd3AZFk8I6ZzVr1pTRtxrEovPpZNQQrMBo 4tPdV/ufZuqNFNUvQsZIYYoRR9Qgkd8yzHmOmVDUYeB5e0VJrpeCCRpelr79ZeqE7woJa 6+a5RIg/j1WTGv7cDUXnc+K2AJEmLuZzM5lJV2p7a5YjDH5GXn6L7+ivQkTvI5JTo2QrL a39rEI+QdRf0vGuKsqOATvxp1d8JGAdXg6Zf4Rfj+rF5hN35euAVad6Ke5J0sKMGCgX0k stecKj2DRnsJeEsHfF75yr/qLPAZTKUwd69B2qzu1JrPhOgRBDs1sUhSjLM4d9OmqKw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793382256; h=DMARC-Filter:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding: Content-Type; bh=usSQk3gmkVPvTdjKUU6vUCEb73RASrZuENLTQo/CskA=; b=EaayBxo6X67HuJEgYdcQQ4B0gx4kroKiMPMRr2fvoLlgtF6kYs5DHW0QVKgMO2dSSkIT t1/V5369CAGufs43ZrrmpbFRmPBSaYA+KoPr0LxGRQLSCXyyE9e8Ds548/E5HB0eqSdbn gqHM6lEdANgOzrKCAuneDwWbr5ynciGouBs005SvIbz7hbEUswx8ZpP0H5OLwFm89eAzv V5J76FqhuQ++zdwt1upSAOmb2TiNaXrU+Cow4B0NEv7qX2VtX8a87Sb9VixcJd2XEGn6S HFpXp34bSa6gtvY4aSGlhRz+biFs7qEgJDFDh9pRi6LzPrBtv7YQm0WFw4MHJmEx+NA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=U9kWFnfC; arc=none smtp.remote-ip=185.11.138.130 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8C50606A31A; Fri, 30 Oct 2026 17:44:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B8C50606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=U9kWFnfC DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=usSQk3gmkVPvTdjKUU6vUCEb73RASrZuENLTQo/CskA=; b=U9kWFnfC3oQMbgDNWHcOQJ/NJT HfgLlU43wb+0bVziHK6qseWoW1WMNY9f8Yajz9bGzugJq2zGqk+5Zl/V7gMxjMMyR2ibJg2DM/cKq mFzfarqU1oKC/MKLL6HJdfJrlr9ls7aCcDDFy74PBnwrJJomtlNsDXUz13oWND07rvw4PsnCH04QP aYc/Td6PEoaEgs9zzYMyNlzWqaiAeywaleFvaOvv0NUvxO68TRI9g5PexamYMQFGhtIA9nmouBK2A hlhLO7I37xAuZou/gPdDekGMLTi100S6UetXWliTUUnG1AXLWeo3vVV6iXXbak+pKHorNBooaP+i1 QmeOqqOg==; From: Heiko Stuebner To: Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Philipp Zabel , Emil Renner Berthing , Hal Feng , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Dominique Belhachemi , Andy Yan , David Airlie , Simona Vetter , Yakir Yang , Dmitry Baryshkov , Michal Wilczynski , Conor Dooley , William Qiu , Xingyu Wu , Sandy Huang , Manivannan Sadhasivam , Michal Wilczynski Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, Marek Szyprowski , Maud Spierings , Graham Markall , Icenowy Zheng , Chaoyi Chen , Joshua Peisach , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Subject: Re: [PATCH v6 02/18] drm/bridge: inno-hdmi: Don't dereference a NULL drm_device on hotplug Date: Fri, 30 Oct 2026 18:43:47 +0100 Message-ID: <1844578.vCJZsxu672@phil> In-Reply-To: <20261029-jh7110-clean-send-v6-2-759594e43acf@samsung.com> References: <20261029-jh7110-clean-send-v6-0-759594e43acf@samsung.com> <20261029-jh7110-clean-send-v6-2-759594e43acf@samsung.com> X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Am Donnerstag, 29. Oktober 2026, 08:53:36 Mitteleurop=C3=A4ische Normalzeit= schrieb Michal Wilczynski: > inno_hdmi_irq() passes hdmi->bridge.dev to drm_helper_hpd_irq_event(), > which dereferences it in its first statement: >=20 > if (!dev->mode_config.poll_enabled) >=20 > bridge.dev is assigned only by drm_bridge_attach(), but inno_hdmi_bind() > unmutes the hotplug interrupt in inno_hdmi_init_hw() and installs the > handler well before it attaches the bridge: >=20 > inno_hdmi_init_hw(hdmi); /* unmutes hotplug */ > devm_request_threaded_irq(...); /* handler goes live */ > ... > hdmi->bridge.ddc =3D inno_hdmi_i2c_adapter(hdmi); > devm_drm_bridge_add(dev, &hdmi->bridge); > drm_bridge_attach(...); /* bridge.dev set here */ >=20 > The bridge is allocated by devm_drm_bridge_alloc(), which kzalloc()s it, > so bridge.dev is NULL for all of that window, and a hotplug event > arriving in it enters drm_helper_hpd_irq_event(NULL). >=20 > Before the conversion to a bridge the ordering was safe: > inno_hdmi_register() called drmm_connector_hdmi_init(), which set > connector.dev, before the interrupt was requested. >=20 > Drop hotplug events that arrive before the bridge is attached. >=20 > Fixes: 969325a2597e ("drm/rockchip: inno-hdmi: Convert to drm bridge") > Signed-off-by: Michal Wilczynski > --- > drivers/gpu/drm/bridge/inno-hdmi.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/bridge/inno-hdmi.c b/drivers/gpu/drm/bridge/= inno-hdmi.c > index d7c33b92e2ddf4ced84d17304463f44be52270b8..d29832249b942dec84fb9d07a= 0b21ee751fc0486 100644 > --- a/drivers/gpu/drm/bridge/inno-hdmi.c > +++ b/drivers/gpu/drm/bridge/inno-hdmi.c > @@ -929,7 +929,13 @@ static irqreturn_t inno_hdmi_irq(int irq, void *dev_= id) > { > struct inno_hdmi *hdmi =3D dev_id; > =20 > - drm_helper_hpd_irq_event(hdmi->bridge.dev); > + /* > + * The interrupt is requested before the bridge is attached, and > + * bridge.dev is only set by drm_bridge_attach(). Drop hotplug events > + * that arrive before then rather than dereference a NULL drm_device. > + */ > + if (hdmi->bridge.dev) > + drm_helper_hpd_irq_event(hdmi->bridge.dev); Reviewed-by: Heiko Stuebner Most other callers of drm_helper_hpd_irq_event() also do exactly this. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6886E606A324 for ; Fri, 30 Oct 2026 17:44:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=eujIEgp0; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=U9kWFnfC DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=p7Uu4hNXqTUnjrLSrbq2nfdMuA6frnanbQ1d6xcM3ng=; b=eujIEgp0QcqfAPJHpOKrX4/xeD D/nzoRaD978FUR7xw08ZThz4wWrc2siAyKdjttA/DOL3jWhsoRY4twSr2YY9tzIgfezAP3zcyZ7Mj vEMPQseHnNGTlX3jAJqBr6OXRnM/xQcWaQ/2u1WLn5MMTcr1ZqYBqG8/s0UnCEOtkkAzm3OH5yhFm zpP8rMZ1vVy5rvkBUXEG3v273oO/XgIPudWZfWK5zfBgABJMdTl3erRsn2xUom3IWIDVPyW7unUQt DYt6AcUQa3HX15jSxWYb9z6rD7aFU62ev3ZtWJQNUfvqq6ur+zXpt/M72bXlQbTLXE34xMJLSqhIa QNdUkvAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMqeL-0000000CGe4-0jjZ; Fri, 30 Oct 2026 17:44:21 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMqeI-0000000CGdI-1mOX; Fri, 30 Oct 2026 17:44:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=usSQk3gmkVPvTdjKUU6vUCEb73RASrZuENLTQo/CskA=; b=U9kWFnfC3oQMbgDNWHcOQJ/NJT HfgLlU43wb+0bVziHK6qseWoW1WMNY9f8Yajz9bGzugJq2zGqk+5Zl/V7gMxjMMyR2ibJg2DM/cKq mFzfarqU1oKC/MKLL6HJdfJrlr9ls7aCcDDFy74PBnwrJJomtlNsDXUz13oWND07rvw4PsnCH04QP aYc/Td6PEoaEgs9zzYMyNlzWqaiAeywaleFvaOvv0NUvxO68TRI9g5PexamYMQFGhtIA9nmouBK2A hlhLO7I37xAuZou/gPdDekGMLTi100S6UetXWliTUUnG1AXLWeo3vVV6iXXbak+pKHorNBooaP+i1 QmeOqqOg==; From: Heiko Stuebner To: Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Philipp Zabel , Emil Renner Berthing , Hal Feng , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Dominique Belhachemi , Andy Yan , David Airlie , Simona Vetter , Yakir Yang , Dmitry Baryshkov , Michal Wilczynski , Conor Dooley , William Qiu , Xingyu Wu , Sandy Huang , Manivannan Sadhasivam , Michal Wilczynski Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, Marek Szyprowski , Maud Spierings , Graham Markall , Icenowy Zheng , Chaoyi Chen , Joshua Peisach , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Subject: Re: [PATCH v6 02/18] drm/bridge: inno-hdmi: Don't dereference a NULL drm_device on hotplug Date: Fri, 30 Oct 2026 18:43:47 +0100 Message-ID: <1844578.vCJZsxu672@phil> In-Reply-To: <20261029-jh7110-clean-send-v6-2-759594e43acf@samsung.com> References: <20261029-jh7110-clean-send-v6-0-759594e43acf@samsung.com> <20261029-jh7110-clean-send-v6-2-759594e43acf@samsung.com> X-Archived-By: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261030_104418_464062_EB3C8964 X-CRM114-Status: GOOD ( 20.47 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 QW0gRG9ubmVyc3RhZywgMjkuIE9rdG9iZXIgMjAyNiwgMDg6NTM6MzYgTWl0dGVsZXVyb3DDpGlz Y2hlIE5vcm1hbHplaXQgc2NocmllYiBNaWNoYWwgV2lsY3p5bnNraToKPiBpbm5vX2hkbWlfaXJx KCkgcGFzc2VzIGhkbWktPmJyaWRnZS5kZXYgdG8gZHJtX2hlbHBlcl9ocGRfaXJxX2V2ZW50KCks Cj4gd2hpY2ggZGVyZWZlcmVuY2VzIGl0IGluIGl0cyBmaXJzdCBzdGF0ZW1lbnQ6Cj4gCj4gCWlm ICghZGV2LT5tb2RlX2NvbmZpZy5wb2xsX2VuYWJsZWQpCj4gCj4gYnJpZGdlLmRldiBpcyBhc3Np Z25lZCBvbmx5IGJ5IGRybV9icmlkZ2VfYXR0YWNoKCksIGJ1dCBpbm5vX2hkbWlfYmluZCgpCj4g dW5tdXRlcyB0aGUgaG90cGx1ZyBpbnRlcnJ1cHQgaW4gaW5ub19oZG1pX2luaXRfaHcoKSBhbmQg aW5zdGFsbHMgdGhlCj4gaGFuZGxlciB3ZWxsIGJlZm9yZSBpdCBhdHRhY2hlcyB0aGUgYnJpZGdl Ogo+IAo+IAlpbm5vX2hkbWlfaW5pdF9odyhoZG1pKTsJCS8qIHVubXV0ZXMgaG90cGx1ZyAqLwo+ IAlkZXZtX3JlcXVlc3RfdGhyZWFkZWRfaXJxKC4uLik7CQkvKiBoYW5kbGVyIGdvZXMgbGl2ZSAq Lwo+IAkuLi4KPiAJaGRtaS0+YnJpZGdlLmRkYyA9IGlubm9faGRtaV9pMmNfYWRhcHRlcihoZG1p KTsKPiAJZGV2bV9kcm1fYnJpZGdlX2FkZChkZXYsICZoZG1pLT5icmlkZ2UpOwo+IAlkcm1fYnJp ZGdlX2F0dGFjaCguLi4pOwkJCS8qIGJyaWRnZS5kZXYgc2V0IGhlcmUgKi8KPiAKPiBUaGUgYnJp ZGdlIGlzIGFsbG9jYXRlZCBieSBkZXZtX2RybV9icmlkZ2VfYWxsb2MoKSwgd2hpY2gga3phbGxv YygpcyBpdCwKPiBzbyBicmlkZ2UuZGV2IGlzIE5VTEwgZm9yIGFsbCBvZiB0aGF0IHdpbmRvdywg YW5kIGEgaG90cGx1ZyBldmVudAo+IGFycml2aW5nIGluIGl0IGVudGVycyBkcm1faGVscGVyX2hw ZF9pcnFfZXZlbnQoTlVMTCkuCj4gCj4gQmVmb3JlIHRoZSBjb252ZXJzaW9uIHRvIGEgYnJpZGdl IHRoZSBvcmRlcmluZyB3YXMgc2FmZToKPiBpbm5vX2hkbWlfcmVnaXN0ZXIoKSBjYWxsZWQgZHJt bV9jb25uZWN0b3JfaGRtaV9pbml0KCksIHdoaWNoIHNldAo+IGNvbm5lY3Rvci5kZXYsIGJlZm9y ZSB0aGUgaW50ZXJydXB0IHdhcyByZXF1ZXN0ZWQuCj4gCj4gRHJvcCBob3RwbHVnIGV2ZW50cyB0 aGF0IGFycml2ZSBiZWZvcmUgdGhlIGJyaWRnZSBpcyBhdHRhY2hlZC4KPiAKPiBGaXhlczogOTY5 MzI1YTI1OTdlICgiZHJtL3JvY2tjaGlwOiBpbm5vLWhkbWk6IENvbnZlcnQgdG8gZHJtIGJyaWRn ZSIpCj4gU2lnbmVkLW9mZi1ieTogTWljaGFsIFdpbGN6eW5za2kgPG0ud2lsY3p5bnNraUBzYW1z dW5nLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9pbm5vLWhkbWkuYyB8IDgg KysrKysrKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigt KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2lubm8taGRtaS5jIGIv ZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9pbm5vLWhkbWkuYwo+IGluZGV4IGQ3YzMzYjkyZTJkZGY0 Y2VkODRkMTczMDQ0NjNmNDRiZTUyMjcwYjguLmQyOTgzMjI0OWI5NDJkZWM4NGZiOWQwN2EwYjIx ZWU3NTFmYzA0ODYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9pbm5vLWhk bWkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvaW5uby1oZG1pLmMKPiBAQCAtOTI5 LDcgKzkyOSwxMyBAQCBzdGF0aWMgaXJxcmV0dXJuX3QgaW5ub19oZG1pX2lycShpbnQgaXJxLCB2 b2lkICpkZXZfaWQpCj4gIHsKPiAgCXN0cnVjdCBpbm5vX2hkbWkgKmhkbWkgPSBkZXZfaWQ7Cj4g IAo+IC0JZHJtX2hlbHBlcl9ocGRfaXJxX2V2ZW50KGhkbWktPmJyaWRnZS5kZXYpOwo+ICsJLyoK PiArCSAqIFRoZSBpbnRlcnJ1cHQgaXMgcmVxdWVzdGVkIGJlZm9yZSB0aGUgYnJpZGdlIGlzIGF0 dGFjaGVkLCBhbmQKPiArCSAqIGJyaWRnZS5kZXYgaXMgb25seSBzZXQgYnkgZHJtX2JyaWRnZV9h dHRhY2goKS4gRHJvcCBob3RwbHVnIGV2ZW50cwo+ICsJICogdGhhdCBhcnJpdmUgYmVmb3JlIHRo ZW4gcmF0aGVyIHRoYW4gZGVyZWZlcmVuY2UgYSBOVUxMIGRybV9kZXZpY2UuCj4gKwkgKi8KPiAr CWlmIChoZG1pLT5icmlkZ2UuZGV2KQo+ICsJCWRybV9oZWxwZXJfaHBkX2lycV9ldmVudChoZG1p LT5icmlkZ2UuZGV2KTsKClJldmlld2VkLWJ5OiBIZWlrbyBTdHVlYm5lciA8aGVpa29Ac250ZWNo LmRlPgoKTW9zdCBvdGhlciBjYWxsZXJzIG9mIGRybV9oZWxwZXJfaHBkX2lycV9ldmVudCgpIGFs c28gZG8gZXhhY3RseSB0aGlzLgoKCkhlaWtvCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNj dkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtcmlzY3YK