From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58843)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bhxwl-00049c-Pd
	for qemu-devel@nongnu.org; Thu, 08 Sep 2016 07:56:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bhxwf-0003Aq-Pt
	for qemu-devel@nongnu.org; Thu, 08 Sep 2016 07:56:46 -0400
Received: from mx6-phx2.redhat.com ([209.132.183.39]:49160)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bhxwf-0003Al-IV
	for qemu-devel@nongnu.org; Thu, 08 Sep 2016 07:56:41 -0400
Date: Thu, 8 Sep 2016 07:56:38 -0400 (EDT)
From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <mlureau@redhat.com>
Message-ID: <1848526494.767098.1473335798486.JavaMail.zimbra@redhat.com>
In-Reply-To: <86AAE458-EC2F-4814-88A9-E3E7F93AD274@nutanix.com>
References: <1473323650-13298-1-git-send-email-maxime.coquelin@redhat.com>
	<1473323650-13298-3-git-send-email-maxime.coquelin@redhat.com>
	<86AAE458-EC2F-4814-88A9-E3E7F93AD274@nutanix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] vhost-user: only seek a reply if
 needed in set_mem_table
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Maxime Coquelin <maxime.coquelin@redhat.com>, Prerna Saxena <prerna.saxena@nutanix.com>
Cc: mst@redhat.com, qemu-devel@nongnu.org, marcandre lureau <marcandre.lureau@redhat.com>, peter maydell <peter.maydell@linaro.org>

Hi

----- Original Message -----
> Regarding Patch 2/2:
> This patch seems to filter responses from set_mem_table only for certain
> updates of memory regions. It violates the definition of the REPLY_ACK
> feature. This feature expects the client to send a response for every call
> of set_mem_table. And here, qemu exits the set_mem_table() function in some
> cases without even waiting for the reply that is going to come in.
> 

Agreed with Prerna here,

Furthermore, I haven't followed closely the recents developments, and the commit message doesn't explain why it should not be necessary to sync the first time set-mem-table is called. Could you develop that?

thanks