From: Marek Lindner <mareklindner@neomailbox.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv3 8/8] batman-adv: add debugfs support to view multiif tables
Date: Thu, 21 Nov 2013 09:41:26 +0800 [thread overview]
Message-ID: <18492403.daOuMBLdry@diderot> (raw)
In-Reply-To: <1384366492-27310-9-git-send-email-sw@simonwunderlich.de>
[-- Attachment #1: Type: text/plain, Size: 979 bytes --]
On Wednesday 13 November 2013 19:14:52 Simon Wunderlich wrote:
> +/**
> + * batadv_originators_open_multiif - handles debugfs output for the
> + * originators_multiif table
> + * @inode: inode pointer to debugfs file
> + * @file: pointer to the seq_file
> + */
> +static int batadv_originators_open_multiif(struct inode *inode,
> + struct file *file)
> +{
> + struct net_device *net_dev = (struct net_device *)inode->i_private;
> + return single_open(file, batadv_orig_multiif_seq_print_text, net_dev);
> +}
Please find a better name than 'multiif'. That term isn't used in any function
your patchset introduced. How about: batadv_originators_iface_open() ?
> +/**
> + * batadv_orig_multiif_seq_print_text - writes originator infos for all
> + * outgoing interfaces
> + * @seq: debugfs table seq_file struct
> + * @offset: not used
> + *
> + * Returns 0
> + */
> +int batadv_orig_multiif_seq_print_text(struct seq_file *seq, void *offset)
Same here.
Cheers,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
prev parent reply other threads:[~2013-11-21 1:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 18:14 [B.A.T.M.A.N.] [PATCHv3 0/8] add network wide multi interface optimization Simon Wunderlich
2013-11-13 18:14 ` [B.A.T.M.A.N.] [PATCHv3 1/8] batman-adv: remove bonding and interface alternating Simon Wunderlich
2013-11-21 1:23 ` Marek Lindner
2013-11-13 18:14 ` [B.A.T.M.A.N.] [PATCHv3 2/8] batman-adv: split tq information in neigh_node struct Simon Wunderlich
2013-11-21 1:25 ` Marek Lindner
2013-11-13 18:14 ` [B.A.T.M.A.N.] [PATCHv3 3/8] batman-adv: split out router from orig_node Simon Wunderlich
2013-11-21 1:26 ` Marek Lindner
2013-11-13 18:14 ` [B.A.T.M.A.N.] [PATCHv3 4/8] batman-adv: add WiFi penalty Simon Wunderlich
2013-11-21 1:28 ` Marek Lindner
2013-11-13 18:14 ` [B.A.T.M.A.N.] [PATCHv3 5/8] batman-adv: consider outgoing interface in OGM sending Simon Wunderlich
2013-11-21 1:29 ` Marek Lindner
2013-11-13 18:14 ` [B.A.T.M.A.N.] [PATCHv3 6/8] batman-adv: add bonding again Simon Wunderlich
2013-11-21 1:31 ` Marek Lindner
2013-11-13 18:14 ` [B.A.T.M.A.N.] [PATCHv3 7/8] batman-adv: add debugfs structure for information per interface Simon Wunderlich
2013-11-21 1:38 ` Marek Lindner
2013-11-21 13:22 ` Simon Wunderlich
2013-11-13 18:14 ` [B.A.T.M.A.N.] [PATCHv3 8/8] batman-adv: add debugfs support to view multiif tables Simon Wunderlich
2013-11-21 1:41 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18492403.daOuMBLdry@diderot \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.