From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steve Grubb <sgrubb@redhat.com>
Subject: Re: [PATCH 2/2] lost_reset: return value rather than sequence number
	when zero
Date: Mon, 27 Nov 2017 17:16:53 -0500
Message-ID: <1850273.jPBnK7MvUs@x2>
References: <1511395257-6321-1-git-send-email-rgb@redhat.com>
	<1511395257-6321-3-git-send-email-rgb@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <linux-audit-bounces@redhat.com>
In-Reply-To: <1511395257-6321-3-git-send-email-rgb@redhat.com>
List-Unsubscribe: <https://www.redhat.com/mailman/options/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: Richard Guy Briggs <rgb@redhat.com>
Cc: linux-audit@redhat.com
List-Id: linux-audit@redhat.com

On Wednesday, November 22, 2017 7:00:57 PM EST Richard Guy Briggs wrote:
> The kernel always returns negative values on error, so zero and anything
> positive is valid success.  Lost_reset returned a positive value at the
> time of reset, including zero that got interpreted as success and
> replaced with the packet sequence number "2".
> 
> Rename audit_send() to __audit_send() and pass the sequence number back
> via a parameter rather than return value.
> 
> Have a new stub audit_send() call __audit_send() and mimic the previous
> behaviour of audit_send()

Applied,

Thanks,
-Steve