From: Thomas Monjalon <thomas@monjalon.net>
To: Junjie Chen <junjie.j.chen@intel.com>,
bruce.richardson@intel.com, konstantin.ananyev@intel.com
Cc: dev@dpdk.org
Subject: Re: [PATCH] eal: force gcc to inline rte_movX function
Date: Tue, 17 Apr 2018 15:22:06 +0200 [thread overview]
Message-ID: <1852475.4XxgDvW1hG@xps> (raw)
In-Reply-To: <20180412051636.240746-1-junjie.j.chen@intel.com>
12/04/2018 07:16, Junjie Chen:
> From: "Chen, Junjie" <junjie.j.chen@intel.com>
>
> Sometimes gcc does not inline the function despite keyword *inline*,
> we obeserve rte_movX is not inline when doing performance profiling,
> so use *always_inline* keyword to force gcc to inline the function.
>
> Signed-off-by: Chen, Junjie <junjie.j.chen@intel.com>
> ---
> .../common/include/arch/x86/rte_memcpy.h | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
The title should start with "eal/x86:"
Something like that:
eal/x86: force inlining of memcpy sub-functions
Bruce, Konstantin, any review of the content/optimization?
next prev parent reply other threads:[~2018-04-17 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 5:16 [PATCH] eal: force gcc to inline rte_movX function Junjie Chen
2018-04-17 13:22 ` Thomas Monjalon [this message]
2018-04-17 14:57 ` Bruce Richardson
2018-04-18 2:43 ` Chen, Junjie J
2018-04-18 7:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1852475.4XxgDvW1hG@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=junjie.j.chen@intel.com \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.