From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] pci: fix level of scan debug log on BSD
Date: Thu, 03 Aug 2017 17:36:41 +0200
Message-ID: <1852586.cdvAFzMDef@xps>
References: <20170711171046.22558-1-thomas@monjalon.net>
 <20170803101622.GA42296@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id C576F324B
 for <dev@dpdk.org>; Thu,  3 Aug 2017 17:36:43 +0200 (CEST)
In-Reply-To: <20170803101622.GA42296@bricha3-MOBL3.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

03/08/2017 12:16, Bruce Richardson:
> On Tue, Jul 11, 2017 at 07:10:46PM +0200, Thomas Monjalon wrote:
> > Printing the number of scanned devices should be a debug log,
> > not an error.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
[...]
> > -	RTE_LOG(ERR, EAL, "PCI scan found %u devices\n", dev_count);
> > +	RTE_LOG(DEBUG, EAL, "PCI scan found %u devices\n", dev_count);
> >  	return 0;
> >  
> would have gone for INFO level myself, but DEBUG works too - it's
> definitely not an error.
> The commit title also reads a bit strange to me. How about e.g.:
> "pci: log fix level of PCI scan summary message on BSD"
> 
> Otherwise:
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks