All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] GFS2: dirty inode correctly in	gfs2_write_end
Date: Wed, 4 Sep 2013 09:24:59 -0400 (EDT)	[thread overview]
Message-ID: <1853209014.8349754.1378301099929.JavaMail.root@redhat.com> (raw)
In-Reply-To: <20130903215942.GM2113@dhcp80-209.msp.redhat.com>

----- Original Message -----
| GFS2 was only setting I_DIRTY_DATASYNC on files that it wrote to, when
| it actually increased the file size.  If gfs2_fsync was called without
| I_DIRTY_DATASYNC set, it didn't flush the incore data to the log before
| returning, so any metadata or journaled data changes were not getting
| fsynced. This meant that writes to the middle of files were not always
| getting fsynced properly.
| 
| This patch makes gfs2 set I_DIRTY_DATASYNC whenever metadata has been
| updated during a write. It also make gfs2_sync flush the incore log
| if I_DIRTY_PAGES is set, and the file is using data journalling. This
| will make sure that all incore logged data gets written to disk before
| returning from a fsync.
| 
| Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>

Hi,

ACK

Bob Peterson
Red Hat File Systems



  reply	other threads:[~2013-09-04 13:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-03 21:59 [Cluster-devel] [PATCH] GFS2: dirty inode correctly in gfs2_write_end Benjamin Marzinski
2013-09-04 13:24 ` Bob Peterson [this message]
2013-09-04 14:55 ` Steven Whitehouse
2013-09-04 16:59   ` Benjamin Marzinski
2013-09-04 21:36     ` Steven Whitehouse
2013-09-05  3:48       ` Benjamin Marzinski
2013-09-05  8:28         ` Steven Whitehouse
2013-09-05  9:34 ` Steven Whitehouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1853209014.8349754.1378301099929.JavaMail.root@redhat.com \
    --to=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.