All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kareem Zarka" <zarkakareem@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] wic/plugins/source/bootimg-efi: Skip installing kernel-image into boot.
Date: Tue, 07 Feb 2023 06:53:01 -0800	[thread overview]
Message-ID: <1854.1675781581951378473@lists.openembedded.org> (raw)
In-Reply-To: <9910648fe8bc6cf03ce56385c038edee6502ea57.camel@linuxfoundation.org>

[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]

Dear Richard and Luca,

Thank you for your feedback. I will take it into consideration.

I understand that "XXX != False" and "not XXX" have different interpretations in Python.

The expression "XXX != False" only evaluates to True if XXX is not equal to False.

This means that if skip-kernel-install is None, the condition will be False.

On the other hand, "not XXX" evaluates to True if XXX is falsy, which includes None, False, 0, empty string, etc.

This is why I used it in my code, as I wanted to consider the case where skip-kernel-install is None.

Therefore, if skip-kernel-install is not provided, its value will be None, and the condition will be True, which means the kernel image will be installed.

However, if we want to enforce the requirement for the user to always provide the parameter skip-kernel-install with either the value true or false, we can make use (!= false , == true).

Let me know what suits us best in this case .

Kindest regards .

Kareem Zarka.

[-- Attachment #2: Type: text/html, Size: 1068 bytes --]

  reply	other threads:[~2023-02-07 14:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-06 19:16 [PATCH] wic/plugins/source/bootimg-efi: Skip installing kernel-image into boot Kareem Zarka
2023-02-06 19:16 ` [PATCH] meta/lib/oeqa/selftest/cases/wic: Add tests for kernel installation and skip-kernel-install in wic plugin Kareem Zarka
2023-02-07 10:49 ` [OE-core] [PATCH] wic/plugins/source/bootimg-efi: Skip installing kernel-image into boot Luca Ceresoli
2023-02-07 12:32   ` Richard Purdie
2023-02-07 14:53     ` Kareem Zarka [this message]
2023-02-08  8:31     ` Luca Ceresoli
2023-02-08 12:39       ` Kareem Zarka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1854.1675781581951378473@lists.openembedded.org \
    --to=zarkakareem@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.