From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Stephen Hemminger
<stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] vmxnet3: initialize receive mode correctly
Date: Tue, 26 Aug 2014 08:50:15 +0200 [thread overview]
Message-ID: <1854546.3MJ2KxFVuo@xps13> (raw)
In-Reply-To: <20140825173359.36a95050@urahara>
2014-08-25 17:33, Stephen Hemminger:
> Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> wrote:
> > 2014-07-25 10:50, Stephen Hemminger:
> > > - vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_ALL_MULTI, 1);
> > > + vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1);
> >
> > It's also removing multicast at init. No comment so I assume everybody agrees.
>
> My general rule is to make all drivers behave the same.
I think it's a good rule :)
> In DPDK, the ixgbe driver is the "best known" reference.
> In that driver "multicast promiscious" is disabled by default.
OK, thanks.
--
Thomas
prev parent reply other threads:[~2014-08-26 6:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 17:50 [PATCH] vmxnet3: initialize receive mode correctly Stephen Hemminger
[not found] ` <20140725105037.26769945-a7a0dvSY7KrRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
2014-08-01 14:50 ` Thomas Monjalon
2014-08-01 15:53 ` Stephen Hemminger
2014-08-26 0:33 ` Stephen Hemminger
2014-08-26 6:50 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1854546.3MJ2KxFVuo@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.