From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: ioemu build failure with GCC > 4.3
Date: Thu, 10 Jul 2008 10:49:48 +0100
Message-ID: <18549.56124.526376.460576@mariner.uk.xensource.com>
References: <37E52D09333DE2469A03574C88DBF40F021BEF97@pdsmsx414.ccr.corp.intel.com>
	<C49B9763.23DA8%keir.fraser@eu.citrix.com>
	<20080710094317.GE23601@redhat.com>
	<18549.55810.700581.571255@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <18549.55810.700581.571255@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Daniel P. Berrange" <berrange@redhat.com>, Keir Fraser <keir.fraser@eu.citrix.com>, "He, Qing" <qing.he@intel.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

iwj writes ("Re: [Xen-devel] ioemu build failure with GCC > 4.3"):
> Daniel P. Berrange writes ("Re: [Xen-devel] ioemu build failure with GCC > 4.3"):
> > None of the entire slirp directory looks like a good idea. This code
> > isn't even used in Xen is it ? My vote  would be disabling compilation
> > of entire slirp directory for Xen. 
> 
> This is the right answer, yes.

I've done this now.

Ian.

commit 29c20f126f298cf2162169b4bbb8206860f11240
Author: Ian Jackson <iwj@mariner.uk.xensource.com>
Date:   Thu Jul 10 10:48:51 2008 +0100

    Disable slirp.
    
    The slirp system is not really a very nice idea, especially not in a
    Xen context.  Also, the code misuses inline and does not compile on
    GCC >4.3ish.
    
    Thanks to Qing He <qing.he@intel.com> for the report.

diff --git a/xen-setup b/xen-setup
index c00122c..755b9ec 100755
--- a/xen-setup
+++ b/xen-setup
@@ -9,7 +9,7 @@ rm -f config-host.mak
 
 if test -f config-host.h; then mv config-host.h config-host.h~; fi
 
-./configure --disable-curses "$@" --prefix=/usr
+./configure --disable-curses --disable-slirp "$@" --prefix=/usr
 
 target=i386-dm