From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: gadget: uvc: fix up uvcg_v4l2_get_unmapped_area typo
Date: Mon, 29 Sep 2014 15:34:11 +0300 [thread overview]
Message-ID: <1855096.u0jNJntfok@avalon> (raw)
In-Reply-To: <3777003.OnaxFdNv7R@wuerfel>
Hi Arnd,
Thank you for the patch.
On Monday 29 September 2014 14:30:20 Arnd Bergmann wrote:
> Patch "usb: gadget: uvc: rename functions to avoid conflicts with host uvc"
> renamed a lot of symbols but missed one references that was inside of
> an #ifdef:
>
> drivers/usb/gadget/function/uvc_v4l2.c:363:23: error:
> 'uvcg_v4l2_get_unmapped_area' undeclared here (not in a function)
> .get_unmapped_area = uvcg_v4l2_get_unmapped_area,
> ^
> drivers/usb/gadget/function/uvc_v4l2.c:344:22: warning:
> 'uvc_v4l2_get_unmapped_area' defined but not used [-Wunused-function]
> static unsigned long uvc_v4l2_get_unmapped_area(struct file *file, ^
>
> This renames the reference according the changed function name.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7ea95b110811 ("usb: gadget: uvc: rename functions to avoid conflicts
> with host uvc") Cc: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
> Cc: Michael Grzeschik <m.grzeschik@pengutronix.de>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Felipe Balbi <balbi@ti.com>
> Cc: linux-usb at vger.kernel.org
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Felipe, could you please this up ?
> ---
> diff --git a/drivers/usb/gadget/function/uvc_v4l2.c
> b/drivers/usb/gadget/function/uvc_v4l2.c index b52f2681ec21..5aad7fededa5
> 100644
> --- a/drivers/usb/gadget/function/uvc_v4l2.c
> +++ b/drivers/usb/gadget/function/uvc_v4l2.c
> @@ -341,7 +341,7 @@ uvc_v4l2_poll(struct file *file, poll_table *wait)
> }
>
> #ifndef CONFIG_MMU
> -static unsigned long uvc_v4l2_get_unmapped_area(struct file *file,
> +static unsigned long uvcg_v4l2_get_unmapped_area(struct file *file,
> unsigned long addr, unsigned long len, unsigned long pgoff,
> unsigned long flags)
> {
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-09-29 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 12:30 [PATCH] usb: gadget: uvc: fix up uvcg_v4l2_get_unmapped_area typo Arnd Bergmann
2014-09-29 12:34 ` Laurent Pinchart [this message]
2014-09-29 15:48 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1855096.u0jNJntfok@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.