From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6393EC433EF for ; Tue, 16 Nov 2021 11:13:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7A676139F for ; Tue, 16 Nov 2021 11:13:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D7A676139F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vckTxCn3inteEhsIifPPmUTWjtwjfRhb9vspmmK5S8c=; b=AzBPZLEinhTdFS ODlkhcfe4obpkdEgeBGC8g9xCA2w2dw3StQd3J9FnzwLGC8Kjy70gjYl+7NNWoeS5IuOA2smWOFs4 0HNLLY8yCPJTDmEpsusybQk4HlaUzWnQnQ9zFfq5Zw2nrVmcbRs/z4PlF+XiR/l2FWcqGp5s2yX27 8RdTOBlpMWF2Fvv5Jm9aOPrvx1FvGGPVggPxzQKR5doBpXTlbn4DHfHsnTKzdFVunFlpFWZrGAUS6 ZEciXaRdTUjqkRswAvIioNOSZx2pWzs9Bx9Up3L6NrAZUsl+HmlMK/XPtOrVyv5eZUxEnGKgmKWGu ceWdkT22+0CKKeScRxUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmwPC-001MCe-6F; Tue, 16 Nov 2021 11:13:38 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmwP7-001M9o-Q4 for linux-riscv@lists.infradead.org; Tue, 16 Nov 2021 11:13:35 +0000 Received: from ip5f5a6e92.dynamic.kabel-deutschland.de ([95.90.110.146] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmwOu-0003c8-H6; Tue, 16 Nov 2021 12:13:20 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Rob Herring , Paul Walmsley , Palmer Dabbelt , Albert Ou , Qiu Wenbo , Yash Shah , devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Abdurachmanov , Krzysztof Kozlowski Cc: Vincent Pelletier Subject: Re: [PATCH] riscv: dts: sifive unmatched: Expose the FU740 core supply regulator. Date: Tue, 16 Nov 2021 12:13:18 +0100 Message-ID: <1856369.5VkklvvnQl@diego> In-Reply-To: <202f0fd8-1208-b17d-5ee5-e776e45cb065@canonical.com> References: <2266648.AD6qrfpaa2@diego> <202f0fd8-1208-b17d-5ee5-e776e45cb065@canonical.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211116_031333_897429_70B405E7 X-CRM114-Status: GOOD ( 29.30 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Am Dienstag, 16. November 2021, 12:08:01 CET schrieb Krzysztof Kozlowski: > On 16/11/2021 10:53, Heiko St=FCbner wrote: > > Hi Vincent, > > = > > Am Dienstag, 16. November 2021, 01:52:59 CET schrieb Vincent Pelletier: > >> Provides monitoring of core voltage and current: > >> tps544b20-i2c-0-1e > >> Adapter: i2c-ocores > >> vout1: 906.00 mV > >> temp1: -40.0=B0C (high =3D +125.0=B0C, crit =3D +150.0=B0C) > >> iout1: 5.06 A (max =3D +20.00 A, crit max =3D +26.00 A) > >> > >> Signed-off-by: Vincent Pelletier > >> > >> -- > >> Note for review: this patch has one warning from checkpatch.pl: > >> WARNING: DT compatible string "tps544b20" appears un-documented -- c= heck ./Documentation/devicetree/bindings/ > >> #32: FILE: arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts:55: > >> + compatible =3D "tps544b20"; > >> This chip is handled by the existing pmbus module, and there is indeed= no > >> matching entry in Documentation/devicetree/bindings/hwmon/pmbus. I am = not > >> especially knowledgeable about this chip, I only know it is used by th= is > >> board, so I am not sure I can do the best job in putting such a file > >> together. > >> If needed I can git it a try. > > = > > Devicetree bindings are supposed to be stable into the future, so an ac= tually > > reviewed binding is quite necessary ;-) . > > = > > In the case of your tps544b20 it should also be pretty easy to do, as > > = > > Documentation/devicetree/bindings/hwmon/pmbus/ti,ucd90320.yaml > > = > > is probably a pretty good match to what you need in terms of Yaml notat= ion. > > Just need to replace the naming in your copy and drop in the correct > > description from > > = > > https://www.ti.com/lit/ds/symlink/tps544b20.pdf?ts=3D1637055780278 > > = > > and you have a working binding. > > = > > Then just add another patch to your series that mimics > > = > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/com= mit/?id=3D8a36e38d8b0fbb92609e837a67f919202ec7ec51 > > = > > and include the relevant maintainers that scripts/get_maintainer.pl will > > give you, and you're all set :-) > > = > = > Hi Heiko, > = > In current form the bindings would be close to trivial and we actually > do not know how proper bindings would look like (the device is not > trivial). Therefore based on Rob's recent comments - better to have > trivial schema than nothing - I sent a patch adding them to trivial-devic= es: > = > https://lore.kernel.org/linux-devicetree/20211116110207.68494-1-krzysztof= .kozlowski@canonical.com/T/#u Though I guess there isn't anything hindering additions to a individual simpler binding. But yeah, just adding it to trivial devices will also just work for now, as= there really are no additional properties right now and might make the process a tad shorter ;-) Heiko _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28E3DC433EF for ; Tue, 16 Nov 2021 11:13:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0CF4A63213 for ; Tue, 16 Nov 2021 11:13:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234581AbhKPLQd convert rfc822-to-8bit (ORCPT ); Tue, 16 Nov 2021 06:16:33 -0500 Received: from gloria.sntech.de ([185.11.138.130]:49022 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234742AbhKPLQd (ORCPT ); Tue, 16 Nov 2021 06:16:33 -0500 Received: from ip5f5a6e92.dynamic.kabel-deutschland.de ([95.90.110.146] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmwOu-0003c8-H6; Tue, 16 Nov 2021 12:13:20 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Rob Herring , Paul Walmsley , Palmer Dabbelt , Albert Ou , Qiu Wenbo , Yash Shah , devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Abdurachmanov , Krzysztof Kozlowski Cc: Vincent Pelletier Subject: Re: [PATCH] riscv: dts: sifive unmatched: Expose the FU740 core supply regulator. Date: Tue, 16 Nov 2021 12:13:18 +0100 Message-ID: <1856369.5VkklvvnQl@diego> In-Reply-To: <202f0fd8-1208-b17d-5ee5-e776e45cb065@canonical.com> References: <2266648.AD6qrfpaa2@diego> <202f0fd8-1208-b17d-5ee5-e776e45cb065@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Dienstag, 16. November 2021, 12:08:01 CET schrieb Krzysztof Kozlowski: > On 16/11/2021 10:53, Heiko Stübner wrote: > > Hi Vincent, > > > > Am Dienstag, 16. November 2021, 01:52:59 CET schrieb Vincent Pelletier: > >> Provides monitoring of core voltage and current: > >> tps544b20-i2c-0-1e > >> Adapter: i2c-ocores > >> vout1: 906.00 mV > >> temp1: -40.0°C (high = +125.0°C, crit = +150.0°C) > >> iout1: 5.06 A (max = +20.00 A, crit max = +26.00 A) > >> > >> Signed-off-by: Vincent Pelletier > >> > >> -- > >> Note for review: this patch has one warning from checkpatch.pl: > >> WARNING: DT compatible string "tps544b20" appears un-documented -- check ./Documentation/devicetree/bindings/ > >> #32: FILE: arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts:55: > >> + compatible = "tps544b20"; > >> This chip is handled by the existing pmbus module, and there is indeed no > >> matching entry in Documentation/devicetree/bindings/hwmon/pmbus. I am not > >> especially knowledgeable about this chip, I only know it is used by this > >> board, so I am not sure I can do the best job in putting such a file > >> together. > >> If needed I can git it a try. > > > > Devicetree bindings are supposed to be stable into the future, so an actually > > reviewed binding is quite necessary ;-) . > > > > In the case of your tps544b20 it should also be pretty easy to do, as > > > > Documentation/devicetree/bindings/hwmon/pmbus/ti,ucd90320.yaml > > > > is probably a pretty good match to what you need in terms of Yaml notation. > > Just need to replace the naming in your copy and drop in the correct > > description from > > > > https://www.ti.com/lit/ds/symlink/tps544b20.pdf?ts=1637055780278 > > > > and you have a working binding. > > > > Then just add another patch to your series that mimics > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8a36e38d8b0fbb92609e837a67f919202ec7ec51 > > > > and include the relevant maintainers that scripts/get_maintainer.pl will > > give you, and you're all set :-) > > > > Hi Heiko, > > In current form the bindings would be close to trivial and we actually > do not know how proper bindings would look like (the device is not > trivial). Therefore based on Rob's recent comments - better to have > trivial schema than nothing - I sent a patch adding them to trivial-devices: > > https://lore.kernel.org/linux-devicetree/20211116110207.68494-1-krzysztof.kozlowski@canonical.com/T/#u Though I guess there isn't anything hindering additions to a individual simpler binding. But yeah, just adding it to trivial devices will also just work for now, as there really are no additional properties right now and might make the process a tad shorter ;-) Heiko