From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:33747 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890AbaLCMr7 (ORCPT ); Wed, 3 Dec 2014 07:47:59 -0500 From: Laurent Pinchart To: Philipp Zabel Cc: Mauro Carvalho Chehab , Hans Verkuil , Boris Brezillon , linux-media@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats Date: Wed, 03 Dec 2014 14:48:35 +0200 Message-ID: <1857174.h7s3t8B9N4@avalon> In-Reply-To: <1417602500-29152-1-git-send-email-p.zabel@pengutronix.de> References: <1417602500-29152-1-git-send-email-p.zabel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Philipp, Thank you for the patch. On Wednesday 03 December 2014 11:28:18 Philipp Zabel wrote: > This patch adds two more 24-bit RGB formats. BGR888 is more or less common, > GBR888 is used on the internal connection between the IPU display interface > and the TVE (VGA DAC) on i.MX53 SoCs. Were RGB and BGR patented that they had to use a new format ? :-) > Signed-off-by: Philipp Zabel > --- > Documentation/DocBook/media/v4l/subdev-formats.xml | 60 +++++++++++++++++++ > include/uapi/linux/media-bus-format.h | 4 +- > 2 files changed, 63 insertions(+), 1 deletion(-) > > diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml > b/Documentation/DocBook/media/v4l/subdev-formats.xml index 52d7f04..f163767 > 100644 > --- a/Documentation/DocBook/media/v4l/subdev-formats.xml > +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml > @@ -499,6 +499,66 @@ > b1 > b0 > > + > + MEDIA_BUS_FMT_BGR888_1X24 > + 0x1013 > + > + &dash-ent-8; > + b7 > + b6 > + b5 > + b4 > + b3 > + b2 > + b1 > + b0 > + g7 > + g6 > + g5 > + g4 > + g3 > + g2 > + g1 > + g0 > + r7 > + r6 > + r5 > + r4 > + r3 > + r2 > + r1 > + r0 > + > + > + MEDIA_BUS_FMT_GBR888_1X24 > + 0x1014 > + > + &dash-ent-8; > + g7 > + g6 > + g5 > + g4 > + g3 > + g2 > + g1 > + g0 > + b7 > + b6 > + b5 > + b4 > + b3 > + b2 > + b1 > + b0 > + r7 > + r6 > + r5 > + r4 > + r3 > + r2 > + r1 > + r0 > + > > MEDIA_BUS_FMT_RGB888_2X12_BE > 0x100b > diff --git a/include/uapi/linux/media-bus-format.h > b/include/uapi/linux/media-bus-format.h index 7f8b1e2..6d7f0c7 100644 > --- a/include/uapi/linux/media-bus-format.h > +++ b/include/uapi/linux/media-bus-format.h > @@ -33,7 +33,7 @@ > > #define MEDIA_BUS_FMT_FIXED 0x0001 > > -/* RGB - next is 0x1013 */ > +/* RGB - next is 0x1015 */ > #define MEDIA_BUS_FMT_RGB444_1X12 0x100e > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 > @@ -47,6 +47,8 @@ > #define MEDIA_BUS_FMT_RGB666_1X18 0x1009 > #define MEDIA_BUS_FMT_RGB666_LVDS_SPWG 0x1010 > #define MEDIA_BUS_FMT_RGB888_1X24 0x100a > +#define MEDIA_BUS_FMT_BGR888_1X24 0x1013 > +#define MEDIA_BUS_FMT_GBR888_1X24 0x1014 Could you move these right before RGB888_1X24 to keep them sorted alphabetically ? Same for the documentation part. With this changed, Acked-by: Laurent Pinchart > #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b > #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c > #define MEDIA_BUS_FMT_RGB888_LVDS_SPWG 0x1011 -- Regards, Laurent Pinchart