From: Thomas Monjalon <thomas@monjalon.net>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Cc: dev@dpdk.org, Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Ori Kam <orika@mellanox.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Radu Nicolau <radu.nicolau@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Tomasz Kantecki <tomasz.kantecki@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix em mode datapath selection
Date: Fri, 03 May 2019 01:32:49 +0200 [thread overview]
Message-ID: <1860264.T1sj13Lf8p@xps> (raw)
In-Reply-To: <20190410072836.17496-1-pbhagavatula@marvell.com>
10/04/2019 09:29, Pavan Nikhilesh Bhagavatula:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Currently, l3wfd em mode has two datapath modes em_sequential and
> em_hlm. We can select either of them by defining NO_HASH_MULTI_LOOKUP to
> one or zero.
> The code checks if NO_HASH_MULTI_LOOKUP is defined or not instead of
> checking for the value.
>
> Fixes: 52c97adc1f0f ("examples/l3fwd: fix exact match performance")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
> --- a/examples/l3fwd/l3fwd_em.c
> +++ b/examples/l3fwd/l3fwd_em.c
> #if defined RTE_ARCH_X86 || defined RTE_MACHINE_CPUFLAG_NEON
> -#if defined(NO_HASH_MULTI_LOOKUP)
> +#if NO_HASH_MULTI_LOOKUP
It does not compile:
examples/l3fwd/l3fwd_em.c:302:5: error:
'NO_HASH_MULTI_LOOKUP' is not defined, evaluates to 0 [-Werror,-Wundef]
#if NO_HASH_MULTI_LOOKUP
Anyway such compilation option should be just removed.
Please replace it with a runtime option and/or make it documented.
Thanks
prev parent reply other threads:[~2019-05-02 23:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 7:29 [dpdk-dev] [PATCH] examples/l3fwd: fix em mode datapath selection Pavan Nikhilesh Bhagavatula
2019-04-22 21:20 ` Thomas Monjalon
2019-04-23 2:47 ` Pavan Nikhilesh Bhagavatula
2019-04-23 8:35 ` Thomas Monjalon
2019-04-23 9:12 ` Pavan Nikhilesh Bhagavatula
2019-04-24 2:59 ` Ruifeng Wang (Arm Technology China)
2019-05-02 23:32 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1860264.T1sj13Lf8p@xps \
--to=thomas@monjalon.net \
--cc=akhil.goyal@nxp.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=marko.kovacevic@intel.com \
--cc=orika@mellanox.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=pbhagavatula@marvell.com \
--cc=radu.nicolau@intel.com \
--cc=stable@dpdk.org \
--cc=tomasz.kantecki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.